public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: add reset vector docs, tweak temp stack / RAM
Date: Mon, 20 Nov 2017 15:22:17 +0000	[thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224AA486D4@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <b6402252-14cd-6f03-e1f3-a9fed0555edf@redhat.com>

Hi Laszlo,

Reviewed-by: Eric Dong <eric.dong@intel.com>

I'm ok with this change, Sorry for later response.

Thanks,
Eric
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Saturday, November 18, 2017 1:15 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: Re: [edk2] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: add reset vector
> docs, tweak temp stack / RAM
> 
> On 11/15/17 22:56, Laszlo Ersek wrote:
> > Repo:   https://github.com/lersek/edk2.git
> > Branch: temp_ram_tweaks_v2
> >
> > This is a series for
> >
> >   https://bugzilla.tianocore.org/show_bug.cgi?id=747
> >
> > specifically an update on the v1 series at
> >
> >   https://lists.01.org/pipermail/edk2-devel/2017-November/017239.html
> >
> > Each patch has its notes section on the changes relative to v1.
> >
> > I re-ran the unit tests described in some of the patches; in addition
> > to the functional tests and my usual regression tests.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> >
> > Thanks
> > Laszlo
> >
> > Laszlo Ersek (4):
> >   UefiCpuPkg/ResetVector/Vtf0: document segment register setup
> >   OvmfPkg/Sec/Ia32: seed the temporary RAM with
> PcdInitValueInTempStack
> >   OvmfPkg/Sec/X64: seed the temporary RAM with
> PcdInitValueInTempStack
> >   OvmfPkg: restore temporary SEC/PEI RAM size to 64KB
> >
> >  OvmfPkg/OvmfPkgIa32.fdf                             |  2 +-
> >  OvmfPkg/OvmfPkgIa32X64.fdf                          |  2 +-
> >  OvmfPkg/OvmfPkgX64.fdf                              |  2 +-
> >  OvmfPkg/Sec/Ia32/SecEntry.nasm                      | 18 +++++++++++++++++
> >  OvmfPkg/Sec/SecMain.inf                             |  1 +
> >  OvmfPkg/Sec/X64/SecEntry.nasm                       | 21
> ++++++++++++++++++++
> >  UefiCpuPkg/ResetVector/Vtf0/Ia16/Real16ToFlat32.asm |  6 ++++++
> >  UefiCpuPkg/ResetVector/Vtf0/Main.asm                |  5 +++++
> >  8 files changed, 54 insertions(+), 3 deletions(-)
> >
> 
> Pushed as commit range 1195b8578764..d41fd8e839a3.
> 
> (I didn't get a maintainer review from Eric for patch #1, but it adds only
> comments (no regressions possible) and Ard and Jordan reviewed that too.
> My queue is overflowing. :/)
> 
> Thanks!
> Laszlo

      reply	other threads:[~2017-11-20 15:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 21:56 [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: add reset vector docs, tweak temp stack / RAM Laszlo Ersek
2017-11-15 21:57 ` [PATCH v2 1/4] UefiCpuPkg/ResetVector/Vtf0: document segment register setup Laszlo Ersek
2017-11-16  9:31   ` Ard Biesheuvel
2017-11-15 21:57 ` [PATCH v2 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack Laszlo Ersek
2017-11-16  9:32   ` Ard Biesheuvel
2017-11-15 21:57 ` [PATCH v2 3/4] OvmfPkg/Sec/X64: " Laszlo Ersek
2017-11-16  9:33   ` Ard Biesheuvel
2017-11-15 21:57 ` [PATCH v2 4/4] OvmfPkg: restore temporary SEC/PEI RAM size to 64KB Laszlo Ersek
2017-11-16  0:57 ` [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: add reset vector docs, tweak temp stack / RAM Jordan Justen
2017-11-17 17:15 ` Laszlo Ersek
2017-11-20 15:22   ` Dong, Eric [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED077930C258884BBCB450DB737E66224AA486D4@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox