From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3FD442218E923 for ; Wed, 6 Dec 2017 18:46:40 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 18:51:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="10331998" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 06 Dec 2017 18:51:12 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:51:12 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 10:51:08 +0800 From: "Dong, Eric" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code Thread-Index: AQHTbwVuxJwQBSnCYEu+gaWZl+Hcf6M3LgHw Date: Thu, 7 Dec 2017 02:51:08 +0000 Message-ID: References: <1512614710-9956-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1512614710-9956-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 02:46:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong You'd better add more background for the change when you check in. Thanks, Eric -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Thursday, December 7, 2017 10:45 AM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX = in nasm code Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Eric Dong --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm b/UefiCpuPkg/PiSmm= CpuDxeSmm/X64/SmiEntry.nasm index c3c094f..dc56dc7 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm @@ -1,5 +1,5 @@ ;-------------------------------------------------------------------------= ----- ; -; Copyright (c) 2016, Intel Corporation. All rights reserved.
+; Copyright (c) 2016 - 2017, Intel Corporation. All rights=20 +reserved.
; This program and the accompanying materials ; are licensed and made ava= ilable under the terms and conditions of the BSD License ; which accompani= es this distribution. The full text of the license may be found at @@ -184= ,15 +184,15 @@ _SmiHandler: add rsp, -0x20 =20 mov rcx, rbx - mov rax, CpuSmmDebugEntry + mov rax, ASM_PFX(CpuSmmDebugEntry) call rax =20 mov rcx, rbx - mov rax, SmiRendezvous ; rax <- absolute addr of SmiRedez= vous + mov rax, ASM_PFX(SmiRendezvous) ; rax <- absolute addr of SmiRede= zvous call rax =20 mov rcx, rbx - mov rax, CpuSmmDebugExit + mov rax, ASM_PFX(CpuSmmDebugExit) call rax =20 add rsp, 0x20 @@ -220,5 +220,5 @@ _SmiHandler: .1: rsm =20 -gcSmiHandlerSize DW $ - _SmiEntryPoint +ASM_PFX(gcSmiHandlerSize) DW $ - _SmiEntryPoint =20 -- 2.8.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel