From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 249812218E923 for ; Wed, 6 Dec 2017 18:49:12 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 18:53:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="13815540" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 06 Dec 2017 18:53:44 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:53:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:53:43 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 10:53:40 +0800 From: "Dong, Eric" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Shao, Ming" Thread-Topic: [PATCH] UefiCpuPkg/MtrrLib: Correct debug message Thread-Index: AQHTbwXnYyUBZzi7YEuZk90H8OgRwaM3Lwqw Date: Thu, 7 Dec 2017 02:53:39 +0000 Message-ID: References: <20171207024839.21288-1-ruiyu.ni@intel.com> In-Reply-To: <20171207024839.21288-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Correct debug message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 02:49:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Ni, Ruiyu=20 Sent: Thursday, December 7, 2017 10:49 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Shao, Ming Subject: [PATCH] UefiCpuPkg/MtrrLib: Correct debug message When printing the ascii format of memory attribute in debug message, %s was= used, but %a should be used. The patch additionally changes %x to %r for EFI_STATUS. The whole patch doesn't impact functionality of the MtrrLib. Just debug message fix. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Eric Dong Cc: Ming Shao --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/Mtrr= Lib/MtrrLib.c index 9c66f93ac2..619b500c1d 100644 --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c @@ -2489,7 +2489,7 @@ MtrrSetMemoryAttributeInMtrrSettings ( Range.Type =3D Attribute; ScratchSize =3D sizeof (Scratch); Status =3D MtrrSetMemoryAttributesInMtrrSettings (MtrrSetting, Scratch, = &ScratchSize, &Range, 1); - DEBUG ((DEBUG_CACHE, "MtrrSetMemoryAttribute(MtrrSettings =3D %p) %s: [%= 016lx, %016lx) - %x\n", + DEBUG ((DEBUG_CACHE, "MtrrSetMemoryAttribute(MtrrSettings =3D %p) %a:=20 + [%016lx, %016lx) - %r\n", MtrrSetting, mMtrrMemoryCacheTypeShortName[Attribute], BaseAddress, BaseAddre= ss + Length, Status)); =20 -- 2.15.0.gvfs.1.preview.4