From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: Void lookup limit of 2 exceeded) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7B198222DDBF3 for ; Sun, 14 Jan 2018 18:48:59 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2018 18:54:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,361,1511856000"; d="scan'208";a="10010294" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 14 Jan 2018 18:54:16 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Jan 2018 18:54:16 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Mon, 15 Jan 2018 10:53:13 +0800 From: "Dong, Eric" To: "Song, BinX" , "edk2-devel@lists.01.org" CC: "lersek@redhat.com" Thread-Topic: [PATCH] UefiCpuPkg: Enhance feature dependency check Thread-Index: AdOLS7RCQrLnJIonRJSv+5UKYHzMLACYDzlA Date: Mon, 15 Jan 2018 02:53:12 +0000 Message-ID: References: <559D2DF22BC9A3468B4FA1AA547F0EF1025D3D1B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1025D3D1B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg: Enhance feature dependency check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 02:48:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Song, BinX=20 Sent: Friday, January 12, 2018 10:19 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; lersek@redhat.com Subject: [PATCH] UefiCpuPkg: Enhance feature dependency check Enhance MCA feature dependency check base on SDM pseudocode example 15-1. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song --- UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiC= puPkg/Library/CpuCommonFeaturesLib/MachineCheck.c index b012c69..58dc45a 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c @@ -105,6 +105,9 @@ McaSupport ( IN VOID *ConfigData OPTIONAL ) { + if (!MceSupport (ProcessorNumber, CpuInfo, ConfigData)) { + return FALSE; + } return (CpuInfo->CpuIdVersionInfoEdx.Bits.MCA =3D=3D 1); } =20 -- 2.10.2.windows.1