From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49C362063E2E8 for ; Wed, 2 May 2018 19:55:08 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2018 19:55:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,356,1520924400"; d="scan'208";a="52766388" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 02 May 2018 19:55:07 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 May 2018 19:55:06 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 May 2018 19:55:06 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Thu, 3 May 2018 10:55:05 +0800 From: "Dong, Eric" To: "Palmer, Thomas" , "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Wang, Nickle (HPS SW)" , "Gao, Liming" , "Zeng, Star" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function Thread-Index: AQHT11RR+m0PhYCHJ0Kc4YQfBWoImaQIvz8AgACNRYCAFBhkYA== Date: Thu, 3 May 2018 02:55:04 +0000 Message-ID: References: <1524083495-31936-1-git-send-email-thomas.palmer@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB3BACB257@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 02:55:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Thomas, Thanks for your patches. We just finished internal verification of them. Reviewed-by: Eric Dong and pushed them. Thanks, Eric -----Original Message----- From: Palmer, Thomas [mailto:thomas.palmer@hpe.com]=20 Sent: Saturday, April 21, 2018 12:00 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Wang, Nickle (HPS SW) ; Gao, Liming ; Dong, Eric ; Zeng, Star ; Zhang, Chao B Subject: RE: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLi= b: Update RouteConfig function I have no opinion / please the 5th. I defer to the experts. Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to mak= e it shorter" - Blaise Pascal -----Original Message----- From: Bi, Dandan [mailto:dandan.bi@intel.com]=20 Sent: Friday, April 20, 2018 2:34 AM To: Palmer, Thomas ; edk2-devel@lists.01.org Cc: Wang, Nickle (HPS SW) ; Gao, Liming ; Dong, Eric ; Zeng, Star ; Zhang, Chao B Subject: RE: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLi= b: Update RouteConfig function Thanks for the updating. These changes make sense. Reviewed-by: Dandan Bi for this patch series. But the Spec seems not to be clear enough. When looking into details about the "progress" parameter in EFI HII Configu= ration Routing Protocol and EFI_HII_CONFIG_ACCESS_PROTOCOL. Description of "progress" parameter in ExtractConfig() in UEFI 2.7 Spec: Progress On return, points to a character in the Request string. Points to the strin= g's null terminator if request was successful. Points to the most recent '&= ' before the first failing name / value pair (or the beginning of the strin= g if the failure is in the first name / value pair) if the request was not = successful EFI_NOT_FOUND A configuration element matching the routing data is not found. Progress se= t to the first character in the routing header. Description of "progress" parameter in RouteConfig () in UEFI 2.7 Spec: Progress a pointer to a string filled in with the offset of the most recent '&' befo= re the first failing name / value pair (or the beginning of the string if t= he failure is in the first name / value pair) or the terminating NULL if al= l was successful. EFI_NOT_FOUND Target for the specified routing data was not found. Compared with ExtractConfig(), the description of "Progress" parameter in R= outeConfig() is not very clear.=20 We think an ECR is nice to have to clarify them. What do you think? Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thom= as Palmer Sent: Thursday, April 19, 2018 4:32 AM To: edk2-devel@lists.01.org Cc: nickle.wang@hpe.com; Gao, Liming Subject: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: U= pdate RouteConfig function According to UEFI spec, the RouteConfig protocol function should populate t= he Progress pointer with an address inside Configuration. This patch ensur= es that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 3= +++ 1 file changed, 3 insertions(+) diff --git a/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBoo= tMaintUi.c b/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBoo= tMaintUi.c index a4828b7130c7..3092184ab760 100644 --- a/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMaintU= i.c +++ b/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMai +++ ntUi.c @@ -2,6 +2,7 @@ Legacy Boot Maintainence UI implementation. =20 Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
+(C) Copyright 2018 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -563,6 +56= 4,8 @@ LegacyBootOptionRouteConfig ( return EFI_INVALID_PARAMETER; } =20 + *Progress =3D Configuration; + // // Check routing data in . // Note: there is no name for Name/Value storage, only GUID will be chec= ked -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel