From: "Dong, Eric" <eric.dong@intel.com>
To: "Marvin Häuser" <Marvin.Haeuser@outlook.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup().
Date: Mon, 7 May 2018 08:13:46 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224AB8A3EA@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR0801MB1790A4DF753D0E295E92FFA580850@VI1PR0801MB1790.eurprd08.prod.outlook.com>
Hi Marvin,
Sorry I missed this change. I will follow up to check in the changes.
Thanks,
Eric
-----Original Message-----
From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
Sent: Saturday, May 5, 2018 9:18 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: FW: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup().
Hey Eric and Laszlo,
If I am not mistaken, this patch has neither been reviewed by Eric, nor was it pushed.
Just forwarding it in case it was forgotten about.
Thank you very much!
Best regards,
Marvin.
> -----Ursprüngliche Nachricht-----
> Von: Laszlo Ersek <lersek@redhat.com>
> Gesendet: Dienstag, 27. Februar 2018 18:41
> An: Marvin Häuser <Marvin.Haeuser@outlook.com>; edk2-
> devel@lists.01.org
> Cc: eric.dong@intel.com
> Betreff: Re: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to
> SecStartup().
>
> On 02/27/18 17:50, Marvin Häuser wrote:
> > The function SecStartup() is not supposed to return. Hence, add the
> > NORETURN decorator.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> > ---
> > UefiCpuPkg/SecCore/SecMain.c | 6 ++++++
> UefiCpuPkg/SecCore/SecMain.h
> > | 1 +
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/UefiCpuPkg/SecCore/SecMain.c
> > b/UefiCpuPkg/SecCore/SecMain.c index c241d3704af7..6f9db0584ce1
> 100644
> > --- a/UefiCpuPkg/SecCore/SecMain.c
> > +++ b/UefiCpuPkg/SecCore/SecMain.c
> > @@ -113,6 +113,7 @@ SecPerformancePpiCallBack (
> > @param BootFirmwareVolume Base address of the Boot Firmware
> Volume.
> > **/
> > VOID
> > +NORETURN
> > EFIAPI
> > SecStartup (
> > IN UINT32 SizeOfRam,
> > @@ -201,6 +202,11 @@ SecStartup (
> > // Initialize Debug Agent to support source level debug in
> > SEC/PEI phases
> before memory ready.
> > //
> > InitializeDebugAgent (DEBUG_AGENT_INIT_PREMEM_SEC,
> &SecCoreData,
> > SecStartupPhase2);
> > +
> > + //
> > + // Should not come here.
> > + //
> > + UNREACHABLE ();
> > }
> >
> > /**
> > diff --git a/UefiCpuPkg/SecCore/SecMain.h
> > b/UefiCpuPkg/SecCore/SecMain.h index 46c7d41c6e3e..42a5718cfdd5
> 100644
> > --- a/UefiCpuPkg/SecCore/SecMain.h
> > +++ b/UefiCpuPkg/SecCore/SecMain.h
> > @@ -76,6 +76,7 @@ SecTemporaryRamDone (
> > @param BootFirmwareVolume Base address of the Boot Firmware
> Volume.
> > **/
> > VOID
> > +NORETURN
> > EFIAPI
> > SecStartup (
> > IN UINT32 SizeOfRam,
> >
>
> I checked the NORETURN and UNREACHABLE() macros in
> "MdePkg/Include/Base.h", and also the InitializeDebugAgent() API. I
> think the patch is correct.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks
> Laszlo
next prev parent reply other threads:[~2018-05-07 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 13:17 FW: [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup() Marvin Häuser
2018-05-07 8:13 ` Dong, Eric [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-27 16:50 Marvin Häuser
2018-02-27 17:40 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66224AB8A3EA@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox