From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7F04207E36BE for ; Mon, 7 May 2018 22:52:12 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 22:52:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,377,1520924400"; d="scan'208";a="56819879" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 07 May 2018 22:52:11 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 22:52:11 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 7 May 2018 22:52:11 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Tue, 8 May 2018 13:50:22 +0800 From: "Dong, Eric" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Wu, Hao A" Thread-Topic: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver. Thread-Index: AQHT4o1PJAU3AUmD3kyGNs+ZI5RhTqQk00UAgACIBLA= Date: Tue, 8 May 2018 05:50:21 +0000 Message-ID: References: <20180503031702.11296-1-eric.dong@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AB94654@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AB94654@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/3] Enable Pyrite 2.0 for opal driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 05:52:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiewen, I do the basic functionality test base on the opal UI. Also I request the Q= A to do the full regression test and no issue found. Also will include unit test info in later patches. Thanks for your comment= s. Thanks, Eric -----Original Message----- From: Yao, Jiewen=20 Sent: Tuesday, May 8, 2018 1:42 PM To: Dong, Eric ; edk2-devel@lists.01.org; Wu, Hao A Subject: RE: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver. Hi Eric Would you please add more detail on what unit test has been done for this p= atch? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Eric Dong > Sent: Wednesday, May 2, 2018 8:17 PM > To: edk2-devel@lists.01.org; Wu, Hao A > Subject: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver. >=20 > Eanble the pyrite 2.0 devices for opal driver. >=20 > Eric Dong (3): > MdePkg: Add Feature definitions add in pyrite 2.0 spec. > SecurityPkg/TcgStorageOpalLib: Add supports for pyrite 2.0 spec. > SecurityPkg/OpalPassword: Add support for pyrite 2.0 devices. >=20 > MdePkg/Include/IndustryStandard/TcgStorageCore.h | 2 + > MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 54 +++ > SecurityPkg/Include/Library/TcgStorageOpalLib.h | 41 ++ > .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 426 > ++++++++++++++++++--- > .../TcgStorageOpalLib/TcgStorageOpalLib.inf | 1 + > .../TcgStorageOpalLib/TcgStorageOpalLibInternal.h | 98 +++++ =20 > .../Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 214 ++++++++++- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 60 ++- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.h | 9 + > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 84 ++++ > .../Tcg/Opal/OpalPassword/OpalPasswordPei.c | 1 + > 11 files changed, 934 insertions(+), 56 deletions(-) create mode=20 > 100644=20 > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLibInternal.h >=20 > -- > 2.15.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel