From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54B3F203B8CE3 for ; Mon, 14 May 2018 23:02:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 23:02:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,402,1520924400"; d="scan'208";a="55264729" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 14 May 2018 23:02:27 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 May 2018 23:02:27 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0319.002; Tue, 15 May 2018 14:02:25 +0800 From: "Dong, Eric" To: "Gao, Liming" , Laszlo Ersek CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files Thread-Index: AQHT6sc5abnpjWdG4EGQiMw8SqLdZKQtd/GAgAE0C4CAAaMIsA== Date: Tue, 15 May 2018 06:02:25 +0000 Message-ID: References: <1526221902-9060-1-git-send-email-liming.gao@intel.com> <1526221902-9060-7-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E228F68@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E228F68@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 06:02:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao,= Liming Sent: Monday, May 14, 2018 9:03 PM To: Laszlo Ersek Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files Laszlo: 1) Yes. Bug 881 is for nasm update. I will refer it in the commit log. 2) Agree 3) I will add notes to describe .asm in Vtf0 directory are used as nasm so= urce. I don't clean up them. Thanks Liming > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Monday, May 14, 2018 2:40 AM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files >=20 > On 05/13/18 16:31, Liming Gao wrote: > > NASM has replaced ASM and S files. > > Rmove ASM from all modules. > > Remove S files from the drivers only. > > After NASM is updated, S files can be removed from Library. >=20 > The patch looks good to me. I suggest a few commit message updates: >=20 > (1) If I remember correctly, we have a TianoCore BZ for this (also for=20 > the NASM update). Can you please reference those here? >=20 > (2) There's a typo in "Rmove". >=20 > (3) Technically, a number of *.asm files remain under UefiCpuPkg,=20 > namely under "ResetVector/Vtf0". None of those are built stand-alone=20 > -- they are all included by "Vtf0.nasmb", and "Vtf0.inf" only=20 > references "Vtf0.nasmb". So technically speaking these *.asm files are=20 > *.nasm[b] files. I suggest we add a note about this fact, or else file=20 > a TianoCore BZ about renaming the Vtf0 ASM files. >=20 > With the commit message updates: >=20 > Reviewed-by: Laszlo Ersek >=20 > Thanks! > Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel