From: "Dong, Eric" <eric.dong@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Xu, WeiX" <weix.xu@intel.com>
Subject: Re: [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later
Date: Fri, 22 Jun 2018 01:59:27 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224AC1B5C5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1529582777-12420-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, June 21, 2018 8:06 PM
To: edk2-devel@lists.01.org
Cc: Xu, WeiX <weix.xu@intel.com>
Subject: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later
Constructor is too early that ConnectAll() may not do. Move refresh boot option in form open.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Xu WeiX <weix.xu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c
index 98e14c7..fdcb56a 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c
@@ -1111,6 +1111,7 @@ BootMaintCallback (
// 2. Re-scan the BootOption menus (including the legacy boot option).
//
CustomizeMenus ();
+ EfiBootManagerRefreshAllBootOption ();
BOpt_GetBootOptions (Private);
mFirstEnterBMMForm = TRUE;
}
@@ -1690,8 +1691,6 @@ BootMaintenanceManagerUiLibConstructor (
Status = gBS->LocateProtocol (&gEfiFormBrowser2ProtocolGuid, NULL, (VOID **) &mBmmCallbackInfo->FormBrowser2);
ASSERT_EFI_ERROR (Status);
- EfiBootManagerRefreshAllBootOption ();
-
//
// Create LoadOption in BmmCallbackInfo for Driver Callback
//
--
2.8.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-06-22 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 12:06 [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later Liming Gao
2018-06-22 1:59 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66224AC1B5C5@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox