From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48025210DA79C for ; Thu, 21 Jun 2018 18:59:31 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 18:59:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,255,1526367600"; d="scan'208";a="61237370" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2018 18:59:29 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:59:29 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:59:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Fri, 22 Jun 2018 09:59:27 +0800 From: "Dong, Eric" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Xu, WeiX" Thread-Topic: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later Thread-Index: AQHUCVhZz7p2PTKumUKsmvmsnH9QuqRrcDZg Date: Fri, 22 Jun 2018 01:59:27 +0000 Message-ID: References: <1529582777-12420-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1529582777-12420-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 01:59:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Thursday, June 21, 2018 8:06 PM To: edk2-devel@lists.01.org Cc: Xu, WeiX Subject: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refr= esh boot option later Constructor is too early that ConnectAll() may not do. Move refresh boot op= tion in form open.=20 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Xu WeiX Reviewed-by: Liming Gao --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenan= ce.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c index 98e14c7..fdcb56a 100644 --- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c +++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c @@ -1111,6 +1111,7 @@ BootMaintCallback ( // 2. Re-scan the BootOption menus (including the legacy boot opti= on). // CustomizeMenus (); + EfiBootManagerRefreshAllBootOption (); BOpt_GetBootOptions (Private); mFirstEnterBMMForm =3D TRUE; } @@ -1690,8 +1691,6 @@ BootMaintenanceManagerUiLibConstructor ( Status =3D gBS->LocateProtocol (&gEfiFormBrowser2ProtocolGuid, NULL, (VO= ID **) &mBmmCallbackInfo->FormBrowser2); ASSERT_EFI_ERROR (Status); =20 - EfiBootManagerRefreshAllBootOption (); - // // Create LoadOption in BmmCallbackInfo for Driver Callback // -- 2.8.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel