From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9F5EB202E541F for ; Thu, 28 Jun 2018 18:49:02 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2018 18:49:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="53765850" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 28 Jun 2018 18:48:16 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Jun 2018 18:48:15 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Jun 2018 18:48:15 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0319.002; Fri, 29 Jun 2018 09:48:13 +0800 From: "Dong, Eric" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter. Thread-Index: AQHUDtNNfcqsFq6VGk+JtFEX1YclzqR1R/QAgAErnmA= Date: Fri, 29 Jun 2018 01:48:13 +0000 Message-ID: References: <20180628112920.5296-1-eric.dong@intel.com> <20180628112920.5296-2-eric.dong@intel.com> <54d09d35-86c5-1f93-08ea-c01fff5cc8dd@redhat.com> In-Reply-To: <54d09d35-86c5-1f93-08ea-c01fff5cc8dd@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 2/2] UefiCpuPkg/MpInitLib: Remove redundant parameter. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 01:49:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IExhc3ps byBFcnNlayBbbWFpbHRvOmxlcnNla0ByZWRoYXQuY29tXQ0KPiBTZW50OiBUaHVyc2RheSwgSnVu ZSAyOCwgMjAxOCAxMTozNyBQTQ0KPiBUbzogRG9uZywgRXJpYyA8ZXJpYy5kb25nQGludGVsLmNv bT47IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnDQo+IENjOiBOaSwgUnVpeXUgPHJ1aXl1Lm5pQGlu dGVsLmNvbT4NCj4gU3ViamVjdDogUmU6IFtlZGsyXSBbUGF0Y2ggMi8yXSBVZWZpQ3B1UGtnL01w SW5pdExpYjogUmVtb3ZlIHJlZHVuZGFudA0KPiBwYXJhbWV0ZXIuDQo+IA0KPiBIaSBFcmljLA0K PiANCj4gT24gMDYvMjgvMTggMTM6MjksIEVyaWMgRG9uZyB3cm90ZToNCj4gPiBQYXJhbWV0ZXIg U3RhcnRDb3VudCBkdXBsaWNhdGVzIHdpdGggUnVubmluZ0NvdW50LiBBZnRlciB0aGlzIGNoYW5n ZSwNCj4gPiBSdW5uaW5nQ291bnQgbWVhbnMgdGhlIHJ1bm5pbmcgQVAgY291bnQuDQo+ID4NCj4g PiBEb25lIFRlc3RzOg0KPiA+IDEuUEkgU0NUIFRlc3QNCj4gPiAyLkJvb3QgT1MgLyBTMw0KPiA+ DQo+ID4gQ2M6IFJ1aXl1IE5pIDxydWl5dS5uaUBpbnRlbC5jb20+DQo+ID4gQ2M6IEplZmYgRmFu IDx2YW5qZWZmXzkxOUBob3RtYWlsLmNvbT4NCj4gPiBDYzogTGFzemxvIEVyc2VrIDxsZXJzZWtA cmVkaGF0LmNvbT4NCj4gPiBDb250cmlidXRlZC11bmRlcjogVGlhbm9Db3JlIENvbnRyaWJ1dGlv biBBZ3JlZW1lbnQgMS4xDQo+ID4gU2lnbmVkLW9mZi1ieTogRXJpYyBEb25nIDxlcmljLmRvbmdA aW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+ICBVZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL01w TGliLmMgfCAxMSArKysrKy0tLS0tLQ0KPiA+IFVlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIv TXBMaWIuaCB8ICAxIC0NCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvVWVmaUNwdVBrZy9MaWJyYXJ5L01w SW5pdExpYi9NcExpYi5jDQo+ID4gYi9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL01wTGli LmMNCj4gPiBpbmRleCAzOTQ1NzcxNzY0Li41MmM5Njc5MDk5IDEwMDY0NA0KPiA+IC0tLSBhL1Vl ZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIuYw0KPiA+ICsrKyBiL1VlZmlDcHVQa2cv TGlicmFyeS9NcEluaXRMaWIvTXBMaWIuYw0KPiA+IEBAIC0xNDAwLDcgKzE0MDAsNyBAQCBDaGVj a0FsbEFQcyAoDQo+ID4gICAgICAvLyB2YWx1ZSBvZiBzdGF0ZSBhZnRlciBzZXR0aW5nIHRoZSBp dCB0byBDcHVTdGF0ZUZpbmlzaGVkLCBzbyBCU1AgY2FuIHNhZmVseQ0KPiBtYWtlIHVzZSBvZiBp dHMgdmFsdWUuDQo+ID4gICAgICAvLw0KPiA+ICAgICAgaWYgKEdldEFwU3RhdGUoQ3B1RGF0YSkg IT0gQ3B1U3RhdGVCdXN5KSB7DQo+ID4gLSAgICAgIENwdU1wRGF0YS0+UnVubmluZ0NvdW50ICsr Ow0KPiA+ICsgICAgICBDcHVNcERhdGEtPlJ1bm5pbmdDb3VudCAtLTsNCj4gPiAgICAgICAgQ3B1 TXBEYXRhLT5DcHVEYXRhW1Byb2Nlc3Nvck51bWJlcl0uV2FpdGluZyA9IEZBTFNFOw0KPiA+DQo+ ID4gICAgICAgIC8vDQo+ID4gQEAgLTE0MjUsNyArMTQyNSw3IEBAIENoZWNrQWxsQVBzICgNCj4g PiAgICAvLw0KPiA+ICAgIC8vIElmIGFsbCBBUHMgZmluaXNoLCByZXR1cm4gRUZJX1NVQ0NFU1Mu DQo+ID4gICAgLy8NCj4gPiAtICBpZiAoQ3B1TXBEYXRhLT5SdW5uaW5nQ291bnQgPT0gQ3B1TXBE YXRhLT5TdGFydENvdW50KSB7DQo+ID4gKyAgaWYgKENwdU1wRGF0YS0+UnVubmluZ0NvdW50ID09 IDApIHsNCj4gPiAgICAgIHJldHVybiBFRklfU1VDQ0VTUzsNCj4gPiAgICB9DQo+ID4NCj4gPiBA QCAtMTQ0Miw3ICsxNDQyLDcgQEAgQ2hlY2tBbGxBUHMgKA0KPiA+ICAgICAgLy8NCj4gPiAgICAg IGlmIChDcHVNcERhdGEtPkZhaWxlZENwdUxpc3QgIT0gTlVMTCkgew0KPiA+ICAgICAgICAqQ3B1 TXBEYXRhLT5GYWlsZWRDcHVMaXN0ID0NCj4gPiAtICAgICAgICAgQWxsb2NhdGVQb29sICgoQ3B1 TXBEYXRhLT5TdGFydENvdW50IC0gQ3B1TXBEYXRhLT5GaW5pc2hlZENvdW50DQo+ICsgMSkgKiBz aXplb2YgKFVJTlROKSk7DQo+ID4gKyAgICAgICAgIEFsbG9jYXRlUG9vbCAoKENwdU1wRGF0YS0+ UnVubmluZ0NvdW50ICsgMSkgKiBzaXplb2YNCj4gPiArIChVSU5UTikpOw0KPiA+ICAgICAgICBB U1NFUlQgKCpDcHVNcERhdGEtPkZhaWxlZENwdUxpc3QgIT0gTlVMTCk7DQo+ID4gICAgICB9DQo+ ID4gICAgICBMaXN0SW5kZXggPSAwOw0KPiA+IEBAIC0yMTIxLDcgKzIxMjEsNyBAQCBTdGFydHVw QWxsQVBzV29ya2VyICgNCj4gPiAgICAgIHJldHVybiBFRklfTk9UX1NUQVJURUQ7DQo+ID4gICAg fQ0KPiA+DQo+ID4gLSAgQ3B1TXBEYXRhLT5TdGFydENvdW50ID0gMDsNCj4gPiArICBDcHVNcERh dGEtPlJ1bm5pbmdDb3VudCA9IDA7DQo+ID4gICAgZm9yIChQcm9jZXNzb3JOdW1iZXIgPSAwOyBQ cm9jZXNzb3JOdW1iZXIgPCBQcm9jZXNzb3JDb3VudDsNCj4gUHJvY2Vzc29yTnVtYmVyKyspIHsN Cj4gPiAgICAgIENwdURhdGEgPSAmQ3B1TXBEYXRhLT5DcHVEYXRhW1Byb2Nlc3Nvck51bWJlcl07 DQo+ID4gICAgICBDcHVEYXRhLT5XYWl0aW5nID0gRkFMU0U7DQo+ID4gQEAgLTIxMzEsNyArMjEz MSw3IEBAIFN0YXJ0dXBBbGxBUHNXb3JrZXIgKA0KPiA+ICAgICAgICAgIC8vIE1hcmsgdGhpcyBw cm9jZXNzb3IgYXMgcmVzcG9uc2libGUgZm9yIGN1cnJlbnQgY2FsbGluZy4NCj4gPiAgICAgICAg ICAvLw0KPiA+ICAgICAgICAgIENwdURhdGEtPldhaXRpbmcgPSBUUlVFOw0KPiA+IC0gICAgICAg IENwdU1wRGF0YS0+U3RhcnRDb3VudCsrOw0KPiA+ICsgICAgICAgIENwdU1wRGF0YS0+UnVubmlu Z0NvdW50Kys7DQo+ID4gICAgICAgIH0NCj4gPiAgICAgIH0NCj4gPiAgICB9DQo+ID4gQEAgLTIx NDAsNyArMjE0MCw2IEBAIFN0YXJ0dXBBbGxBUHNXb3JrZXIgKA0KPiA+ICAgIENwdU1wRGF0YS0+ UHJvY0FyZ3VtZW50cyA9IFByb2NlZHVyZUFyZ3VtZW50Ow0KPiA+ICAgIENwdU1wRGF0YS0+U2lu Z2xlVGhyZWFkICA9IFNpbmdsZVRocmVhZDsNCj4gPiAgICBDcHVNcERhdGEtPkZpbmlzaGVkQ291 bnQgPSAwOw0KPiA+IC0gIENwdU1wRGF0YS0+UnVubmluZ0NvdW50ICA9IDA7DQo+ID4gICAgQ3B1 TXBEYXRhLT5GYWlsZWRDcHVMaXN0ID0gRmFpbGVkQ3B1TGlzdDsNCj4gPiAgICBDcHVNcERhdGEt PkV4cGVjdGVkVGltZSAgPSBDYWxjdWxhdGVUaW1lb3V0ICgNCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFRpbWVvdXRJbk1pY3Jvc2Vjb25kcywgZGlmZiAtLWdpdA0KPiA+IGEv VWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExpYi9NcExpYi5oDQo+ID4gYi9VZWZpQ3B1UGtnL0xp YnJhcnkvTXBJbml0TGliL01wTGliLmgNCj4gPiBpbmRleCA5MGMwOWZiOGZiLi40MTY2NzM0Njg3 IDEwMDY0NA0KPiA+IC0tLSBhL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIuaA0K PiA+ICsrKyBiL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIuaA0KPiA+IEBAIC0y MTAsNyArMjEwLDYgQEAgc3RydWN0IF9DUFVfTVBfREFUQSB7DQo+ID4gICAgVUlOVE4gICAgICAg ICAgICAgICAgICAgICAgICAgIEJhY2t1cEJ1ZmZlcjsNCj4gPiAgICBVSU5UTiAgICAgICAgICAg ICAgICAgICAgICAgICAgQmFja3VwQnVmZmVyU2l6ZTsNCj4gPg0KPiA+IC0gIHZvbGF0aWxlIFVJ TlQzMiAgICAgICAgICAgICAgICBTdGFydENvdW50Ow0KPiA+ICAgIHZvbGF0aWxlIFVJTlQzMiAg ICAgICAgICAgICAgICBGaW5pc2hlZENvdW50Ow0KPiA+ICAgIHZvbGF0aWxlIFVJTlQzMiAgICAg ICAgICAgICAgICBSdW5uaW5nQ291bnQ7DQo+ID4gICAgQk9PTEVBTiAgICAgICAgICAgICAgICAg ICAgICAgIFNpbmdsZVRocmVhZDsNCj4gPg0KPiANCj4gSSdtIGN1cnJlbnRseSBtaXNzaW5nIGEg Z29vZCB1bmRlcnN0YW5kaW5nIG9mIGhvdyB0aGVzZSBjb3VudGVycyBhcmUNCj4gbW9kaWZpZWQu IFRoZXkgYXJlIGFsbCBxdWFsaWZpZWQgInZvbGF0aWxlIiwgd2hpY2ggc3VnZ2VzdHMgdGhleSBh cmUgYWNjZXNzZWQNCj4gZnJvbSBtdWx0aXBsZSBwcm9jZXNzb3JzLiBJcyB0aGF0IGNvcnJlY3Q/ DQoNCk5vLCBhY3R1YWxseSBvbmx5IEZpbmlzaGVkQ291bnQgaXMgY2hhbmdlZCBieSBCU1AgYW5k IEFwcywgb3RoZXIgdHdvIGFyZSBvbmx5IGNoYW5nZWQgYnkgQlNQLiBTdGFydENvdW50IHN0YW5k cyBmb3IgdGhlIEFQIGNvdW50IHdoaWNoIHdpbGwgZG8gdGhlIHRhc2suIEl0IGlzIGNhbGN1bGF0 ZWQgYnkgQlNQIGJlZm9yZSBBcHMgc3RhcnQgdGhlIHRhc2suIFJ1bm5pbmdDb3VudCBzdGFuZHMg Zm9yIHRoZSBBUCBjb3VudCB3aGljaCBoYXZlIGZpbmlzaGVkIHRoZSB0YXNrLiBJdCBhbHNvIGRl dGVjdGVkIGFuZCBjaGFuZ2VkIGJ5IEJTUC4NCg0KPiANCj4gSGVyZSdzIG15IGNvbmNlcm46IGFz c3VtZSB3ZSBoYXZlIDMgQVBzLCBhbmQgd2UgbWFpbnRhaW4gaG93IG1hbnkgb2YNCj4gdGhlbSBh cmUgcnVubmluZyBjb25jdXJyZW50bHkgYXQgYW55IGdpdmVuIHBvaW50LiBBc3N1bWUgd2Ugc3Rh cnQgdGhlbSB1cA0KPiBhbGwgYXQgb25jZSwgYW5kIHRoZW4gbGF0ZXIgdGhleSBhbGwgZmluaXNo LiBUaGUgbW9kaWZpZWQgIlJ1bm5pbmdDb3VudCIgdmFsdWUNCj4gbWlnaHQgYWR2YW5jZSBsaWtl IHRoaXM6DQo+IA0KPiAgIEFQIzEgIEFQIzIgIEFQIzMgIFJ1bm5pbmdDb3VudCAgY29tbWVudA0K PiAgIC0tLS0gIC0tLS0gIC0tLS0gIC0tLS0tLS0tLS0tLSAgLS0tLS0tLS0tLS0tLS0tLQ0KPiAg ICAgICAgICAgICAgICAgICAgIDAgICAgICAgICAgICAgbm8gQVAgcnVubmluZyB5ZXQNCj4gICAg diAgICAgICAgICAgICAgICAxICAgICAgICAgICAgIEFQIzEgc3RhcnRzDQo+ICAgIHwgICAgIHYg ICAgICAgICAgMiAgICAgICAgICAgICBBUCMyIHN0YXJ0cw0KPiAgICB8ICAgICB8ICAgICB2ICAg IDMgICAgICAgICAgICAgQVAjMyBzdGFydHMNCj4gICAgfCAgICAgfCAgICAgfCAgICAzICAgICAg ICAgICAgIGFsbCBBUHMgd29ya2luZw0KPiAgICB8ICAgICBeICAgICB8ICAgIDIgICAgICAgICAg ICAgQVAjMiBmaW5pc2hlcw0KPiAgICB8ICAgICAgICAgICBeICAgIDEgICAgICAgICAgICAgQVAj MyBmaW5pc2hlcw0KPiAgICBeICAgICAgICAgICAgICAgIDAgICAgICAgICAgICAgQVAjMSBmaW5p c2hlcywgZG9uZQ0KPiANCj4gSG93ZXZlciwgdGhlIGZvbGxvd2luZyBjb3VsZCBoYXBwZW4gYXMg d2VsbDoNCj4gDQo+ICAgQVAjMSAgQVAjMiAgQVAjMyAgUnVubmluZ0NvdW50ICBjb21tZW50DQo+ ICAgLS0tLSAgLS0tLSAgLS0tLSAgLS0tLS0tLS0tLS0tICAtLS0tLS0tLS0tLS0tLS0tDQo+ICAg ICAgICAgICAgICAgICAgICAgMCAgICAgICAgICAgICBubyBBUCBydW5uaW5nIHlldA0KPiAgICB2 ICAgICAgICAgICAgICAgIDEgICAgICAgICAgICAgQVAjMSBzdGFydHMNCj4gICAgXiAgICAgICAg ICAgICAgICAwICAgICAgICAgICAgIEFQIzEgZmluaXNoZXMNCj4gICAgICAgICAgdiAgICAgICAg ICAxICAgICAgICAgICAgIEFQIzIgc3RhcnRzDQo+ICAgICAgICAgIHwgICAgIHYgICAgMiAgICAg ICAgICAgICBBUCMzIHN0YXJ0cw0KPiAgICAgICAgICB8ICAgICBeICAgIDEgICAgICAgICAgICAg QVAjMyBmaW5pc2hlcw0KPiAgICAgICAgICBeICAgICAgICAgIDAgICAgICAgICAgICAgQVAjMiBm aW5pc2hlcywgZG9uZQ0KPiANCj4gSW4gdGhlIHNlY29uZCBzY2hlZHVsaW5nLCB3ZSBnZXQgUnVu bmluZ0NvdW50PTAgd2hlbiBBUCMxIGZpbmlzaGVzLCBldmVuDQo+IHRob3VnaCBBUCMyIGFuZCBB UCMzIGFyZSBub3QgZG9uZSAodGhleSBoYXZlbid0IGV2ZW4gc3RhcnRlZCB5ZXQpLg0KPiANCj4g SXMgdGhpcyBhIHJlYWxpc3RpYyBjb25jZXJuLCBvciBpcyB0aGUgYWJvdmUgc2NlbmFyaW8gaW1w b3NzaWJsZT8NCg0KRm9yIHRoaXMgcGF0Y2gsIFJ1bm5pbmdDb3VudCBpcyBjYWxjdWxhdGVkIGJ5 IEJTUCBiZWZvcmUgaXQgc3RhcnQgdGhlIHRhc2sgZm9yIEFwcywgc28gaG93IHRoZSBBcHMgc3Rh cnQgdGhlIHRhc2sgd2lsbCBub3QgaW1wYWN0IHRoZSBsb2dpYy4gIFRoZSB1cGRhdGUgb2YgUnVu bmluZ0NvdW50IGFsc28gZG9uZSBieSBCU1AuDQoNCkkgd2lsbCB1cGRhdGUgdGhlIHBhdGNoIHRv IHJlbW92ZSB0aGUgdm9sYXRpbGUgZm9yIFJ1bm5pbmdDb3VudC4NCg0KPiANCj4gKEknZCBsaWtl IHRvIHRlc3QgdGhlIHNlcmllcyBhZnRlciB1bmRlcnN0YW5kaW5nIHRoaXMuKQ0KPiANCj4gQWN0 dWFsbHkuLi4gaWYgdGhlIHByb2JsZW0gc2NlbmFyaW8gaXMgcG9zc2libGUsIEkgdGhpbmsgaXQg Y291bGQgYWZmZWN0IHRoZSBjdXJyZW50DQo+IChwcmUtcGF0Y2gpIGNvZGUgYXMgd2VsbC4gSSBo b3BlIEknbSB3cm9uZyENCj4gDQo+IFRoYW5rcywNCj4gTGFzemxvDQo=