From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 77699210BFF63 for ; Mon, 23 Jul 2018 17:45:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 17:45:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,394,1526367600"; d="scan'208";a="58891138" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 23 Jul 2018 17:45:39 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Jul 2018 17:45:39 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Jul 2018 17:45:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 08:45:36 +0800 From: "Dong, Eric" To: =?iso-8859-1?Q?Marvin_H=E4user?= , "edk2-devel@lists.01.org" CC: "lersek@redhat.com" Thread-Topic: [PATCH] UefiCpuPkg/CpuMpPei: Correct BIST PPI logic. Thread-Index: AQHUIUCVO4ePb3RRRk+TNRSbXhvcmaSdjIhg Date: Tue, 24 Jul 2018 00:45:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/CpuMpPei: Correct BIST PPI logic. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 00:45:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong And pushed: SHA-1: 005c855dc6be0f61f76de0d7ec4a62ee737518d6 * UefiCpuPkg/CpuMpPei: Correct BIST PPI logic. Currently, the SecPlatformInformation2 PPI is installed when either there is none present or the present one doesn't lack data. Update the logic to only install the SecPlatformInformation2 PPI when it's not already installed so that an up-to-date PPI remains the only one and unchanged. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser Reviewed-by: Laszlo Ersek Reviewed-by: Eric Dong Thanks, Eric > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H=E4user > Sent: Sunday, July 22, 2018 6:17 AM > To: edk2-devel@lists.01.org > Cc: lersek@redhat.com; Dong, Eric > Subject: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: Correct BIST PPI logic. >=20 > Currently, the SecPlatformInformation2 PPI is installed when either there= is > none present or the present one doesn't lack data. > Update the logic to only install the SecPlatformInformation2 PPI when it'= s not > already installed so that an up-to-date PPI remains the only one and > unchanged. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > UefiCpuPkg/CpuMpPei/CpuBist.c | 22 +++++++++++--------- > 1 file changed, 12 insertions(+), 10 deletions(-) >=20 > diff --git a/UefiCpuPkg/CpuMpPei/CpuBist.c > b/UefiCpuPkg/CpuMpPei/CpuBist.c index 20728525e2d9..5312d9f01dc8 > 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuBist.c > +++ b/UefiCpuPkg/CpuMpPei/CpuBist.c > @@ -275,18 +275,20 @@ CollectBistDataFromPpi ( > (UINTN) BistInformationSize > ); >=20 > - if (SecPlatformInformation2 !=3D NULL && NumberOfData < > NumberOfProcessors) { > - // > - // Reinstall SecPlatformInformation2 PPI to include new BIST informa= tion > - // > - Status =3D PeiServicesReInstallPpi ( > - SecInformationDescriptor, > - &mPeiSecPlatformInformation2Ppi > - ); > - ASSERT_EFI_ERROR (Status); > + if (SecPlatformInformation2 !=3D NULL) { > + if (NumberOfData < NumberOfProcessors) { > + // > + // Reinstall SecPlatformInformation2 PPI to include new BIST infor= mation > + // > + Status =3D PeiServicesReInstallPpi ( > + SecInformationDescriptor, > + &mPeiSecPlatformInformation2Ppi > + ); > + ASSERT_EFI_ERROR (Status); > + } > } else { > // > - // Install SecPlatformInformation2 PPI to include new BIST informati= on > + // Install SecPlatformInformation2 PPI > // > Status =3D PeiServicesInstallPpi (&mPeiSecPlatformInformation2Ppi); > ASSERT_EFI_ERROR(Status); > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel