From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3974210C1ED8 for ; Wed, 25 Jul 2018 05:10:00 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 05:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,401,1526367600"; d="scan'208";a="59681992" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 25 Jul 2018 05:10:00 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 05:09:59 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 20:09:57 +0800 From: "Dong, Eric" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition. Thread-Index: AQHUI+xStrj09tik70iEZ1rB6htqLqSfTHkAgACJEfA= Date: Wed, 25 Jul 2018 12:09:56 +0000 Message-ID: References: <20180725075020.240-1-eric.dong@intel.com> <20180725075020.240-3-eric.dong@intel.com> <78bc8b2c-1579-5f6f-1d9c-eedc0899f6dc@redhat.com> In-Reply-To: <78bc8b2c-1579-5f6f-1d9c-eedc0899f6dc@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 12:10:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTGFz emxvIEVyc2VrIFttYWlsdG86bGVyc2VrQHJlZGhhdC5jb21dDQo+IFNlbnQ6IFdlZG5lc2RheSwg SnVseSAyNSwgMjAxOCA3OjQ3IFBNDQo+IFRvOiBEb25nLCBFcmljIDxlcmljLmRvbmdAaW50ZWwu Y29tPjsgZWRrMi1kZXZlbEBsaXN0cy4wMS5vcmcNCj4gQ2M6IE5pLCBSdWl5dSA8cnVpeXUubmlA aW50ZWwuY29tPg0KPiBTdWJqZWN0OiBSZTogW2VkazJdIFtQYXRjaCB2MyAyLzNdIFVlZmlDcHVQ a2cvTXBJbml0TGliOiBSZW1vdmUgU3RhcnRDb3VudA0KPiBhbmQgdm9sYXRpbGUgZGVmaW5pdGlv bi4NCj4gDQo+IEhpIEVyaWMsDQo+IA0KPiBPbiAwNy8yNS8xOCAwOTo1MCwgRXJpYyBEb25nIHdy b3RlOg0KPiA+IFRoZSBTdGFydENvdW50IGlzIGR1cGxpY2F0ZWQgd2l0aCBSdW5uaW5nQ291bnQs IHJlcGxhY2UgaXQgd2l0aA0KPiA+IFJ1bm5pbmdDb3VudC4gQWxzbyB0aGUgdm9sYXRpbGUgZm9y IFJ1bm5pbmdDb3VudCBpcyBub3QgbmVlZGVkLg0KPiANCj4gYWZ0ZXIgc3RhcmluZyBhdCB0aGlz IHBhdGNoIGZvciBhIGxvbmcgdGltZSwgSSB0aGluayBpdCBpcyBjb3JyZWN0Lg0KPiBIb3dldmVy LCBJIHN1Z2dlc3QgdGhhdCB3ZSBpbXByb3ZlIHRoZSBjb21taXQgbWVzc2FnZSwgYmVjYXVzZSB0 aGlzIHBhdGNoDQo+IGFjdHVhbGx5IGRvZXMgdGhyZWUgdGhpbmdzOg0KPiANCj4gKDEpIEl0IHJl bW92ZXMgInZvbGF0aWxlIiBmcm9tIFJ1bm5pbmdDb3VudC4NCj4gDQo+IFtUaGlzIGlzIE9LLCBi ZWNhdXNlIG9ubHkgdGhlIEJTUCBtb2RpZmllcyBpdC5dDQo+IA0KPiAoMikgW1RoaXMgaXMgdGhl IHRyaWNreSBwYXJ0Ll0NCj4gDQo+IFdoZW4gd2UgZGV0ZWN0IGEgdGltZW91dCBpbiBDaGVja0Fs bEFQcygpLCBhbmQgY29sbGVjdCB0aGUgbGlzdCBvZiBmYWlsZWQgQ1BVcywNCj4gdGhlIHNpemUg b2YgdGhlIGxpc3QgaXMgZGVyaXZlZCBmcm9tIHRoZSBmb2xsb3dpbmcgZGlmZmVyZW5jZSwgYmVm b3JlIHRoZSBwYXRjaDoNCj4gDQo+ICAgU3RhcnRDb3VudCAtIEZpbmlzaGVkQ291bnQNCj4gDQo+ IHdoZXJlICJTdGFydENvdW50IiBpcyBzZXQgYnkgdGhlIEJTUCBhdCBzdGFydHVwLCBhbmQgRmlu aXNoZWRDb3VudCBpcw0KPiBpbmNyZW1lbnRlZCBieSB0aGUgQVBzIHRoZW1zZWx2ZXMuDQo+IA0K DQpJIHRoaW5rIEZpbmlzaGVkQ291bnQgdXNlZCBoZXJlIGlzIGEgdHlwby4gV2hhdCB0aGUgbG9n aWMgZnJvbSB0aGUgY29kZSBjb250ZXh0IGhlcmUgaXMgd2FudCB0byBnZXQgdGhlIGZhaWxlZCBB cHMgYW5kIHJldHVybiB0aGVtLiBTbyBpdCBzaG91bGQgdXNlIFJ1bm5pbmdDb3VudCBoZXJlLCBy aWdodD8gQWxzbyB0aGUgRmluaXNoZWRDb3VudCBtYXkgYmUgYmlnZ2VyIHRoYW4gU3RhcnRDb3Vu dCBpZiBtYW55IEFwcyBoYXMgYmVlbiBkaXNhYmxlZC4gUmlnaHQ/IA0KDQo+IFRoZSBwYXRjaCBy ZXBsYWNlcyB0aGlzIGRpZmZlcmVuY2Ugd2l0aA0KPiANCj4gICBTdGFydENvdW50IC0gUnVubmlu Z0NvdW50DQo+IA0KPiB0aGF0IGlzLCB0aGUgZGlmZmVyZW5jZSBpcyBubyBtb3JlIGNhbGN1bGF0 ZWQgZnJvbSB0aGUgQlNQJ3Mgc3RhcnR1cCBjb3VudGVyDQo+IGFuZCB0aGUgQVAncyBzaGFyZWQg ZmluaXNoIGNvdW50ZXIsIGJ1dCBmcm9tIHRoZSBSdW5uaW5nQ291bnQgbWVhc3VyZW1lbnQNCj4g dGhhdCB0aGUgQlNQIGRvZXMgaXRzZWxmLCBpbiBDaGVja0FsbEFQcygpLg0KPiANCj4gW1RoaXMg Y2hhbmdlIGlzIE9LIHRvIG1lIGFzIHdlbGwsIGJ1dCB3ZSBzaG91bGQgYmUgY2xlYXIgYWJvdXQg aXQuXQ0KPiANCj4gKDMpIEZpbmFsbHksIHRoZSBwYXRjaCBjaGFuZ2VzIHRoZSBtZWFuaW5nIG9m IFJ1bm5pbmdDb3VudC4gQmVmb3JlIHRoZSBwYXRjaCwNCj4gd2UgaGF2ZToNCj4gDQo+IC0gU3Rh cnRDb3VudDogdGhlIG51bWJlciBvZiBBUHMgdGhlIEJTUCBzdGFycyB1cCwNCj4gLSBSdW5uaW5n Q291bnQ6IHRoZSBudW1iZXIgb2YgZmluaXNoZWQgQVBzIHRoYXQgdGhlIEJTUCBjb2xsZWN0ZWQN Cj4gDQo+IEFmdGVyIHRoZSBwYXRjaCwgU3RhcnRDb3VudCBpcyByZW1vdmVkLCBhbmQgUnVubmlu Z0NvdW50IGlzICpyZWRlZmluZWQqIGFzDQo+IHRoZSBmb2xsb3dpbmcgZGlmZmVyZW5jZToNCj4g DQo+ICAgT0xEX1N0YXJ0Q291bnQgLSBPTERfUnVubmluZ0NvdW50DQo+IA0KPiBHaXZpbmcgdGhl IG51bWJlciBvZiBBUHMgdGhhdCB0aGUgQlNQIHN0YXJ0ZWQgdXAgYnV0IGhhc24ndCBjb2xsZWN0 ZWQgeWV0Lg0KPiANCj4gW1RoaXMgY2hhbmdlIGxvb2tzIGdvb2QgdG8gbWUgYXMgd2VsbC5dDQo+ IA0KPiAtLS0tKi0tLS0NCj4gDQo+IEltcG9ydGFudGx5LCB3aGF0IHdlIHNlZSBpbiB0aGUgQWxs b2NhdGVQb29sKCkgYXJndW1lbnQsIGlzIHRoZQ0KPiAqY29tcG9zaXRpb24qIG9mIHN0ZXBzICgy KSBhbmQgKDMpLg0KPiANCj4gSWYgeW91IGFncmVlLCBjYW4geW91IHBsZWFzZSB1cGRhdGUgdGhl IGNvbW1pdCBtZXNzYWdlIHRvIGluY2x1ZGUgbXkgcG9pbnRzDQo+ICgxKSB0aHJvdWdoICgzKT8g SXQncyBPSyBpZiB5b3UgbGVhdmUgb3V0IG15IHJlbWFya3MgaW4gYnJhY2tldHMgW10uDQoNCkFn cmVlZC4gV2lsbCB1c2UgeW91ciBjb250ZW50IHdoZW4gY29tbWl0IHRoZSBjaGFuZ2VzLg0KDQpU aGFua3MsDQpFcmljDQoNCj4gDQo+IE5vIG5lZWQgdG8gcmVwb3N0IGp1c3QgYmVjYXVzZSBvZiB0 aGlzLCBvZiBjb3Vyc2UuDQo+IA0KPiBUaGFua3MhDQo+IExhc3psbw0KPiANCj4gPg0KPiA+IENj OiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPg0KPiA+IENjOiBSdWl5dSBOaSA8cnVp eXUubmlAaW50ZWwuY29tPg0KPiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJp YnV0aW9uIEFncmVlbWVudCAxLjENCj4gPiBTaWduZWQtb2ZmLWJ5OiBFcmljIERvbmcgPGVyaWMu ZG9uZ0BpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIFVlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRM aWIvTXBMaWIuYyB8IDExICsrKysrLS0tLS0tDQo+ID4gVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5p dExpYi9NcExpYi5oIHwgIDMgKy0tDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL1VlZmlDcHVQa2cvTGli cmFyeS9NcEluaXRMaWIvTXBMaWIuYw0KPiA+IGIvVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExp Yi9NcExpYi5jDQo+ID4gaW5kZXggZmYwOWEwZTllNy4uMGU1N2NjODZiZiAxMDA2NDQNCj4gPiAt LS0gYS9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL01wTGliLmMNCj4gPiArKysgYi9VZWZp Q3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL01wTGliLmMNCj4gPiBAQCAtMTQyNCw3ICsxNDI0LDcg QEAgQ2hlY2tBbGxBUHMgKA0KPiA+ICAgICAgLy8gdmFsdWUgb2Ygc3RhdGUgYWZ0ZXIgc2V0dGlu ZyB0aGUgaXQgdG8gQ3B1U3RhdGVJZGxlLCBzbyBCU1AgY2FuIHNhZmVseQ0KPiBtYWtlIHVzZSBv ZiBpdHMgdmFsdWUuDQo+ID4gICAgICAvLw0KPiA+ICAgICAgaWYgKEdldEFwU3RhdGUoQ3B1RGF0 YSkgPT0gQ3B1U3RhdGVJZGxlKSB7DQo+ID4gLSAgICAgIENwdU1wRGF0YS0+UnVubmluZ0NvdW50 ICsrOw0KPiA+ICsgICAgICBDcHVNcERhdGEtPlJ1bm5pbmdDb3VudCAtLTsNCj4gPiAgICAgICAg Q3B1TXBEYXRhLT5DcHVEYXRhW1Byb2Nlc3Nvck51bWJlcl0uV2FpdGluZyA9IEZBTFNFOw0KPiA+ DQo+ID4gICAgICAgIC8vDQo+ID4gQEAgLTE0NDksNyArMTQ0OSw3IEBAIENoZWNrQWxsQVBzICgN Cj4gPiAgICAvLw0KPiA+ICAgIC8vIElmIGFsbCBBUHMgZmluaXNoLCByZXR1cm4gRUZJX1NVQ0NF U1MuDQo+ID4gICAgLy8NCj4gPiAtICBpZiAoQ3B1TXBEYXRhLT5SdW5uaW5nQ291bnQgPT0gQ3B1 TXBEYXRhLT5TdGFydENvdW50KSB7DQo+ID4gKyAgaWYgKENwdU1wRGF0YS0+UnVubmluZ0NvdW50 ID09IDApIHsNCj4gPiAgICAgIHJldHVybiBFRklfU1VDQ0VTUzsNCj4gPiAgICB9DQo+ID4NCj4g PiBAQCAtMTQ2Niw3ICsxNDY2LDcgQEAgQ2hlY2tBbGxBUHMgKA0KPiA+ICAgICAgLy8NCj4gPiAg ICAgIGlmIChDcHVNcERhdGEtPkZhaWxlZENwdUxpc3QgIT0gTlVMTCkgew0KPiA+ICAgICAgICAq Q3B1TXBEYXRhLT5GYWlsZWRDcHVMaXN0ID0NCj4gPiAtICAgICAgICAgQWxsb2NhdGVQb29sICgo Q3B1TXBEYXRhLT5TdGFydENvdW50IC0gQ3B1TXBEYXRhLT5GaW5pc2hlZENvdW50DQo+ICsgMSkg KiBzaXplb2YgKFVJTlROKSk7DQo+ID4gKyAgICAgICAgIEFsbG9jYXRlUG9vbCAoKENwdU1wRGF0 YS0+UnVubmluZ0NvdW50ICsgMSkgKiBzaXplb2YNCj4gPiArIChVSU5UTikpOw0KPiA+ICAgICAg ICBBU1NFUlQgKCpDcHVNcERhdGEtPkZhaWxlZENwdUxpc3QgIT0gTlVMTCk7DQo+ID4gICAgICB9 DQo+ID4gICAgICBMaXN0SW5kZXggPSAwOw0KPiA+IEBAIC0yMjEyLDcgKzIyMTIsNyBAQCBTdGFy dHVwQWxsQVBzV29ya2VyICgNCj4gPiAgICAgIHJldHVybiBFRklfTk9UX1NUQVJURUQ7DQo+ID4g ICAgfQ0KPiA+DQo+ID4gLSAgQ3B1TXBEYXRhLT5TdGFydENvdW50ID0gMDsNCj4gPiArICBDcHVN cERhdGEtPlJ1bm5pbmdDb3VudCA9IDA7DQo+ID4gICAgZm9yIChQcm9jZXNzb3JOdW1iZXIgPSAw OyBQcm9jZXNzb3JOdW1iZXIgPCBQcm9jZXNzb3JDb3VudDsNCj4gUHJvY2Vzc29yTnVtYmVyKysp IHsNCj4gPiAgICAgIENwdURhdGEgPSAmQ3B1TXBEYXRhLT5DcHVEYXRhW1Byb2Nlc3Nvck51bWJl cl07DQo+ID4gICAgICBDcHVEYXRhLT5XYWl0aW5nID0gRkFMU0U7DQo+ID4gQEAgLTIyMjIsNyAr MjIyMiw3IEBAIFN0YXJ0dXBBbGxBUHNXb3JrZXIgKA0KPiA+ICAgICAgICAgIC8vIE1hcmsgdGhp cyBwcm9jZXNzb3IgYXMgcmVzcG9uc2libGUgZm9yIGN1cnJlbnQgY2FsbGluZy4NCj4gPiAgICAg ICAgICAvLw0KPiA+ICAgICAgICAgIENwdURhdGEtPldhaXRpbmcgPSBUUlVFOw0KPiA+IC0gICAg ICAgIENwdU1wRGF0YS0+U3RhcnRDb3VudCsrOw0KPiA+ICsgICAgICAgIENwdU1wRGF0YS0+UnVu bmluZ0NvdW50Kys7DQo+ID4gICAgICAgIH0NCj4gPiAgICAgIH0NCj4gPiAgICB9DQo+ID4gQEAg LTIyMzEsNyArMjIzMSw2IEBAIFN0YXJ0dXBBbGxBUHNXb3JrZXIgKA0KPiA+ICAgIENwdU1wRGF0 YS0+UHJvY0FyZ3VtZW50cyA9IFByb2NlZHVyZUFyZ3VtZW50Ow0KPiA+ICAgIENwdU1wRGF0YS0+ U2luZ2xlVGhyZWFkICA9IFNpbmdsZVRocmVhZDsNCj4gPiAgICBDcHVNcERhdGEtPkZpbmlzaGVk Q291bnQgPSAwOw0KPiA+IC0gIENwdU1wRGF0YS0+UnVubmluZ0NvdW50ICA9IDA7DQo+ID4gICAg Q3B1TXBEYXRhLT5GYWlsZWRDcHVMaXN0ID0gRmFpbGVkQ3B1TGlzdDsNCj4gPiAgICBDcHVNcERh dGEtPkV4cGVjdGVkVGltZSAgPSBDYWxjdWxhdGVUaW1lb3V0ICgNCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFRpbWVvdXRJbk1pY3Jvc2Vjb25kcywgZGlmZiAtLWdpdA0KPiA+ IGEvVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExpYi9NcExpYi5oDQo+ID4gYi9VZWZpQ3B1UGtn L0xpYnJhcnkvTXBJbml0TGliL01wTGliLmgNCj4gPiBpbmRleCA5NjJiY2U2ODVkLi41MDAyYjdl OWMwIDEwMDY0NA0KPiA+IC0tLSBhL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIu aA0KPiA+ICsrKyBiL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIuaA0KPiA+IEBA IC0yMTEsOSArMjExLDggQEAgc3RydWN0IF9DUFVfTVBfREFUQSB7DQo+ID4gICAgVUlOVE4gICAg ICAgICAgICAgICAgICAgICAgICAgIEJhY2t1cEJ1ZmZlcjsNCj4gPiAgICBVSU5UTiAgICAgICAg ICAgICAgICAgICAgICAgICAgQmFja3VwQnVmZmVyU2l6ZTsNCj4gPg0KPiA+IC0gIHZvbGF0aWxl IFVJTlQzMiAgICAgICAgICAgICAgICBTdGFydENvdW50Ow0KPiA+ICAgIHZvbGF0aWxlIFVJTlQz MiAgICAgICAgICAgICAgICBGaW5pc2hlZENvdW50Ow0KPiA+IC0gIHZvbGF0aWxlIFVJTlQzMiAg ICAgICAgICAgICAgICBSdW5uaW5nQ291bnQ7DQo+ID4gKyAgVUlOVDMyICAgICAgICAgICAgICAg ICAgICAgICAgIFJ1bm5pbmdDb3VudDsNCj4gPiAgICBCT09MRUFOICAgICAgICAgICAgICAgICAg ICAgICAgU2luZ2xlVGhyZWFkOw0KPiA+ICAgIEVGSV9BUF9QUk9DRURVUkUgICAgICAgICAgICAg ICBQcm9jZWR1cmU7DQo+ID4gICAgVk9JRCAgICAgICAgICAgICAgICAgICAgICAgICAgICpQcm9j QXJndW1lbnRzOw0KPiA+DQoNCg==