From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82E4021B02822 for ; Thu, 9 Aug 2018 20:10:20 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 20:10:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="71657734" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 09 Aug 2018 20:10:15 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 20:10:14 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 20:10:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 11:10:12 +0800 From: "Dong, Eric" To: Laszlo Ersek , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation. Thread-Index: AQHULusnfrR5DkkP50iK/4fvm0DphKS12ZOAgABhqgCAAIbuAIABjiKw Date: Fri, 10 Aug 2018 03:10:11 +0000 Message-ID: References: <20180808074006.21360-1-eric.dong@intel.com> <12da7e20-6f8e-0e3b-f026-42041e6b2415@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5BDC96E8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 03:10:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IExhc3ps byBFcnNlayBbbWFpbHRvOmxlcnNla0ByZWRoYXQuY29tXQ0KPiBTZW50OiBUaHVyc2RheSwgQXVn dXN0IDksIDIwMTggNzoyMSBQTQ0KPiBUbzogTmksIFJ1aXl1IDxydWl5dS5uaUBpbnRlbC5jb20+ OyBEb25nLCBFcmljIDxlcmljLmRvbmdAaW50ZWwuY29tPjsgZWRrMi0NCj4gZGV2ZWxAbGlzdHMu MDEub3JnDQo+IFN1YmplY3Q6IFJlOiBbZWRrMl0gW1BhdGNoIHYyIDEvMl0gVWVmaUNwdVBrZy9S ZWdpc3RlckNwdUZlYXR1cmVzTGliOg0KPiBDb21iaW5lIGltcGxlbWVudGF0aW9uLg0KPiANCj4g T24gMDgvMDkvMTggMDU6MTgsIE5pLCBSdWl5dSB3cm90ZToNCj4gPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4N Cj4gPj4gU2VudDogVGh1cnNkYXksIEF1Z3VzdCA5LCAyMDE4IDU6MjkgQU0NCj4gPj4gVG86IERv bmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0K PiA+PiBDYzogTmksIFJ1aXl1IDxydWl5dS5uaUBpbnRlbC5jb20+DQo+ID4+IFN1YmplY3Q6IFJl OiBbZWRrMl0gW1BhdGNoIHYyIDEvMl0gVWVmaUNwdVBrZy9SZWdpc3RlckNwdUZlYXR1cmVzTGli Og0KPiA+PiBDb21iaW5lIGltcGxlbWVudGF0aW9uLg0KPiA+Pg0KPiA+PiBPbiAwOC8wOC8xOCAw OTo0MCwgRXJpYyBEb25nIHdyb3RlOg0KPiA+Pj4gVjEgY2hhbmdlczoNCj4gPj4+PiBDdXJyZW50 IGNvZGUgbG9naWMgY2FuJ3QgY29uZmlybSBDcHVTM0RhdGFEeGUgZHJpdmVyIHN0YXJ0IGJlZm9y ZQ0KPiA+Pj4+IENwdUZlYXR1cmVzRHhlIGRyaXZlci4gU28gdGhlIGFzc3VtcHRpb24gaW4gQ3B1 RmVhdHVyZXNEeGUgbm90IHZhbGlkLg0KPiA+Pj4+IEFkZCBpbXBsZW1lbnRhdGlvbiBmb3IgQWxs b2NhdGVBY3BpQ3B1RGF0YSBmdW5jdGlvbiB0byByZW1vdmUgdGhpcw0KPiA+Pj4+IGFzc3VtcHRp b24uDQo+ID4+Pg0KPiA+Pj4gVjIgY2hhbmdlczoNCj4gPj4+PiBCZWNhdXNlIENwdVMzRGF0YSBt ZW1vcnkgd2lsbCBiZSBjb3B5IHRvIHNtcmFtIGF0IFNtbVJlYWRUb0xvY2sNCj4gPj4+PiBwb2lu dCwgc28gdGhlIG1lbW9yeSB0eXBlIG5vIG5lZWQgdG8gYmUgQUNQSSBOVlMgdHlwZSwgYWxzbyB0 aGUNCj4gPj4+PiBhZGRyZXNzIG5vdCBsaW1pdCB0byBiZWxvdyA0Ry4NCj4gPj4+PiBUaGlzIGNo YW5nZSByZW1vdmUgdGhlIGxpbWl0IG9mIEFDUEkgTlZTIG1lbW9yeSB0eXBlIGFuZCBiZWxvdyA0 Ry4NCj4gPj4NCj4gPj4gSSdtIHJldHVybmluZyB0byB0aGlzIHBhdGNoICh2MiAxLzIpIGFmdGVy IG15IG90aGVyIGNvbW1lbnRzIChmb3IgdjIgMi8yKS4NCj4gPj4NCj4gPj4gSXQgc2VlbXMgdGhh dCBhbGxvY2F0aW5nIEFDUElfQ1BVX0RBVEEgaW4gQm9vdFNlcnZpY2VzRGF0YSB0eXBlDQo+ID4+ IG1lbW9yeSBicmVha3MgYXQgbGVhc3QgdGhlIGRvY3MgLyBzcGVjcyBpbg0KPiA+PiAiVWVmaUNw dVBrZy9JbmNsdWRlL0FjcGlDcHVEYXRhLmgiLA0KPiA+PiBldmVuIGlmIHdlIGRvIHRoZSBCb290 U2VydmljZXNEYXRhIGFsbG9jYXRpb24gaW4NCj4gPj4gUmVnaXN0ZXJDcHVGZWF0dXJlc0xpYiBp bnN0YW5jZXMgKGkuZS4gaW4gQ3B1RmVhdHVyZXNQZWkgLw0KPiA+PiBDcHVGZWF0dXJlc0R4ZSks IGFuZCBub3QgaW4gQ3B1UzNEYXRhRHhlLg0KPiA+Pg0KPiA+PiBXaXRoIHRoYXQgaW4gbWluZCwg c2hvdWxkIHdlIHJldHVybiB0byB5b3VyIHYxIHBhdGNoLA0KPiA+PiAiVWVmaUNwdVBrZy9SZWdp c3RlckNwdUZlYXR1cmVzTGliOiBJbXBsZW1lbnQgQWxsb2NhdGVBY3BpQ3B1RGF0YQ0KPiA+PiBm dW5jdGlvbiI/DQo+ID4+DQo+ID4+IEFuZCwgbG9va2luZyBiYWNrIGF0IG15IHF1ZXN0aW9uICg0 KSB0aGVyZSwgd2hlcmUgSSBzdWdnZXN0ZWQNCj4gPj4gQWxsb2NhdGVQZWlBY2Nlc3NpYmxlUGFn ZXMoKSAtLSBJJ20gbm93IHRoaW5raW5nIHRoYXQgaXQgZG9lcyBub3QNCj4gPj4gYXBwbHksIGJl Y2F1c2UgdGhlIEFDUElfQ1BVX0RBVEEgc3BlYyBpbg0KPiAiVWVmaUNwdVBrZy9JbmNsdWRlL0Fj cGlDcHVEYXRhLmgiDQo+ID4+IHJlcXVpcmVzIHRoZSA0R0IgbGltaXQuDQo+ID4NCj4gPiBJIGd1 ZXNzIEVyaWMgZm9yZ290IHRvIHVwZGF0ZSB0aGUgY29tbWVudHMgaW4gQWNwaUNwdURhdGEuaCBy ZWdhcmRpbmcNCj4gPiB0aGUgNEdCL05WUyByZXN0cmljdGlvbi4NCj4gDQo+IElmIHBhdGNoICMy IGlzIGZpeGVkLCAqYW5kKiB0aGUgIkFjcGlDcHVEYXRhLmgiIGRvY3VtZW50YXRpb24gaXMgdXBk YXRlZCwNCj4gcmVsYXhpbmcgdGhlIGFsbG9jYXRpb24gcmVzdHJpY3Rpb24sIHRoZW4gdGhpcyBw YXRjaCBzZXQgY291bGQgYmUgdmlhYmxlLCB5ZXMuIEkNCj4gd291bGQgc3RpbGwgbGlrZSBNaWtl IHRvIGNvbmZpcm0gYXMgd2VsbC4NCj4gDQo+ID4gV2UndmUgcmV2aWV3ZWQgdGhlIHdob2xlIHBy b2R1Y2VyL2NvbnN1bWVyIGNvZGUgYW5kIGNhbWUgdG8gdGhlDQo+ID4gY29uY2x1c2lvbiB0aGF0 IDRHQi9OVlMgcmVzdHJpY3Rpb24gaXMgdW5uZWNlc3NhcnkuDQo+IA0KPiBJIHRoaW5rIHlvdSBi b3RoIG1pc3NlZCB0aGUgaW4tcGxhY2UgcmVzdG9yYXRpb24gb2YgdGhlIEdEVCBhbmQgdGhlIElE VCwgdG8NCj4gQWNwaU5WUyBtZW1vcnkgYWxsb2NhdGVkIG9yaWdpbmFsbHkgYnkgQ3B1UzNEYXRh RHhlLiBQbGVhc2UgcmUtcmVhZA0KPiBzZWN0aW9uICgxMCkgb2YgbXkgb3RoZXIgZW1haWwgY2Fy ZWZ1bGx5Og0KPiANCj4gaHR0cDovL21pZC5tYWlsLWFyY2hpdmUuY29tL2Y0ODkzNWU0LTk2YjMt OTc4ZS1kNjdjLQ0KPiA4NGExNjk0MTRjY2JAcmVkaGF0LmNvbQ0KPiANCj4gQmFzaWNhbGx5LCB0 aGUgR2R0clByb2ZpbGUgYW5kIElkdHJQcm9maWxlIGZpZWxkcyBpbiBBQ1BJX0NQVV9EQVRBIGFy ZQ0KPiAqZG91Ymx5KiBpbmRpcmVjdCByZWZlcmVuY2VzLiBUaGUgZmllbGRzIHRoZW1zZWx2ZXMg cG9pbnQgdG8gSURUIGFuZCBHRFQNCj4gKmRlc2NyaXB0b3JzKiwgYW5kIHRob3NlIGRlc2NyaXB0 b3JzICh0aGUgQmFzZSBmaWVsZHMgaW4gdGhlbSkgcG9pbnQgdG8gdGhlDQo+IHRhYmxlcyAoSURU IGFuZCBHRFQpLg0KPiANCj4gSW5kZWVkLCBQaVNtbUNwdUR4ZVNtbSBzYXZlcyBldmVyeXRoaW5n IGludG8gU01SQU0gb24gdGhlIG5vcm1hbCBib290DQo+IHBhdGg6IChhKSBBQ1BJX0NQVV9EQVRB LCAoYikgdGhlIGRlc2NyaXB0b3JzIHBvaW50ZWQtdG8gYnkgR2R0clByb2ZpbGUgYW5kDQo+IElk dHJQcm9maWxlLCBhbmQgKGMpIHRoZSB0YWJsZXMgcG9pbnRlZC10byBieSBHZHRyUHJvZmlsZS0+ QmFzZSBhbmQNCj4gSWR0clByb2ZpbGUtPkJhc2UuDQo+IA0KPiBIb3dldmVyLCBvbiB0aGUgUzMg cmVzdW1lIHBhdGgsIFBpU21tQ3B1RHhlU21tIGRvZXMgbm90IHVzZSBldmVyeXRoaW5nDQo+IGZy b20gU01SQU0uIEluIHRoZSBQcmVwYXJlQXBTdGFydHVwVmVjdG9yKCkgZnVuY3Rpb24sIHRoZSBH RFQgYW5kIHRoZSBJRFQNCj4gdGFibGVzIC0tIGF0IHRoZSBlbmQgb2YgdGhlIHBvaW50ZXIgY2hh aW4gLS0gYXJlIHJlc3RvcmVkIHRvIHRoZQ0KPiAqb3JpZ2luYWwqIEFjcGlOVlMgbG9jYXRpb25z ICgqbm90KiBTTVJBTSksIGFuZCB0aGV5IGFyZSB0aGVuIHVzZWQgZnJvbQ0KPiB0aGVyZS4NCj4g DQoNClllcywgdGhpcyBjb2RlIGlzIHVzZWQgdG8gcmVzdG9yZSBkYXRhIGZyb20gU21yYW0gdG8g QWNwaU5WUyBtZW1vcnkuICBCdXQgSSB0aGluayB0aGlzIGlzIGEgd2VpcmQgYmVoYXZpb3IgYW5k IHdlIHNob3VsZCB1c2UgR0RUL0lEVCBpbiBzbXJhbS4gSSB3aWxsIHN1Ym1pdCBhIHNlcGFyYXRl IHBhdGNoIHRvIGRvIHRoaXMgY2hhbmdlLg0KDQpUaGFua3MsDQpFcmljDQo+IFRoaXMgaXMgbm90 IGEgc2VjdXJpdHkgYnVnLCBiZWNhdXNlIGV2ZW4gaWYgdGhlIE9TIG92ZXJ3cml0ZXMgdGhlIEFj cGlOVlMgYXJlYQ0KPiBiZXR3ZWVuIG5vcm1hbCBib290IGFuZCBTMyByZXN1bWUsIFBpU21tQ3B1 RHhlU21tIG5ldmVyIHJlYWRzIHRoYXQNCj4gYXJlYSBhdCBTMyBiZWZvcmUgcmVzdG9yaW5nIGl0 LCBmcm9tIHRoZSBTTVJBTSBvYmplY3RzICJtR2R0Rm9yQXAiIGFuZA0KPiAibUlkdEZvckFwIi4N Cj4gDQo+IEl0IGRvZXMgbWVhbiB0aG91Z2ggdGhhdCB0aGUgT1MgbXVzdCBiZSBpbmZvcm1lZCBp biBhZHZhbmNlIHRvIHN0YXkgYXdheQ0KPiBmcm9tIHRoYXQgYXJlYSwgYmVjYXVzZSBQaVNtbUNw dUR4ZVNtbSB3aWxsIG92ZXJ3cml0ZSBpdCBhdCBTMyByZXN1bWUuDQo+IFRoaXMgaXMgd2h5IHRo YXQgYWxsb2NhdGlvbiBtdXN0IGJlIGtlcHQgYXMgQWNwaU5WUy4gKE9yIG1vdmVkIHRvIFNNUkFN DQo+IGVudGlyZWx5LikNCj4gDQoNCg0KDQo+IExhc3psbw0K