From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 04B06210F1570 for ; Tue, 14 Aug 2018 19:21:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 19:21:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="72822001" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 14 Aug 2018 19:20:33 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 14 Aug 2018 19:20:33 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Wed, 15 Aug 2018 10:20:31 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a redundant function Thread-Index: AQHUNDn0cnmSIImZTUe8GUQKjA016aTAFIXg Date: Wed, 15 Aug 2018 02:20:29 +0000 Message-ID: References: <20180815014609.19948-1-shenglei.zhang@intel.com> <20180815014609.19948-23-shenglei.zhang@intel.com> In-Reply-To: <20180815014609.19948-23-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 02:21:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 15, 2018 9:46 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: [PATCH v2 22/27] MdeModulePkg HiiDatabaseDxe: Remove a > redundant function >=20 > The function GetStorageWidth that is never called has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > Reviewed-by: Star Zeng > Reviewed-by: Laszlo Ersek > --- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 ------------------- > 1 file changed, 47 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > index c778cd92f8..39e1811e69 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > @@ -3590,53 +3590,6 @@ Done: > return Status; > } >=20 > -/** > - Get Data buffer size based on data type. > - > - @param ValueType The input data type. > - > - @retval The data buffer size for the input type. > -**/ > -UINT16 > -GetStorageWidth ( > - IN UINT8 ValueType > - ) > -{ > - UINT16 StorageWidth; > - > - switch (ValueType) { > - case EFI_IFR_NUMERIC_SIZE_1: > - case EFI_IFR_TYPE_BOOLEAN: > - StorageWidth =3D (UINT16) sizeof (UINT8); > - break; > - > - case EFI_IFR_NUMERIC_SIZE_2: > - StorageWidth =3D (UINT16) sizeof (UINT16); > - break; > - > - case EFI_IFR_NUMERIC_SIZE_4: > - StorageWidth =3D (UINT16) sizeof (UINT32); > - break; > - > - case EFI_IFR_NUMERIC_SIZE_8: > - StorageWidth =3D (UINT16) sizeof (UINT64); > - break; > - > - case EFI_IFR_TYPE_TIME: > - StorageWidth =3D (UINT16) sizeof (EFI_IFR_TIME); > - break; > - > - case EFI_IFR_TYPE_DATE: > - StorageWidth =3D (UINT16) sizeof (EFI_IFR_DATE); > - break; > - > - default: > - StorageWidth =3D 0; > - break; > - } > - > - return StorageWidth; > -} >=20 > /** > Update the default value in the block data which is used as bit var st= ore. > -- > 2.18.0.windows.1