Re: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 15, 2018 9:46 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant
> functions
> 
> The functions that are never called have been removed.
> They are EnableResetReminderFeature,
> DisableResetReminderFeature and DisableResetRequired.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> Reviewed-by: Laszlo Ersek <lersek at redhat.com>
> Reviewed-by: Star Zeng <star.zeng at intel.com>
> ---
>  MdeModulePkg/Application/UiApp/FrontPage.c | 40 ----------------------
>  MdeModulePkg/Application/UiApp/Ui.h        | 30 ----------------
>  2 files changed, 70 deletions(-)
> 
> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> b/MdeModulePkg/Application/UiApp/FrontPage.c
> index 2403aad9d9..f0513deb51 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> @@ -1042,34 +1042,7 @@ UiEntry (
>  //
> 
> 
> -/**
> -  Enable the setup browser reset reminder feature.
> -  This routine is used in platform tip. If the platform policy need the feature,
> use the routine to enable it.
> 
> -**/
> -VOID
> -EFIAPI
> -EnableResetReminderFeature (
> -  VOID
> -  )
> -{
> -  mFeaturerSwitch = TRUE;
> -}
> -
> -
> -/**
> -  Disable the setup browser reset reminder feature.
> -  This routine is used in platform tip. If the platform policy do not want the
> feature, use the routine to disable it.
> -
> -**/
> -VOID
> -EFIAPI
> -DisableResetReminderFeature (
> -  VOID
> -  )
> -{
> -  mFeaturerSwitch = FALSE;
> -}
> 
> 
>  /**
> @@ -1087,19 +1060,6 @@ EnableResetRequired (  }
> 
> 
> -/**
> -  Record the info that  no reset is required.
> -  A  module boolean variable is used to record whether a reset is required.
> -
> -**/
> -VOID
> -EFIAPI
> -DisableResetRequired (
> -  VOID
> -  )
> -{
> -  mResetRequired = FALSE;
> -}
> 
> 
>  /**
> diff --git a/MdeModulePkg/Application/UiApp/Ui.h
> b/MdeModulePkg/Application/UiApp/Ui.h
> index a9c30b0c56..7be164570c 100644
> --- a/MdeModulePkg/Application/UiApp/Ui.h
> +++ b/MdeModulePkg/Application/UiApp/Ui.h
> @@ -53,27 +53,7 @@ typedef struct {
>  //
>  //The interface functions related to the Setup Browser Reset Reminder
> feature  //
> -/**
> -  Enable the setup browser reset reminder feature.
> -  This routine is used in a platform tip. If the platform policy needs the
> feature, use the routine to enable it.
> 
> -**/
> -VOID
> -EFIAPI
> -EnableResetReminderFeature (
> -  VOID
> -  );
> -
> -/**
> -  Disable the setup browser reset reminder feature.
> -  This routine is used in a platform tip. If the platform policy does not want
> the feature, use the routine to disable it.
> -
> -**/
> -VOID
> -EFIAPI
> -DisableResetReminderFeature (
> -  VOID
> -  );
> 
>  /**
>    Record the info that a reset is required.
> @@ -87,16 +67,6 @@ EnableResetRequired (
>    );
> 
> 
> -/**
> -  Record the info that no reset is required.
> -  A module boolean variable is used to record whether a reset is required.
> -
> -**/
> -VOID
> -EFIAPI
> -DisableResetRequired (
> -  VOID
> -  );
> 
>  /**
>    Check whether platform policy enables the reset reminder feature. The
> default is enabled.
> --
> 2.18.0.windows.1