From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DCD021962301 for ; Tue, 14 Aug 2018 19:27:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 19:27:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,241,1531810800"; d="scan'208";a="72822833" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 14 Aug 2018 19:24:55 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 14 Aug 2018 19:24:55 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 14 Aug 2018 19:24:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Wed, 15 Aug 2018 10:24:45 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions Thread-Index: AQHUNDnlK3v7Tjw7LkiMQ4WKxJanb6TAFbuA Date: Wed, 15 Aug 2018 02:24:44 +0000 Message-ID: References: <20180815014609.19948-1-shenglei.zhang@intel.com> <20180815014609.19948-3-shenglei.zhang@intel.com> In-Reply-To: <20180815014609.19948-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 02:27:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 15, 2018 9:46 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: [PATCH v2 02/27] MdeModulePkg UiApp: Remove redundant > functions >=20 > The functions that are never called have been removed. > They are EnableResetReminderFeature, > DisableResetReminderFeature and DisableResetRequired. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > Reviewed-by: Laszlo Ersek > Reviewed-by: Star Zeng > --- > MdeModulePkg/Application/UiApp/FrontPage.c | 40 ---------------------- > MdeModulePkg/Application/UiApp/Ui.h | 30 ---------------- > 2 files changed, 70 deletions(-) >=20 > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c > b/MdeModulePkg/Application/UiApp/FrontPage.c > index 2403aad9d9..f0513deb51 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPage.c > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c > @@ -1042,34 +1042,7 @@ UiEntry ( > // >=20 >=20 > -/** > - Enable the setup browser reset reminder feature. > - This routine is used in platform tip. If the platform policy need the = feature, > use the routine to enable it. >=20 > -**/ > -VOID > -EFIAPI > -EnableResetReminderFeature ( > - VOID > - ) > -{ > - mFeaturerSwitch =3D TRUE; > -} > - > - > -/** > - Disable the setup browser reset reminder feature. > - This routine is used in platform tip. If the platform policy do not wa= nt the > feature, use the routine to disable it. > - > -**/ > -VOID > -EFIAPI > -DisableResetReminderFeature ( > - VOID > - ) > -{ > - mFeaturerSwitch =3D FALSE; > -} >=20 >=20 > /** > @@ -1087,19 +1060,6 @@ EnableResetRequired ( } >=20 >=20 > -/** > - Record the info that no reset is required. > - A module boolean variable is used to record whether a reset is requir= ed. > - > -**/ > -VOID > -EFIAPI > -DisableResetRequired ( > - VOID > - ) > -{ > - mResetRequired =3D FALSE; > -} >=20 >=20 > /** > diff --git a/MdeModulePkg/Application/UiApp/Ui.h > b/MdeModulePkg/Application/UiApp/Ui.h > index a9c30b0c56..7be164570c 100644 > --- a/MdeModulePkg/Application/UiApp/Ui.h > +++ b/MdeModulePkg/Application/UiApp/Ui.h > @@ -53,27 +53,7 @@ typedef struct { > // > //The interface functions related to the Setup Browser Reset Reminder > feature // > -/** > - Enable the setup browser reset reminder feature. > - This routine is used in a platform tip. If the platform policy needs t= he > feature, use the routine to enable it. >=20 > -**/ > -VOID > -EFIAPI > -EnableResetReminderFeature ( > - VOID > - ); > - > -/** > - Disable the setup browser reset reminder feature. > - This routine is used in a platform tip. If the platform policy does no= t want > the feature, use the routine to disable it. > - > -**/ > -VOID > -EFIAPI > -DisableResetReminderFeature ( > - VOID > - ); >=20 > /** > Record the info that a reset is required. > @@ -87,16 +67,6 @@ EnableResetRequired ( > ); >=20 >=20 > -/** > - Record the info that no reset is required. > - A module boolean variable is used to record whether a reset is require= d. > - > -**/ > -VOID > -EFIAPI > -DisableResetRequired ( > - VOID > - ); >=20 > /** > Check whether platform policy enables the reset reminder feature. The > default is enabled. > -- > 2.18.0.windows.1