Re: [PATCH v3 0/2] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>  for this serial.

> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, August 17, 2018 10:35 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH v3 0/2] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM
> 
> V3 changes:
> A. Add relating CVE issue number to the commits' subject line.
> 
> B. Keep the URL links within log messages unwrapped.
> 
> C. Add TianoCore Bugzilla link reference to each commits.
> 
> D. Mention further actions should be taken after pushing the series in log
>    messages.
> 
> E. Refine file description comments for StuffRsb.inc files.
> 
> V2 changes:
> A. Refine commit log message to clarify the purpose of the series
> 
> B. Extract the RSB stuffing logic to INC files to avoid code duplication:
> When compiling .NASM source files, the current build rule does not support
> including files other than the .NASM file directory, this series will duplicate
> the StuffRsb.inc file together with the .NASM files at this moment.
> 
> Please consider this approach as the first stage, I have filed a Bugzilla for
> adding $(INC)-like support when compiling .NASM files:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1085
> 
> After the above support is added, the next step will be taken to remove those
> duplicated StuffRsb.inc files and put it under a common include directory like:
> UefiCpuPkg/Include/
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Hao Wu (2):
>   UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5715] Stuff RSB before RSM
>   UefiCpuPkg/SmmCpuFeaturesLib: [CVE-2017-5715] Stuff RSB before RSM
> 
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiEntry.nasm     |  3 ++
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiException.nasm | 10 ++--
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/StuffRsb.inc      | 55
> ++++++++++++++++++++
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm      |  3 ++
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiException.nasm  |  8 ++-
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/StuffRsb.inc       | 55
> ++++++++++++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm                |  3 ++
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.nasm                 |  3 ++
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/StuffRsb.inc                 | 55
> ++++++++++++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm                 |  3 ++
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm                  |  3 ++
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/StuffRsb.inc                  | 55
> ++++++++++++++++++++
>  12 files changed, 251 insertions(+), 5 deletions(-)  create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/StuffRsb.inc
>  create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/StuffRsb.inc
>  create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/StuffRsb.inc
>  create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/StuffRsb.inc
> 
> --
> 2.12.0.windows.1