From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9D662210F52AE for ; Sun, 19 Aug 2018 23:46:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2018 23:46:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,263,1531810800"; d="scan'208";a="63705852" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 19 Aug 2018 23:46:35 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Aug 2018 23:46:34 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.185]) with mapi id 14.03.0319.002; Mon, 20 Aug 2018 14:46:32 +0800 From: "Dong, Eric" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , Laszlo Ersek , "Kinney, Michael D" Thread-Topic: [PATCH v3 0/2] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM Thread-Index: AQHUNdLwI1KNpjX170qfLpaxvXrjmqTINzXQ Date: Mon, 20 Aug 2018 06:46:32 +0000 Message-ID: References: <20180817023511.6420-1-hao.a.wu@intel.com> In-Reply-To: <20180817023511.6420-1-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 0/2] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2018 06:46:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong for this serial. > -----Original Message----- > From: Wu, Hao A > Sent: Friday, August 17, 2018 10:35 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Dong, Eric ; Laszlo Ersek ; Kinne= y, > Michael D > Subject: [PATCH v3 0/2] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM >=20 > V3 changes: > A. Add relating CVE issue number to the commits' subject line. >=20 > B. Keep the URL links within log messages unwrapped. >=20 > C. Add TianoCore Bugzilla link reference to each commits. >=20 > D. Mention further actions should be taken after pushing the series in lo= g > messages. >=20 > E. Refine file description comments for StuffRsb.inc files. >=20 > V2 changes: > A. Refine commit log message to clarify the purpose of the series >=20 > B. Extract the RSB stuffing logic to INC files to avoid code duplication: > When compiling .NASM source files, the current build rule does not suppor= t > including files other than the .NASM file directory, this series will dup= licate > the StuffRsb.inc file together with the .NASM files at this moment. >=20 > Please consider this approach as the first stage, I have filed a Bugzilla= for > adding $(INC)-like support when compiling .NASM files: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1085 >=20 > After the above support is added, the next step will be taken to remove t= hose > duplicated StuffRsb.inc files and put it under a common include directory= like: > UefiCpuPkg/Include/ >=20 > Cc: Jiewen Yao > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Michael D Kinney >=20 > Hao Wu (2): > UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5715] Stuff RSB before RSM > UefiCpuPkg/SmmCpuFeaturesLib: [CVE-2017-5715] Stuff RSB before RSM >=20 > UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiEntry.nasm | 3 ++ > UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiException.nasm | 10 ++-- > UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/StuffRsb.inc | 55 > ++++++++++++++++++++ > UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 3 ++ > UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiException.nasm | 8 ++- > UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/StuffRsb.inc | 55 > ++++++++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 3 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.nasm | 3 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/StuffRsb.inc | 55 > ++++++++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 3 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 3 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/StuffRsb.inc | 55 > ++++++++++++++++++++ > 12 files changed, 251 insertions(+), 5 deletions(-) create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/StuffRsb.inc > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/StuffRsb.inc > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/StuffRsb.inc > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/StuffRsb.inc >=20 > -- > 2.12.0.windows.1