public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message
Date: Wed, 29 Aug 2018 03:27:28 +0000	[thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224AC96DB1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180829032135.16156-1-jian.j.wang@intel.com>

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Wang, Jian J
> Sent: Wednesday, August 29, 2018 11:22 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message
> 
> It's reported the debug message in CpuDxe driver is quite annoying in boot
> and shell, and slow down the boot process. To solve this issue, this patch
> changes the DEBUG_INFO to DEBUG_VERBOSE. On a typical Intel real
> platform, at least 16s boot time can be saved.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuDxe.c       | 2 +-
>  UefiCpuPkg/CpuDxe/CpuPageTable.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
> index cfd4c415ae..76661cbcd9 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.c
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
> @@ -404,7 +404,7 @@ CpuSetMemoryAttributes (
>    // to avoid unnecessary computing.
>    //
>    if (mIsFlushingGCD) {
> -    DEBUG((DEBUG_INFO, "  Flushing GCD\n"));
> +    DEBUG((DEBUG_VERBOSE, "  Flushing GCD\n"));
>      return EFI_SUCCESS;
>    }
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> index df021798c0..609df58e3a 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> @@ -528,7 +528,7 @@ SplitPage (
>      ASSERT (SplitAttribute == Page4K);
>      if (SplitAttribute == Page4K) {
>        NewPageEntry = AllocatePagesFunc (1);
> -      DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry));
> +      DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry));
>        if (NewPageEntry == NULL) {
>          return RETURN_OUT_OF_RESOURCES;
>        }
> @@ -549,7 +549,7 @@ SplitPage (
>      ASSERT (SplitAttribute == Page2M || SplitAttribute == Page4K);
>      if ((SplitAttribute == Page2M || SplitAttribute == Page4K)) {
>        NewPageEntry = AllocatePagesFunc (1);
> -      DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry));
> +      DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry));
>        if (NewPageEntry == NULL) {
>          return RETURN_OUT_OF_RESOURCES;
>        }
> --
> 2.16.2.windows.1



  reply	other threads:[~2018-08-29  3:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  3:21 [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message Jian J Wang
2018-08-29  3:27 ` Dong, Eric [this message]
2018-08-29 13:53 ` Laszlo Ersek
2018-08-29 22:36   ` Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED077930C258884BBCB450DB737E66224AC96DB1@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox