From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66DE82112294B for ; Thu, 6 Sep 2018 07:03:44 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 07:03:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,338,1531810800"; d="scan'208";a="83586823" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 06 Sep 2018 07:03:30 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Sep 2018 07:03:30 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Sep 2018 07:03:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.16]) with mapi id 14.03.0319.002; Thu, 6 Sep 2018 22:03:28 +0800 From: "Dong, Eric" To: Laszlo Ersek CC: "edk2-devel@lists.01.org" , "Bi, Dandan" Thread-Topic: [edk2] [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. Thread-Index: AQHURODh94LazaqSwkGWVHedNWd7B6TgzEQAgAHXXACAAKVMMA== Date: Thu, 6 Sep 2018 14:03:27 +0000 Message-ID: References: <20180905062218.13148-1-eric.dong@intel.com> <6717b922-b4b2-9fcf-8595-9cd7a1d6eff4@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGI2YjZkZWEtN2IyZC00OTc0LTljN2UtYWMyZjA5ZjEyOTU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY0s5Tnp6RTNCZkk5SWttYkhwRElzeklXUkhhOFwvMGpaRGRvXC9OMlo2MitsSXNlcEFqZ1RsVVpaU1VyczJSejBsIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 14:03:44 -0000 X-Groupsio-MsgNum: 29401 Content-Language: en-US Content-Type: multipart/mixed; boundary="_002_ED077930C258884BBCB450DB737E66224AC998BBshsmsx102ccrcor_" --_002_ED077930C258884BBCB450DB737E66224AC998BBshsmsx102ccrcor_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQpUaGFua3MgZm9yIHlvdXIgYWR2aWNlLiBJIHRydWx5IHJlY2VpdmVkIHRo ZSByLWIgZnJvbSBEYW5kYW4sIGJ1dCBJIGp1c3QgZm91bmQgc2hlIGp1c3QgcmVwbHkgdG8gbWUu ICBCdXQgSSB0cnVseSBmb3Jnb3QgdG8gaW5jbHVkZSB5b3UgaW4gdGhlIHItYiBsaXN0LiBJIHdp bGwgZm9sbG93IHlvdXIgc3VnZ2VzdGlvbiBuZXh0IHRpbWUuDQoNClRoYW5rcywNCkVyaWMNCi0t LS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBMYXN6bG8gRXJzZWsgW21haWx0bzpsZXJz ZWtAcmVkaGF0LmNvbV0gDQpTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDYsIDIwMTggODowNCBQ TQ0KVG86IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+DQpDYzogZWRrMi1kZXZlbEBs aXN0cy4wMS5vcmc7IEJpLCBEYW5kYW4gPGRhbmRhbi5iaUBpbnRlbC5jb20+DQpTdWJqZWN0OiBS ZTogW2VkazJdIFtQYXRjaF0gVWVmaUNwdVBrZy9NcEluaXRMaWI6IEZpeCBFQ0MgaXNzdWVzLg0K DQpIaSBFcmljLA0KDQpPbiAwOS8wNS8xOCAwOTo1NywgTGFzemxvIEVyc2VrIHdyb3RlOg0KPiBP biAwOS8wNS8xOCAwODoyMiwgRXJpYyBEb25nIHdyb3RlOg0KPj4gRml4IHRyYWlsaW5nIHdoaXRl IHNwYWNlcyBhbmQgaW52YWxpZCBsaW5lIGVuZGluZyBpc3N1ZS4NCj4+DQo+PiBDYzogRGFuZGFu IEJpIDxkYW5kYW4uYmlAaW50ZWwuY29tPg0KPj4gQ29udHJpYnV0ZWQtdW5kZXI6IFRpYW5vQ29y ZSBDb250cmlidXRpb24gQWdyZWVtZW50IDEuMQ0KPj4gU2lnbmVkLW9mZi1ieTogRXJpYyBEb25n IDxlcmljLmRvbmdAaW50ZWwuY29tPg0KPj4gLS0tDQo+PiAgVWVmaUNwdVBrZy9MaWJyYXJ5L01w SW5pdExpYi9NcExpYi5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMiArLQ0KPj4g IFVlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvTXBMaWIuaCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8IDIgKy0NCj4+ICBVZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL1BlaU1w SW5pdExpYi5pbmYgICAgICAgICAgICAgICAgICAgICAgfCAyICstDQo+PiAgVWVmaUNwdVBrZy9M aWJyYXJ5L1JlZ2lzdGVyQ3B1RmVhdHVyZXNMaWIvUmVnaXN0ZXJDcHVGZWF0dXJlc0xpYi5jIHwg DQo+PiAyICstDQo+PiAgNCBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIv TXBMaWIuYyANCj4+IGIvVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExpYi9NcExpYi5jDQo+PiBp bmRleCAzNzc4NzY2NDNmLi41YzU2MmQ0NzU5IDEwMDY0NA0KPj4gLS0tIGEvVWVmaUNwdVBrZy9M aWJyYXJ5L01wSW5pdExpYi9NcExpYi5jDQo+PiArKysgYi9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJ bml0TGliL01wTGliLmMNCj4+IEBAIC0xMDE0LDcgKzEwMTQsNyBAQCBXYWtlVXBBUCAoDQo+PiAg ICAgICAgICBDcHVEYXRhID0gJkNwdU1wRGF0YS0+Q3B1RGF0YVtJbmRleF07DQo+PiAgICAgICAg ICAvLw0KPj4gICAgICAgICAgLy8gQWxsIEFQKGluY2x1ZGUgZGlzYWJsZWQgQVApIHdpbGwgYmUg d29rZSB1cCBieSBJTklULVNJUEktU0lQSSwgYnV0DQo+PiAtICAgICAgICAvLyB0aGUgQVAgcHJv Y2VkdXJlIHdpbGwgYmUgc2tpcHBlZCBmb3IgZGlzYWJsZWQgQVAgYmVjYXVzZSBBUCBzdGF0ZSAN Cj4+ICsgICAgICAgIC8vIHRoZSBBUCBwcm9jZWR1cmUgd2lsbCBiZSBza2lwcGVkIGZvciBkaXNh YmxlZCBBUCBiZWNhdXNlIA0KPj4gKyBBUCBzdGF0ZQ0KPj4gICAgICAgICAgLy8gaXMgbm90IENw dVN0YXRlUmVhZHkuDQo+PiAgICAgICAgICAvLw0KPj4gICAgICAgICAgaWYgKEdldEFwU3RhdGUg KENwdURhdGEpID09IENwdVN0YXRlRGlzYWJsZWQgJiYgDQo+PiAhV2FrZVVwRGlzYWJsZWRBcHMp IHsgZGlmZiAtLWdpdCANCj4+IGEvVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExpYi9NcExpYi5o IA0KPj4gYi9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL01wTGliLmgNCj4+IGluZGV4IDc1 ZjNmZGRhMWQuLjc3M2RiNzZiNjEgMTAwNjQ0DQo+PiAtLS0gYS9VZWZpQ3B1UGtnL0xpYnJhcnkv TXBJbml0TGliL01wTGliLmgNCj4+ICsrKyBiL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIv TXBMaWIuaA0KPj4gQEAgLTI1Nyw3ICsyNTcsNyBAQCBzdHJ1Y3QgX0NQVV9NUF9EQVRBIHsNCj4+ ICAgIC8vIFdoZXRoZXIgbmVlZCB0byB1c2UgSW5pdC1TaXBpLVNpcGkgdG8gd2FrZSB1cCB0aGUg QVBzLg0KPj4gICAgLy8gVHdvIGNhc2VzIG5lZWQgdG8gc2V0IHRoaXMgdmFsdWUgdG8gVFJVRS4g T25lIGlzIGluIEhMVA0KPj4gICAgLy8gbG9vcCBtb2RlLCB0aGUgb3RoZXIgaXMgcmVzdW1lIGZy b20gUzMgd2hpY2ggbG9vcCBtb2RlDQo+PiAtICAvLyB3aWxsIGJlIGhhcmRjb2RlIGNoYW5nZSB0 byBITFQgbW9kZSBieSBQaVNtbUNwdUR4ZVNtbQ0KPj4gKyAgLy8gd2lsbCBiZSBoYXJkY29kZSBj aGFuZ2UgdG8gSExUIG1vZGUgYnkgUGlTbW1DcHVEeGVTbW0NCj4+ICAgIC8vIGRyaXZlci4NCj4+ ICAgIC8vDQo+PiAgICBCT09MRUFOICAgICAgICAgICAgICAgICAgICAgICAgV2FrZVVwQnlJbml0 U2lwaVNpcGk7DQo+PiBkaWZmIC0tZ2l0IGEvVWVmaUNwdVBrZy9MaWJyYXJ5L01wSW5pdExpYi9Q ZWlNcEluaXRMaWIuaW5mIA0KPj4gYi9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL1BlaU1w SW5pdExpYi5pbmYNCj4+IGluZGV4IDQzYTNiM2IwMzYuLjgxMDM2ZjBiMTIgMTAwNjQ0DQo+PiAt LS0gYS9VZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGliL1BlaU1wSW5pdExpYi5pbmYNCj4+ICsr KyBiL1VlZmlDcHVQa2cvTGlicmFyeS9NcEluaXRMaWIvUGVpTXBJbml0TGliLmluZg0KPj4gQEAg LTY3LDQgKzY3LDQgQEANCj4+ICAgIGdVZWZpQ3B1UGtnVG9rZW5TcGFjZUd1aWQuUGNkQ3B1QXBU YXJnZXRDc3RhdGUgICAgICAgICAgICAgICAgICAgIyMgU09NRVRJTUVTX0NPTlNVTUVTDQo+PiAg DQo+PiAgW0d1aWRzXQ0KPj4gLSAgZ0Vka2lpUzNTbW1Jbml0RG9uZUd1aWQNCj4+IFwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQ0KPj4gKyAgZ0Vka2lpUzNTbW1Jbml0RG9uZUd1aWQNCj4+IGRp ZmYgLS1naXQgDQo+PiBhL1VlZmlDcHVQa2cvTGlicmFyeS9SZWdpc3RlckNwdUZlYXR1cmVzTGli L1JlZ2lzdGVyQ3B1RmVhdHVyZXNMaWIuYyANCj4+IGIvVWVmaUNwdVBrZy9MaWJyYXJ5L1JlZ2lz dGVyQ3B1RmVhdHVyZXNMaWIvUmVnaXN0ZXJDcHVGZWF0dXJlc0xpYi5jDQo+PiBpbmRleCA0MTQz ZWU0YmIxLi5mYTdlMTA3ZTM5IDEwMDY0NA0KPj4gLS0tIA0KPj4gYS9VZWZpQ3B1UGtnL0xpYnJh cnkvUmVnaXN0ZXJDcHVGZWF0dXJlc0xpYi9SZWdpc3RlckNwdUZlYXR1cmVzTGliLmMNCj4+ICsr KyBiL1VlZmlDcHVQa2cvTGlicmFyeS9SZWdpc3RlckNwdUZlYXR1cmVzTGliL1JlZ2lzdGVyQ3B1 RmVhdHVyZXNMaQ0KPj4gKysrIGIuYw0KPj4gQEAgLTUxNiw3ICs1MTYsNyBAQCBBbGxvY2F0ZUFj cGlDcHVEYXRhICgNCj4+ICANCj4+ICAgIC8vDQo+PiAgICAvLyBBbGxvY2F0ZSBidWZmZXIgZm9y IGVtcHR5IFJlZ2lzdGVyVGFibGUgYW5kIA0KPj4gUHJlU21tSW5pdFJlZ2lzdGVyVGFibGUgZm9y IGFsbCBDUFVzDQo+PiAtICAvLw0KPj4gKyAgLy8NCj4+ICAgIFRhYmxlU2l6ZSA9IDIgKiBOdW1i ZXJPZkNwdXMgKiBzaXplb2YgKENQVV9SRUdJU1RFUl9UQUJMRSk7DQo+PiAgICBSZWdpc3RlclRh YmxlICA9IEFsbG9jYXRlUGFnZXMgKEVGSV9TSVpFX1RPX1BBR0VTIChUYWJsZVNpemUpKTsNCj4+ ICAgIEFTU0VSVCAoUmVnaXN0ZXJUYWJsZSAhPSBOVUxMKTsNCj4+DQo+IA0KPiBSZXZpZXdlZC1i eTogTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCg0KSSB0aGluayB5b3UgbWF5IGhh dmUgbWFkZSBhIG1pc3Rha2Ugd2hlbiBjb21taXR0aW5nIHRoaXMgcGF0Y2ggKGNvbW1pdCBlMjNk OWMzZWQ4NmMpOyB5b3UgYWRkZWQgRGFuZGFuJ3MgUi1iLCBidXQgb24gdGhlIGxpc3QsIHRoZSBv bmUgUi1iIHlvdSBnb3Qgd2FzIGZyb20gbWUsIG5vdCBEYW5kYW4uDQoNCk5vdCBhIGJpZyBpc3N1 ZSwgYnV0IGFzIGEgYmVzdCBwcmFjdGljZSBmb3IgdGhlIGZ1dHVyZSwgSSByZWNvbW1lbmQgY29w eWluZyB0aGUgZmVlZGJhY2sgdGFncyB2ZXJiYXRpbSBmcm9tIHRoZSByZXBseSBlbWFpbHMsIHVz aW5nIHRoZSBjbGlwYm9hcmQuDQoNClRoYW5rcw0KTGFzemxvDQo= --_002_ED077930C258884BBCB450DB737E66224AC998BBshsmsx102ccrcor_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Thu, 06 Sep 2018 14:03:24 GMT"; modification-date="Thu, 06 Sep 2018 14:03:24 GMT" Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Wed, 5 Sep 2018 15:29:09 +0800 From: "Bi, Dandan" To: "Dong, Eric" Subject: RE: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. Thread-Topic: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. Thread-Index: AQHUROoiby55phujRkir71kpqX15Hg== Date: Wed, 5 Sep 2018 07:29:09 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BB71DCA@shsmsx102.ccr.corp.intel.com> References: <20180905062218.13148-1-eric.dong@intel.com> In-Reply-To: <20180905062218.13148-1-eric.dong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Exchange-Organization-AuthMechanism: 04 X-MS-Exchange-Organization-AuthSource: SHSMSX103.ccr.corp.intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Dong, Eric Sent: Wednesday, September 5, 2018 2:22 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. Fix trailing white spaces and invalid line ending issue. Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 377876643f..5c562d4759 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1014,7 +1014,7 @@ WakeUpAP ( CpuData =3D &CpuMpData->CpuData[Index]; // // All AP(include disabled AP) will be woke up by INIT-SIPI-SIPI, = but - // the AP procedure will be skipped for disabled AP because AP sta= te + // the AP procedure will be skipped for disabled AP because AP + state // is not CpuStateReady. // if (GetApState (CpuData) =3D=3D CpuStateDisabled && !WakeUpDisable= dAps) { diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Libr= ary/MpInitLib/MpLib.h index 75f3fdda1d..773db76b61 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -257,7 +257,7 @@ struct _CPU_MP_DATA { // Whether need to use Init-Sipi-Sipi to wake up the APs. // Two cases need to set this value to TRUE. One is in HLT // loop mode, the other is resume from S3 which loop mode - // will be hardcode change to HLT mode by PiSmmCpuDxeSmm + // will be hardcode change to HLT mode by PiSmmCpuDxeSmm // driver. // BOOLEAN WakeUpByInitSipiSipi; diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/PeiMpInitLib.inf index 43a3b3b036..81036f0b12 100644 --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf @@ -67,4 +67,4 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## SOME= TIMES_CONSUMES [Guids] - gEdkiiS3SmmInitDoneGuid \ No newline at end of file + gEdkiiS3SmmInitDoneGuid diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesL= ib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 4143ee4bb1..fa7e107e39 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -516,7 +516,7 @@ AllocateAcpiCpuData ( // // Allocate buffer for empty RegisterTable and PreSmmInitRegisterTable f= or all CPUs - // + // TableSize =3D 2 * NumberOfCpus * sizeof (CPU_REGISTER_TABLE); RegisterTable =3D AllocatePages (EFI_SIZE_TO_PAGES (TableSize)); ASSERT (RegisterTable !=3D NULL); -- 2.16.2.windows.1 --_002_ED077930C258884BBCB450DB737E66224AC998BBshsmsx102ccrcor_--