From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel-bounces@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B3BC2194D387; Sun, 16 Sep 2018 17:30:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2018 17:30:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,383,1531810800"; d="scan'208";a="73740436" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2018 17:29:40 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 16 Sep 2018 17:29:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 16 Sep 2018 17:29:37 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Mon, 17 Sep 2018 08:29:35 +0800 From: "Dong, Eric" To: edk2-devel , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH V2 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error Thread-Index: AQHUS/pX+FX4hzaED0SyNNXD9k9cwaTzonPw Date: Mon, 17 Sep 2018 00:29:35 +0000 Message-ID: References: <20180914071153.5416-1-jian.j.wang@intel.com> In-Reply-To: <20180914071153.5416-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V2 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 00:30:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jian, After update with Laszlo's comments, This serial Reviewed-by: Eric Dong Thanks, Eric > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] > Sent: Friday, September 14, 2018 3:12 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: add > message for S3 config error >=20 > > v2 > > a. refine the error message to be more useful > > b. improve the code logic >=20 > BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1165 >=20 > HOB gEfiAcpiVariableGuid is a must have data for S3 resume if > PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't embody th= is > strong binding between them. This patch series try to fix this problem by= a > useful message. >=20 > Jian J Wang (2): > UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error > UefiCpuPkg/PiSmmCpuDxeSmm: move InitSmmS3Cr3() into else block >=20 > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel