From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B45F21148DA6 for ; Thu, 20 Sep 2018 01:01:58 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 01:01:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,397,1531810800"; d="scan'208";a="87749033" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 20 Sep 2018 01:00:43 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Sep 2018 01:00:42 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Sep 2018 01:00:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.39]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.227]) with mapi id 14.03.0319.002; Thu, 20 Sep 2018 16:00:40 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2] UefiCpuPkg: Remove redundant library classes, Ppis and GUIDs Thread-Index: AQHUT8UzidMYY5etl0+8ke+Pr458xaT40G1A Date: Thu, 20 Sep 2018 08:00:39 +0000 Message-ID: References: <20180919030214.32728-1-shenglei.zhang@intel.com> In-Reply-To: <20180919030214.32728-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] UefiCpuPkg: Remove redundant library classes, Ppis and GUIDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 08:01:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > shenglei > Sent: Wednesday, September 19, 2018 11:02 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [PATCH v2] UefiCpuPkg: Remove redundant library classes, > Ppis and GUIDs >=20 > Some redundant library classes Ppis and GUIDs > have been removed in inf, .c and .h files. >=20 > v2: > 1.Remove ReadOnlyVariable2.h in S3Resume.c which should be > deleted in last version in which gEfiPeiReadOnlyVariable2PpiGuid > was removed. > 2.Remove the library class BaseLib in CpuPageTable.c > which is included elsewhere. > 3.Add library classes in SecCore.inf which are removed > at last version. > They are DebugAgentLib and CpuExceptionHandlerLib. > 4.Add two Ppis in SecCore.inf which are removed > at last version. > They are gEfiSecPlatformInformationPpiGuid and > gEfiSecPlatformInformation2PpiGuid. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1043 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1013 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1032 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1016 >=20 > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 7 ------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 1 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 -- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 1 - > UefiCpuPkg/SecCore/FindPeiCore.c | 2 -- > UefiCpuPkg/SecCore/SecCore.inf | 4 ---- > UefiCpuPkg/SecCore/SecMain.h | 2 -- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 4 +--- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 3 --- > 9 files changed, 1 insertion(+), 25 deletions(-) >=20 > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index 0a980b9753..33e8ee2d2c 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -16,17 +16,10 @@ >=20 > #include > #include > -#include > -#include > -#include > -#include > -#include > -#include > #include > #include > #include > #include > -#include > #include > #include > #include > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index e3c7cff81c..8c7f4996d1 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -38,7 +38,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > #include > -#include > #include > #include > #include > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > index a7fb7b0b14..95a4511225 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > @@ -77,7 +77,6 @@ > [LibraryClasses] > UefiDriverEntryPoint > UefiRuntimeServicesTableLib > - CacheMaintenanceLib > PcdLib > DebugLib > BaseLib > @@ -113,7 +112,6 @@ >=20 > [Guids] > gEfiAcpiVariableGuid ## SOMETIMES_CONSUMES ## HOB = # it is > used for S3 boot. > - gEfiGlobalVariableGuid ## SOMETIMES_PRODUCES ## > Variable:L"SmmProfileData" > gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## > SystemTable > gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## > SystemTable > gEdkiiPiSmmMemoryAttributesTableGuid ## CONSUMES ## SystemTable > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h > index bacb2f8ad3..18a7fe3b07 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h > @@ -15,7 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #ifndef _SMM_PROFILE_INTERNAL_H_ > #define _SMM_PROFILE_INTERNAL_H_ >=20 > -#include > #include > #include > #include > diff --git a/UefiCpuPkg/SecCore/FindPeiCore.c > b/UefiCpuPkg/SecCore/FindPeiCore.c > index 60ccaa9667..bb9c434d1e 100644 > --- a/UefiCpuPkg/SecCore/FindPeiCore.c > +++ b/UefiCpuPkg/SecCore/FindPeiCore.c > @@ -13,8 +13,6 @@ > **/ >=20 > #include > -#include > -#include >=20 > #include "SecMain.h" >=20 > diff --git a/UefiCpuPkg/SecCore/SecCore.inf > b/UefiCpuPkg/SecCore/SecCore.inf > index 7bcd4f8a96..b228610757 100644 > --- a/UefiCpuPkg/SecCore/SecCore.inf > +++ b/UefiCpuPkg/SecCore/SecCore.inf > @@ -50,7 +50,6 @@ > [LibraryClasses] > BaseMemoryLib > DebugLib > - BaseLib > PlatformSecLib > PcdLib > DebugAgentLib > @@ -71,9 +70,6 @@ > ## SOMETIMES_PRODUCES > gEfiSecPlatformInformation2PpiGuid > gEfiTemporaryRamDonePpiGuid ## PRODUCES > - ## NOTIFY > - ## SOMETIMES_CONSUMES > - gPeiSecPerformancePpiGuid >=20 > [Guids] > ## SOMETIMES_PRODUCES ## HOB > diff --git a/UefiCpuPkg/SecCore/SecMain.h > b/UefiCpuPkg/SecCore/SecMain.h > index 4bc6606044..83244af119 100644 > --- a/UefiCpuPkg/SecCore/SecMain.h > +++ b/UefiCpuPkg/SecCore/SecMain.h > @@ -17,14 +17,12 @@ >=20 > #include >=20 > -#include > #include > #include > #include >=20 > #include >=20 > -#include > #include > #include > #include > diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > index 28e53ac5d3..f164c1713b 100644 > --- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > +++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -34,7 +33,6 @@ >=20 > #include > #include > -#include > #include > #include > #include > @@ -47,7 +45,7 @@ > #include > #include > #include > -#include > + > #include > #include > #include > diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > index 407aab6735..6ce1bf944c 100644 > --- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > +++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > @@ -53,7 +53,6 @@ > HobLib > PeiServicesLib > PeimEntryPoint > - TimerLib > BaseLib > DebugLib > PcdLib > @@ -64,7 +63,6 @@ > LocalApicLib > ReportStatusCodeLib > LockBoxLib > - PrintLib >=20 > [Guids] > gEfiBootScriptExecutorVariableGuid ## SOMETIMES_CONSUMES ## > UNDEFINED # LockBox > @@ -79,7 +77,6 @@ > gEdkiiS3SmmInitDoneGuid >=20 > [Ppis] > - gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES > gEfiPeiS3Resume2PpiGuid ## PRODUCES > gPeiSmmAccessPpiGuid ## SOMETIMES_CONSUMES > gPeiPostScriptTablePpiGuid ## SOMETIMES_PRODUCES > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel