Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.

["Dong, Eric" <eric.dong@intel.com>]

Hi Leif,

Got it. Will follow this rule when met similar case next time, Thanks.

Thanks,
Eric

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, October 29, 2018 7:34 PM
> To: Dong, Eric <eric.dong@intel.com>
> Cc: edk2-devel@lists.01.org; Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC
> build failure.
> 
> Hi Eric,
> 
> This has already been pushed, but for future similar fixes, please add a
> commit message specifying:
> - What failed.
> - Why it failed.
> - For which targets.
> - Versions of toolchain where the failure has been observed. (This
>   does not need to be exhaustive, just mention where the failure has
>   been seen.)
> 
> Best Regards,
> 
> Leif
> 
> On Sat, Oct 27, 2018 at 05:09:21PM +0800, Eric Dong wrote:
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Eric Dong <eric.dong@intel.com>
> > ---
> >  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h    | 2
> +-
> >  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c |
> > 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> > index b5fe8fbce1..b4c8ab777e 100644
> > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> > @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE
> DetectFeatureScope (
> >    IN CPU_FEATURES_ENTRY         *CpuFeature,
> >    IN BOOLEAN                    Before,
> > -  IN CHAR8                      *NextCpuFeatureMask
> > +  IN UINT8                      *NextCpuFeatureMask
> >    );
> >
> >  /**
> > diff --git
> > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> > index 9a66bc49ff..394695baf2 100644
> > ---
> > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> > +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib
> > +++ .c
> > @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE
> DetectFeatureScope (
> >    IN CPU_FEATURES_ENTRY         *CpuFeature,
> >    IN BOOLEAN                    Before,
> > -  IN CHAR8                      *NextCpuFeatureMask
> > +  IN UINT8                      *NextCpuFeatureMask
> >    )
> >  {
> >    //
> > --
> > 2.16.2.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel