From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 00E0421A07A80 for ; Mon, 29 Oct 2018 16:40:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 16:40:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,442,1534834800"; d="scan'208";a="96083785" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2018 16:40:40 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 16:40:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 16:40:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Tue, 30 Oct 2018 07:40:37 +0800 From: "Dong, Eric" To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "Bi, Dandan" , "Gao, Liming" Thread-Topic: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. Thread-Index: AQHUbdTI9QsIkh3U1ke4Eo29kqJcEqU1lNeAgAFQ1jA= Date: Mon, 29 Oct 2018 23:40:36 +0000 Message-ID: References: <20181027090921.6180-1-eric.dong@intel.com> <20181029113409.37vsenofcpiifynb@bivouac.eciton.net> In-Reply-To: <20181029113409.37vsenofcpiifynb@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 23:40:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Got it. Will follow this rule when met similar case next time, Thanks. Thanks, Eric > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Monday, October 29, 2018 7:34 PM > To: Dong, Eric > Cc: edk2-devel@lists.01.org; Bi, Dandan ; Gao, Limin= g > > Subject: Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC > build failure. >=20 > Hi Eric, >=20 > This has already been pushed, but for future similar fixes, please add a > commit message specifying: > - What failed. > - Why it failed. > - For which targets. > - Versions of toolchain where the failure has been observed. (This > does not need to be exhaustive, just mention where the failure has > been seen.) >=20 > Best Regards, >=20 > Leif >=20 > On Sat, Oct 27, 2018 at 05:09:21PM +0800, Eric Dong wrote: > > Cc: Liming Gao > > Cc: Dandan Bi > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Eric Dong > > --- > > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 > +- > > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | > > 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > index b5fe8fbce1..b4c8ab777e 100644 > > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > > IN CPU_FEATURES_ENTRY *CpuFeature, > > IN BOOLEAN Before, > > - IN CHAR8 *NextCpuFeatureMask > > + IN UINT8 *NextCpuFeatureMask > > ); > > > > /** > > diff --git > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > index 9a66bc49ff..394695baf2 100644 > > --- > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > +++ > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib > > +++ .c > > @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > > IN CPU_FEATURES_ENTRY *CpuFeature, > > IN BOOLEAN Before, > > - IN CHAR8 *NextCpuFeatureMask > > + IN UINT8 *NextCpuFeatureMask > > ) > > { > > // > > -- > > 2.16.2.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel