public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information
Date: Mon, 11 Mar 2019 01:15:38 +0000	[thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259DD5A01@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190311005516.2864-4-shenglei.zhang@intel.com>

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, March 11, 2019 8:55 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help
> information
> 
> The prompt and help information are missing in UefiPkg.uni.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1600
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.uni | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
> b132ce62cf..0e57b6ac98 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -114,6 +114,10 @@
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP
> #language en-US "Specifies stack size in bytes for each processor in SMM."
> 
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT
> #language en-US "Processor stack size in SMM."
> +
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help
> #language en-US "Specifies stack size in bytes for each processor in SMM."
> +
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT
> #language en-US "AP synchronization timeout value in SMM"
> 
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP
> #language en-US "Specifies timeout value in microseconds for the BSP in
> SMM to wait for all APs to come into SMM."
> --
> 2.18.0.windows.1



  reply	other threads:[~2019-03-11  1:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11  0:55 [PATCH 0/3] Add the prompt and help information in .uni files Shenglei Zhang
2019-03-11  0:55 ` [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information Shenglei Zhang
2019-03-11  1:48   ` Yao, Jiewen
2019-03-11  2:41     ` Zhang, Shenglei
2019-03-11  0:55 ` [PATCH 2/3] SecurityPkg/SecurityPkg.uni: " Shenglei Zhang
2019-03-11  0:55 ` [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: " Shenglei Zhang
2019-03-11  1:15   ` Dong, Eric [this message]
2019-03-12 14:18     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED077930C258884BBCB450DB737E662259DD5A01@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox