From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 68618211E2BF4 for ; Wed, 20 Mar 2019 17:56:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 17:56:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,250,1549958400"; d="scan'208";a="156879215" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2019 17:56:16 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 17:56:15 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 17:56:15 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.158]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 08:56:13 +0800 From: "Dong, Eric" To: "Vanguput, Narendra K" , Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Chinnusamy, Rajkumar K" , "Ni, Ray" Thread-Topic: [edk2] [PATCH v4] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM Thread-Index: AQHU3ZhIwsMTuIt4X0Sxw5eYWbZeP6YUM2SAgAAPvYCAAQK3AA== Date: Thu, 21 Mar 2019 00:56:12 +0000 Message-ID: References: <20190318143825.17352-1-narendra.k.vanguput@intel.com> <020B34E8430BB544AB9E0330B597780A664DCD0C@BGSMSX102.gar.corp.intel.com> In-Reply-To: <020B34E8430BB544AB9E0330B597780A664DCD0C@BGSMSX102.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 00:56:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTmFyZW4sDQoNCkkgYWdyZWUgd2l0aCBMYXN6bG8ncyBjb21tZW50IGZvciAjMS4gSSB0aGlu ayBzZXBhcmF0ZSBmdW5jdGlvbnMgZm9yIElBMzIvWDY0IGFyZSBtdWNoIGNsZWFyIHRoYW4gdGhl IGN1cnJlbnQgb25lLiBJIHRoaW5rIGluIGN1cnJlbnQgRURLMiBjb2RlYmFzZSwgbWFueSBzaW1p bGFyIGNhc2VzIGFscmVhZHkgZXhpdHMuDQoNClRoYW5rcywNCkVyaWMNCg0KPiAtLS0tLU9yaWdp bmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBWYW5ndXB1dCwgTmFyZW5kcmEgSw0KPiBTZW50OiBU aHVyc2RheSwgTWFyY2ggMjEsIDIwMTkgMToyOCBBTQ0KPiBUbzogTGFzemxvIEVyc2VrIDxsZXJz ZWtAcmVkaGF0LmNvbT47IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnDQo+IENjOiBZYW8sIEppZXdl biA8amlld2VuLnlhb0BpbnRlbC5jb20+OyBEb25nLCBFcmljIDxlcmljLmRvbmdAaW50ZWwuY29t PjsNCj4gQ2hpbm51c2FteSwgUmFqa3VtYXIgSyA8cmFqa3VtYXIuay5jaGlubnVzYW15QGludGVs LmNvbT47IE5pLCBSYXkNCj4gPHJheS5uaUBpbnRlbC5jb20+DQo+IFN1YmplY3Q6IFJFOiBbZWRr Ml0gW1BBVENIIHY0XSBVZWZpQ3B1UGtnXENwdVNtbTogU2F2ZSAmIHJlc3RvcmUgQ1IyIG9uLQ0K PiBkZW1hbmQgcGFnaW5nIGluIFNNTQ0KPiANCj4gSGkgTGFzemxvLA0KPiANCj4gVGhhbmtzIGZv ciB5b3VyIGNvbW1lbnRzLg0KPiANCj4gRm9yIHlvdXIgY29tbWVudCAjMSwgTXkgdGhvdWdodHMg YXJlIHdoZW4gd2UgYWRkIHR3byBmdW5jdGlvbnMgKFNhdmVDcjINCj4gJiBSZXN0b3JlQ3IyKS4g Rm9yIElBMzIsIGl0IGFjdHVhbGx5IGRvbid0IHNhdmUgYW5kIHJlc3RvcmUsIHNpbXBseSByZXR1 cm5zLg0KPiBMYXRlciwgaXQgbWlnaHQgYmUgY29uZnVzaW5nIHVubGVzcyBpZiB3ZSBrbm93IHRo ZSBiYWNrZ3JvdW5kIGFuZCBnb25lDQo+IHRocm91Z2ggNjQgYml0IHN1cHBvcnRlZCBjb2RlLiBB bmQgYWxzbyBpdHMga2luZCBvZiBhZGRpbmcgbW9yZSBjb2RlIHdoaWxlDQo+IHdlIGhhdmUgYWx0 ZXJuYXRlIHNvbHV0aW9uLg0KPiBJbiB0aGUgcHJvcG9zZWQgY2hhbmdlcywgSSBmZWx0IGl0cyBz dHJhaWdodCBmb3J3YXJkIGFuZCBsaWdodCBjaGFuZ2VzIG5lZWRlZC4NCj4gWWVzLCBJIHdvdWxk IGxpa2UgdG8gaGVhciBmcm9tIG90aGVyIHJldmlld2VycyB0b28gdG8gdGFrZSB0aGUgcmlnaHQg b3B0aW9uLg0KPiANCj4gRm9yIGNvbW1lbnRzICMyICYgIzQsIFllcywgSSBub3RpZmllZCBpdCwg d2FpdGluZyB0byB1cGRhdGUgYWxvbmcgd2l0aCBvdGhlcg0KPiBjb21tZW50cy4NCj4gDQo+IEZv ciBjb21tZW50cyAjMyAmICM1LCB3aWxsIGNvbnNpZGVyIHRoZW0uIFdpbGwgYWRqdXN0IHRoZSBu by4gY2hhcmFjdGVycyBhbmQNCj4gd2lsbCBtb3ZlIGV4dGVybiBvZiBtQ3B1U21tU3RhdGljUGFn ZVRhYmxlIHRvIFBpU21tQ3B1RHhlU21tLmggZmlsZS4NCj4gDQo+IFRoYW5rcywNCj4gTmFyZW4N Cj4gDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IExhc3psbyBFcnNlayBb bWFpbHRvOmxlcnNla0ByZWRoYXQuY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIE1hcmNoIDIwLCAy MDE5IDEwOjAxIFBNDQo+IFRvOiBWYW5ndXB1dCwgTmFyZW5kcmEgSyA8bmFyZW5kcmEuay52YW5n dXB1dEBpbnRlbC5jb20+OyBlZGsyLQ0KPiBkZXZlbEBsaXN0cy4wMS5vcmcNCj4gQ2M6IFlhbywg Smlld2VuIDxqaWV3ZW4ueWFvQGludGVsLmNvbT47IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRl bC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbZWRrMl0gW1BBVENIIHY0XSBVZWZpQ3B1UGtnXENwdVNt bTogU2F2ZSAmIHJlc3RvcmUgQ1IyIG9uLQ0KPiBkZW1hbmQgcGFnaW5nIGluIFNNTQ0KPiANCj4g T24gMDMvMTgvMTkgMTU6MzgsIG5rdmFuZ3VwIHdyb3RlOg0KPiA+IEJaOiBodHRwczovL2J1Z3pp bGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTMNCj4gPg0KPiA+IEZvciBldmVy eSBTTUkgb2NjdXJyZW5jZSwgc2F2ZSBhbmQgcmVzdG9yZSBDUjIgcmVnaXN0ZXIgb25seSB3aGVu IFNNTQ0KPiA+IG9uLWRlbWFuZCBwYWdpbmcgc3VwcG9ydCBpcyBlbmFibGVkIGluIDY0IGJpdCBv cGVyYXRpb24gbW9kZS4NCj4gPg0KPiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29u dHJpYnV0aW9uIEFncmVlbWVudCAxLjENCj4gPiBTaWduZWQtb2ZmLWJ5OiBWYW5ndXB1dCBOYXJl bmRyYSBLIDxuYXJlbmRyYS5rLnZhbmd1cHV0QGludGVsLmNvbT4NCj4gPiBDYzogRXJpYyBEb25n IDxlcmljLmRvbmdAaW50ZWwuY29tPg0KPiA+IENjOiBSYXkgTmkgPHJheS5uaUBpbnRlbC5jb20+ DQo+ID4gQ2M6IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+DQo+ID4gQ2M6IFlhbyBK aWV3ZW4gPGppZXdlbi55YW9AaW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+ICBVZWZpQ3B1UGtnL1Bp U21tQ3B1RHhlU21tL01wU2VydmljZS5jICAgfCAyMiArKysrKysrKysrKysrKy0tLS0tDQo+IC0t LQ0KPiA+ICBVZWZpQ3B1UGtnL1BpU21tQ3B1RHhlU21tL1g2NC9QYWdlVGJsLmMgfCAgMiArLQ0K PiA+ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pDQo+ ID4NCj4gPiBkaWZmIC0tZ2l0IGEvVWVmaUNwdVBrZy9QaVNtbUNwdUR4ZVNtbS9NcFNlcnZpY2Uu Yw0KPiA+IGIvVWVmaUNwdVBrZy9QaVNtbUNwdUR4ZVNtbS9NcFNlcnZpY2UuYw0KPiA+IGluZGV4 IDNiMGIzYjUyYWMuLjBjMDdiMzFjNGYgMTAwNjQ0DQo+ID4gLS0tIGEvVWVmaUNwdVBrZy9QaVNt bUNwdUR4ZVNtbS9NcFNlcnZpY2UuYw0KPiA+ICsrKyBiL1VlZmlDcHVQa2cvUGlTbW1DcHVEeGVT bW0vTXBTZXJ2aWNlLmMNCj4gPiBAQCAtMjgsNiArMjgsNyBAQCBVSU5UTiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG1TZW1hcGhvcmVTaXplOw0KPiA+ICBTUElOX0xPQ0sg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICptUEZMb2NrID0gTlVMTDsNCj4gPiAg U01NX0NQVV9TWU5DX01PREUgICAgICAgICAgICAgICAgICAgICAgICAgICBtQ3B1U21tU3luY01v ZGU7DQo+ID4gIEJPT0xFQU4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbU1h Y2hpbmVDaGVja1N1cHBvcnRlZCA9IEZBTFNFOw0KPiA+ICtCT09MRUFOICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1DcHVTbW1TdGF0aWNQYWdlVGFibGUgPSBUUlVFOw0KPiAN Cj4gSG1tbS4gVGhpcyBjaGFuZ2UgaXMgYSBiaXQgZGFyaW5nLCBidXQgSSB0aGluayBpdCBjb3Vs ZCBiZSB2YWxpZC4NCj4gDQo+IC0gSW4gdGhlIElBMzIgYnVpbGQsIG1DcHVTbW1TdGF0aWNQYWdl VGFibGUgd291bGQgbmV2ZXIgYmUgbW9kaWZpZWQsIG9yDQo+IHJlYWQsIGJ5ICpwcmVleGlzdGVu dCogY29kZSAoYmVjYXVzZSBhbGwgdGhhdCBjb2RlIGlzIGluIFg2NC9QYWdlVGJsLmMpLg0KPiBB bmQgdGhlIG5ldyBjb2RlLCBhZGRlZCBieSB0aGlzIHBhdGNoLCB3b3VsZCAocHJlc3VtYWJseSkg d29yayBmaW5lLCB3aXRoDQo+IHRoZSBpbml0aWFsIFRSVUUgdmFsdWUuDQo+IA0KPiAtIEluIHRo ZSBYNjQgYnVpbGQsIHRoZSBwcmVleGlzdGVudCBjb2RlIHdvdWxkIG5ldmVyIHJlYWQgdGhlIGlu aXRpYWwgdmFsdWUNCj4gKHdoaWNoIHdlIG5vdyBzZXQgdG8gVFJVRSBoZXJlKSwgaS5lLiBiZWZv cmUgb3ZlcndyaXRpbmcgdGhlIHZhcmlhYmxlIGZyb20NCj4gdGhlIFBDRCAtLSBiZWNhdXNlIHRo YXQgd291bGQgbWVhbiBhIGJ1ZyBpbiB0aGUgcHJlZXhpc3RlbnQgY29kZS4gKFdlbGwsDQo+IHVu bGVzcyB0aGF0IGNvZGUgcmVsaWVkIG9uIHRoZSB6ZXJvIGluaXRpYWwgdmFsdWUgb2YgdGhlIHZh cmlhYmxlKS4NCj4gDQo+ICgxKSBJIHRoaW5rIEknZCBsaWtlIHRvIGRlZmVyIG9uIHRoaXMgdG8g b3RoZXIgVWVmaUNwdVBrZyByZXZpZXdlcnMuDQo+IEhvbmVzdGx5IEkgZmluZCB0aGlzIHN0eWxl IHF1ZXN0aW9uYWJsZS4gSXQgbWFrZXMgbWUgZmVlbCB1bmNvbWZvcnRhYmxlLg0KPiBJJ2QgcHJl ZmVyIHRoZSBuZXcgQVBJcyB3aXRoIHRoZSBzZXBhcmF0ZSBJQTMyL1g2NCBpbXBsZW1lbnRhdGlv bnMgdGhhdCBJDQo+IHN1Z2dlc3RlZCBpbiBteSB2MiByZXZpZXcuIEJ1dCBpZiBvdGhlciByZXZp ZXdlcnMgbGlrZSB0aGlzIG9uZSBiZXR0ZXIsIEkgd29uJ3QNCj4gbWluZC4NCj4gDQo+IChBZnRl ciBoZWFyaW5nIHRoZWlyIG9waW5pb25zLCBJJ2QgYXR0ZW1wdCB0byBmaW5kIHRoZSB0aW1lIHRv IHJlZ3Jlc3Npb24gdGVzdA0KPiB0aGUgcGF0Y2ggKG9yIG1heWJlIHY1KSwgdG9vLikNCj4gDQo+ IEFzc3VtaW5nIG90aGVyIHJldmlld2VycyBwcmVmZXIgdGhpcyBhcHByb2FjaCBvdmVyIG15IHN1 Z2dlc3Rpb24sIEkgaGF2ZQ0KPiBzb21lIG90aGVyIGNvbW1lbnRzOg0KPiANCj4gPg0KPiA+ICAv KioNCj4gPiAgICBQZXJmb3JtcyBhbiBhdG9taWMgY29tcGFyZSBleGNoYW5nZSBvcGVyYXRpb24g dG8gZ2V0IHNlbWFwaG9yZS4NCj4gPiBAQCAtMTExMSwxMCArMTExMiwxMyBAQCBTbWlSZW5kZXp2 b3VzICgNCj4gPg0KPiA+ICAgIEFTU0VSVChDcHVJbmRleCA8IG1NYXhOdW1iZXJPZkNwdXMpOw0K PiA+DQo+ID4gLSAgLy8NCj4gPiAtICAvLyBTYXZlIENyMiBiZWNhdXNlIFBhZ2UgRmF1bHQgZXhj ZXB0aW9uIGluIFNNTSBtYXkgb3ZlcnJpZGUgaXRzDQo+ID4gdmFsdWUNCj4gPiAtICAvLw0KPiA+ IC0gIENyMiA9IEFzbVJlYWRDcjIgKCk7DQo+ID4gKyAgICBpZiAoIW1DcHVTbW1TdGF0aWNQYWdl VGFibGUpIHsNCj4gPiArICAgIC8vDQo+ID4gKyAgICAvLyBTYXZlIGFuZCByZXN0b3JlIENyMiB3 aGVuIHVzaW5nIG9uLWRlbWFuZCBwYWdpbmcgZm9yIGFib3ZlIDRHDQo+IG1lbW9yeSBiZWNhdXNl IFBhZ2UgRmF1bHQNCj4gPiArICAgIC8vIGV4Y2VwdGlvbiBpbiBTTU0gbWF5IG92ZXJyaWRlIGl0 cyB2YWx1ZQ0KPiA+ICsgICAgLy8NCj4gPiArICAgIENyMiA9IEFzbVJlYWRDcjIgKCk7DQo+ID4g KyAgfQ0KPiANCj4gKDIpIFRoZSBpbmRlbnRhdGlvbiBvZiB0aGUgImlmIiBpcyBicm9rZW4uDQo+ IA0KPiAoMykgR2l2ZW4gdGhhdCB3ZSdyZSBhbHJlYWR5IHVzaW5nIHR3byBjb21tZW50IGxpbmVz LCBJJ2Qgc3VnZ2VzdCBub3QNCj4gZXhjZWVkaW5nIDgwIGNoYXJhY3RlcnMgcGVyIGxpbmUuDQo+ IA0KPiA+DQo+ID4gICAgLy8NCj4gPiAgICAvLyBQZXJmb3JtIENQVSBzcGVjaWZpYyBlbnRyeSBo b29rcyBAQCAtMTI1MywxMCArMTI1NywxMiBAQA0KPiA+IFNtaVJlbmRlenZvdXMgKA0KPiA+DQo+ ID4gIEV4aXQ6DQo+ID4gICAgU21tQ3B1RmVhdHVyZXNSZW5kZXp2b3VzRXhpdCAoQ3B1SW5kZXgp Ow0KPiA+IC0gIC8vDQo+ID4gLSAgLy8gUmVzdG9yZSBDcjINCj4gPiAtICAvLw0KPiA+IC0gIEFz bVdyaXRlQ3IyIChDcjIpOw0KPiA+ICsgICAgaWYgKCFtQ3B1U21tU3RhdGljUGFnZVRhYmxlKSB7 DQo+IA0KPiAoNCkgc2FtZSBhcyAoMikuDQo+IA0KPiA+ICsgICAgLy8NCj4gPiArICAgIC8vIFJl c3RvcmUgQ3IyDQo+ID4gKyAgICAvLw0KPiA+ICsgICAgQXNtV3JpdGVDcjIgKENyMik7DQo+ID4g KyAgfQ0KPiA+ICB9DQo+ID4NCj4gPiAgLyoqDQo+ID4gZGlmZiAtLWdpdCBhL1VlZmlDcHVQa2cv UGlTbW1DcHVEeGVTbW0vWDY0L1BhZ2VUYmwuYw0KPiA+IGIvVWVmaUNwdVBrZy9QaVNtbUNwdUR4 ZVNtbS9YNjQvUGFnZVRibC5jDQo+ID4gaW5kZXggMmM3N2NiNDdhNC4uZTQ0NGI4YTAzMSAxMDA2 NDQNCj4gPiAtLS0gYS9VZWZpQ3B1UGtnL1BpU21tQ3B1RHhlU21tL1g2NC9QYWdlVGJsLmMNCj4g PiArKysgYi9VZWZpQ3B1UGtnL1BpU21tQ3B1RHhlU21tL1g2NC9QYWdlVGJsLmMNCj4gPiBAQCAt MjEsNyArMjEsNyBAQCBXSVRIT1VUIFdBUlJBTlRJRVMgT1IgUkVQUkVTRU5UQVRJT05TIE9GDQo+ IEFOWSBLSU5ELCBFSVRIRVIgRVhQUkVTUyBPUiBJTVBMSUVELg0KPiA+DQo+ID4gIExJU1RfRU5U UlkgICAgICAgICAgICAgICAgICAgICAgICAgIG1QYWdlUG9vbCA9IElOSVRJQUxJWkVfTElTVF9I RUFEX1ZBUklBQkxFDQo+IChtUGFnZVBvb2wpOw0KPiA+ICBCT09MRUFOICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBtMUdQYWdlVGFibGVTdXBwb3J0ID0gRkFMU0U7DQo+ID4gLUJPT0xFQU4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1DcHVTbW1TdGF0aWNQYWdlVGFibGU7DQo+ID4g K2V4dGVybiBCT09MRUFOICAgICAgICAgICAgICAgICAgICAgIG1DcHVTbW1TdGF0aWNQYWdlVGFi bGU7DQo+IA0KPiAoNSkgVGhpcyBpcyBnZW5lcmFsbHkgbm90IGdyZWF0IHN0eWxlLCBhbmQgaXQg Y29uZmxpY3RzIHdpdGggdGhlIGV4aXN0ZW50IGNvZGUgb2YNCj4gdGhpcyBkcml2ZXIuIE5hbWVs eSwgZGVjbGFyYXRpb25zIG9mIHZhcmlhYmxlcyB3aXRoIGZpbGUgc2NvcGUsIHN0YXRpYyBzdG9y YWdlDQo+IGR1cmF0aW9uLCBhbmQgZXh0ZXJuYWwgbGlua2FnZSwgc2hvdWxkIGdvIGludG8gIlBp U21tQ3B1RHhlU21tLmgiLS0gd2UNCj4gYWxyZWFkeSBnb3QgYSBidW5jaCBvZiB0aGVtIHRoZXJl Lg0KPiANCj4gVGhhbmtzDQo+IExhc3psbw0KPiANCj4gPg0KPiA+ICAvKioNCj4gPiAgICBEaXNh YmxlIENFVC4NCj4gPg0KDQo=