From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A57AB21959CB2 for ; Wed, 20 Mar 2019 23:59:00 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 23:59:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,251,1549958400"; d="scan'208";a="153730130" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 20 Mar 2019 23:59:00 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 23:58:59 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 23:58:58 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 14:58:55 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [edk2] [PATCH v2 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch Thread-Index: AQHU3iFZmcxM2ZDF80CnlwYFCl8UmqYVqr4Q Date: Thu, 21 Mar 2019 06:58:54 +0000 Message-ID: References: <20190319065918.13356-1-shenglei.zhang@intel.com> <20190319065918.13356-3-shenglei.zhang@intel.com> In-Reply-To: <20190319065918.13356-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 06:59:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Tuesday, March 19, 2019 2:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v2 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S > files for IA32 and X64 arch >=20 > .nasm file has been added for X86 arch. .S assembly code is not required = any > more. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1594 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 2 - > .../BaseUefiCpuLib/Ia32/InitializeFpu.S | 73 ------------------- > .../BaseUefiCpuLib/X64/InitializeFpu.S | 57 --------------- > 3 files changed, 132 deletions(-) > delete mode 100644 > UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.S > delete mode 100644 UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.S >=20 > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > index 5614452a88..2e9756e50e 100644 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > @@ -31,11 +31,9 @@ >=20 > [Sources.IA32] > Ia32/InitializeFpu.nasm > - Ia32/InitializeFpu.S >=20 > [Sources.X64] > X64/InitializeFpu.nasm > - X64/InitializeFpu.S >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.S > b/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.S > deleted file mode 100644 > index 0a1a9198f6..0000000000 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.S > +++ /dev/null > @@ -1,73 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -#* > -#* Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<= BR> > -#* This program and the accompanying materials > -#* are licensed and made available under the terms and conditions of t= he > BSD License > -#* which accompanies this distribution. The full text of the license = may be > found at > -#* http://opensource.org/licenses/bsd-license.php > -#* > -#* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -#* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -#* > -#* > -#-----------------------------------------------------------------------= ------- > - > -# > -# Float control word initial value: > -# all exceptions masked, double-precision, round-to-nearest -# > -ASM_PFX(mFpuControlWord): .word 0x027F > -# > -# Multimedia-extensions control word: > -# all exceptions masked, round-to-nearest, flush to zero for masked > underflow -# > -ASM_PFX(mMmxControlWord): .long 0x01F80 > - > -# > -# Initializes floating point units for requirement of UEFI specification= . > -# > -# This function initializes floating-point control word to 0x027F (all > exceptions -# masked,double-precision, round-to-nearest) and multimedia- > extensions control word -# (if supported) to 0x1F80 (all exceptions maske= d, > round-to-nearest, flush to zero -# for masked underflow). > -# > -ASM_GLOBAL ASM_PFX(InitializeFloatingPointUnits) > -ASM_PFX(InitializeFloatingPointUnits): > - > - pushl %ebx > - > - # > - # Initialize floating point units > - # > - finit > - fldcw ASM_PFX(mFpuControlWord) > - > - # > - # Use CpuId instructuion (CPUID.01H:EDX.SSE[bit 25] =3D 1) to test > - # whether the processor supports SSE instruction. > - # > - movl $1, %eax > - cpuid > - btl $25, %edx > - jnc Done > - > - # > - # Set OSFXSR bit 9 in CR4 > - # > - movl %cr4, %eax > - or $0x200, %eax > - movl %eax, %cr4 > - > - # > - # The processor should support SSE instruction and we can use > - # ldmxcsr instruction > - # > - ldmxcsr ASM_PFX(mMmxControlWord) > - > -Done: > - popl %ebx > - > - ret > - > -#END > - > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.S > b/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.S > deleted file mode 100644 > index f0b0d3e264..0000000000 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.S > +++ /dev/null > @@ -1,57 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -#* > -#* Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<= BR> > -#* This program and the accompanying materials > -#* are licensed and made available under the terms and conditions of t= he > BSD License > -#* which accompanies this distribution. The full text of the license = may be > found at > -#* http://opensource.org/licenses/bsd-license.php > -#* > -#* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -#* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -#* > -#* > -#-----------------------------------------------------------------------= ------- > - > -# > -# Initializes floating point units for requirement of UEFI specification= . > -# > -# This function initializes floating-point control word to 0x037F (all > exceptions -# masked,double-extended-precision, round-to-nearest) and > multimedia-extensions control word -# (if supported) to 0x1F80 (all > exceptions masked, round-to-nearest, flush to zero -# for masked > underflow). > -# > -ASM_GLOBAL ASM_PFX(InitializeFloatingPointUnits) > -ASM_PFX(InitializeFloatingPointUnits): > - > - # > - # Initialize floating point units > - # > - finit > - > - # > - # Float control word initial value: > - # all exceptions masked, double-precision, round-to-nearest > - # > - pushq $0x037F > - lea (%rsp), %rax > - fldcw (%rax) > - popq %rax > - > - # > - # Set OSFXSR bit 9 in CR4 > - # > - movq %cr4, %rax > - or $0x200, %rax > - movq %rax, %cr4 > - > - # > - # Multimedia-extensions control word: > - # all exceptions masked, round-to-nearest, flush to zero for masked > underflow > - # > - pushq $0x01F80 > - lea (%rsp), %rax > - ldmxcsr (%rax) > - popq %rax > - > - ret > - > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel