From: "Dong, Eric" <eric.dong@intel.com>
To: Joe Richey <joerichey@google.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 2/3] UefiCpuPkg: Remove double \r
Date: Mon, 13 May 2019 00:47:28 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259E26278@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190510080657.252121-1-joerichey@google.com>
Hi Joe,
Reviewed-by: Eric Dong <eric.dong@intel.com>
And pushed:
SHA-1: e2aaec4b080c3480d62a259e42d792c92c4a0f1b
* UefiCpuPkg: Remove double \r
These files have \r\n line endings, but a few lines use \r\r\n which
is not a valid line ending. These lines were causing problems for git
and other tools.
Signed-off-by: Joe Richey <joerichey@google.com>
Review-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Thanks,
Eric
> -----Original Message-----
> From: Joe Richey [mailto:joerichey@google.com]
> Sent: Friday, May 10, 2019 4:07 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Joe Richey <joerichey@google.com>
> Subject: [PATCH 2/3] UefiCpuPkg: Remove double \r
>
> These files have \r\n line endings, but a few lines use \r\r\n which is not a
> valid line ending. These lines were causing problems for git and other tools.
>
> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
> UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> index 32cd63ede0..906ed65408 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> @@ -68,7 +68,7 @@ LimitCpuidMaxvalInitialize (
> // The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is
> core for below
> // processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in
> each core.
> //
> - if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>
> + if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily,
> + CpuInfo->DisplayModel) ||
> IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)
> ||
> --
> 2.21.0.1020.gf2820cf01a-goog
prev parent reply other threads:[~2019-05-13 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 8:06 [PATCH 2/3] UefiCpuPkg: Remove double \r Joe Richey
2019-05-10 10:12 ` Ni, Ray
2019-05-13 0:47 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259E26278@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox