* [PATCH 2/3] UefiCpuPkg: Remove double \r
@ 2019-05-10 8:06 Joe Richey
2019-05-10 10:12 ` Ni, Ray
2019-05-13 0:47 ` Dong, Eric
0 siblings, 2 replies; 3+ messages in thread
From: Joe Richey @ 2019-05-10 8:06 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek, Joe Richey
These files have \r\n line endings, but a few lines use \r\r\n which
is not a valid line ending. These lines were causing problems for git
and other tools.
Signed-off-by: Joe Richey <joerichey@google.com>
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
index 32cd63ede0..906ed65408 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
@@ -68,7 +68,7 @@ LimitCpuidMaxvalInitialize (
// The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is core for below
// processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in each core.
//
- if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||
+ if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||
IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||
IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||
IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||
--
2.21.0.1020.gf2820cf01a-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] UefiCpuPkg: Remove double \r
2019-05-10 8:06 [PATCH 2/3] UefiCpuPkg: Remove double \r Joe Richey
@ 2019-05-10 10:12 ` Ni, Ray
2019-05-13 0:47 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2019-05-10 10:12 UTC (permalink / raw)
To: 'Joe Richey', devel@edk2.groups.io; +Cc: Dong, Eric, Laszlo Ersek
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Joe Richey <joerichey@google.com>
> Sent: Friday, May 10, 2019 4:07 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Joe Richey <joerichey@google.com>
> Subject: [PATCH 2/3] UefiCpuPkg: Remove double \r
>
> These files have \r\n line endings, but a few lines use \r\r\n which
> is not a valid line ending. These lines were causing problems for git
> and other tools.
>
> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
> UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> index 32cd63ede0..906ed65408 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> @@ -68,7 +68,7 @@ LimitCpuidMaxvalInitialize (
> // The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is
> core for below
> // processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in
> each core.
> //
> - if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>
> + if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)
> ||
> --
> 2.21.0.1020.gf2820cf01a-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] UefiCpuPkg: Remove double \r
2019-05-10 8:06 [PATCH 2/3] UefiCpuPkg: Remove double \r Joe Richey
2019-05-10 10:12 ` Ni, Ray
@ 2019-05-13 0:47 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Dong, Eric @ 2019-05-13 0:47 UTC (permalink / raw)
To: Joe Richey, devel@edk2.groups.io; +Cc: Ni, Ray, Laszlo Ersek
Hi Joe,
Reviewed-by: Eric Dong <eric.dong@intel.com>
And pushed:
SHA-1: e2aaec4b080c3480d62a259e42d792c92c4a0f1b
* UefiCpuPkg: Remove double \r
These files have \r\n line endings, but a few lines use \r\r\n which
is not a valid line ending. These lines were causing problems for git
and other tools.
Signed-off-by: Joe Richey <joerichey@google.com>
Review-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Thanks,
Eric
> -----Original Message-----
> From: Joe Richey [mailto:joerichey@google.com]
> Sent: Friday, May 10, 2019 4:07 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Joe Richey <joerichey@google.com>
> Subject: [PATCH 2/3] UefiCpuPkg: Remove double \r
>
> These files have \r\n line endings, but a few lines use \r\r\n which is not a
> valid line ending. These lines were causing problems for git and other tools.
>
> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
> UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> index 32cd63ede0..906ed65408 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> @@ -68,7 +68,7 @@ LimitCpuidMaxvalInitialize (
> // The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is
> core for below
> // processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in
> each core.
> //
> - if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>
> + if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily,
> + CpuInfo->DisplayModel) ||
> IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
> IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)
> ||
> --
> 2.21.0.1020.gf2820cf01a-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-13 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-10 8:06 [PATCH 2/3] UefiCpuPkg: Remove double \r Joe Richey
2019-05-10 10:12 ` Ni, Ray
2019-05-13 0:47 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox