From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: eric.dong@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Tue, 28 May 2019 22:26:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 22:26:58 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 28 May 2019 22:26:57 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 22:26:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Wed, 29 May 2019 13:26:55 +0800 From: "Dong, Eric" To: "Gao, Liming" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg. Thread-Topic: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg. Thread-Index: AQHVFS0PmelK3vn570SCspV58ZuRvaaBkleAgAABU9A= Date: Wed, 29 May 2019 05:26:54 +0000 Message-ID: References: <20190528081145.10008-1-eric.dong@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E456A33@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E456A33@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Thanks for your comments. Will update them when I push the changes. Thanks, Eric > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, May 29, 2019 1:23 PM > To: devel@edk2.groups.io; Dong, Eric > Subject: RE: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to > BoardModulePkg. >=20 > Eric: > 1. Don't need to include version change message in the commit message. > Change version is in cover letter only. > 2. BoardModulePkg DEC/DSC still describe AdvancedFeaturePkg. Please fi= x > them. >=20 > With those changes, Reviewed-by: Liming Gao >=20 > Thanks > Liming > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Dong, Eric > >Sent: Tuesday, May 28, 2019 4:12 PM > >To: devel@edk2.groups.io > >Subject: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to > >BoardModulePkg. > > > >V3 change: > >1. Fix file path typo. > > > >V2 change: > >1. Add platform DSC file to enable build for this package. > >2. Add BZ link for the related changes. > > > >V1 change: > >Add new package BoardModulePkg in Platform/Intel folder. This folder > >used to keep the board generic modules, such as Cmos, BiosId. > > > >Add Cmos and BiosId related modules to BoardModulePkg. > > > > > >Eric Dong (3): > > Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder. > > Platform/Intel: Add Cmos related modules to BoardModulePkg > > Platform/Intel/BoardModulePkg: Add BiosId Module. > > > > Maintainers.txt | 4 + > > .../Intel/BoardModulePkg/BoardModulePkg.dec | 38 ++ > > .../BoardModulePkg/Include/Guid/BiosId.h | 59 +++ > > .../Include/Library/BiosIdLib.h | 57 ++ > > .../Include/Library/CmosAccessLib.h | 106 ++++ > > .../Include/Library/PlatformCmosAccessLib.h | 68 +++ > > .../Library/BiosIdLib/DxeBiosIdLib.c | 175 +++++++ > > .../Library/BiosIdLib/DxeBiosIdLib.inf | 42 ++ > > .../Library/BiosIdLib/PeiBiosIdLib.c | 191 +++++++ > > .../Library/BiosIdLib/PeiBiosIdLib.inf | 42 ++ > > .../Library/CmosAccessLib/CmosAccessLib.c | 486 ++++++++++++++++++ > > .../Library/CmosAccessLib/CmosAccessLib.inf | 28 + > > .../CmosAccessLib/CmosAccessLibInternal.h | 35 ++ > > .../PlatformCmosAccessLibNull.c | 39 ++ > > .../PlatformCmosAccessLibNull.inf | 23 + > > 15 files changed, 1393 insertions(+) > > create mode 100644 > Platform/Intel/BoardModulePkg/BoardModulePkg.dec > > create mode 100644 > Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInt > er > >nal.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platf > or > >mCmosAccessLibNull.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platf > or > >mCmosAccessLibNull.inf > > > >-- > >2.21.0.windows.1 > > > > > >