* [RFC][edk2-platform][Add new packages in Platform\Intel directory] @ 2019-05-31 7:46 Dong, Eric 2019-05-31 7:49 ` Yao, Jiewen 0 siblings, 1 reply; 15+ messages in thread From: Dong, Eric @ 2019-05-31 7:46 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D, Yao, Jiewen [-- Attachment #1: Type: text/plain, Size: 333 bytes --] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 3019 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-31 7:46 [RFC][edk2-platform][Add new packages in Platform\Intel directory] Dong, Eric @ 2019-05-31 7:49 ` Yao, Jiewen 2019-05-31 8:02 ` Dong, Eric 0 siblings, 1 reply; 15+ messages in thread From: Yao, Jiewen @ 2019-05-31 7:49 UTC (permalink / raw) To: Dong, Eric, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 861 bytes --] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 5036 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-31 7:49 ` Yao, Jiewen @ 2019-05-31 8:02 ` Dong, Eric 2019-05-31 8:05 ` Yao, Jiewen 0 siblings, 1 reply; 15+ messages in thread From: Dong, Eric @ 2019-05-31 8:02 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 1746 bytes --] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 6775 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-31 8:02 ` Dong, Eric @ 2019-05-31 8:05 ` Yao, Jiewen 2019-06-03 0:28 ` Dong, Eric 0 siblings, 1 reply; 15+ messages in thread From: Yao, Jiewen @ 2019-05-31 8:05 UTC (permalink / raw) To: Dong, Eric, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 2434 bytes --] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 9246 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-31 8:05 ` Yao, Jiewen @ 2019-06-03 0:28 ` Dong, Eric 2019-06-03 0:34 ` Yao, Jiewen 0 siblings, 1 reply; 15+ messages in thread From: Dong, Eric @ 2019-06-03 0:28 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 3175 bytes --] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 10110 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-03 0:28 ` Dong, Eric @ 2019-06-03 0:34 ` Yao, Jiewen 2019-06-03 0:52 ` Dong, Eric 0 siblings, 1 reply; 15+ messages in thread From: Yao, Jiewen @ 2019-06-03 0:34 UTC (permalink / raw) To: Dong, Eric, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D Cc: Yao, Jiewen [-- Attachment #1: Type: text/plain, Size: 3932 bytes --] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 13035 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-03 0:34 ` Yao, Jiewen @ 2019-06-03 0:52 ` Dong, Eric 2019-06-03 1:03 ` Yao, Jiewen 0 siblings, 1 reply; 15+ messages in thread From: Dong, Eric @ 2019-06-03 0:52 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 4813 bytes --] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Cc: Yao, Jiewen <jiewen.yao@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 14616 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-03 0:52 ` Dong, Eric @ 2019-06-03 1:03 ` Yao, Jiewen 2019-06-04 8:24 ` Oram, Isaac W 0 siblings, 1 reply; 15+ messages in thread From: Yao, Jiewen @ 2019-06-03 1:03 UTC (permalink / raw) To: Dong, Eric, devel@edk2.groups.io, Gao, Liming, Kubacki, Michael A, Oram, Isaac W, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 5576 bytes --] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 17902 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-03 1:03 ` Yao, Jiewen @ 2019-06-04 8:24 ` Oram, Isaac W 2019-06-12 13:26 ` Liming Gao 0 siblings, 1 reply; 15+ messages in thread From: Oram, Isaac W @ 2019-06-04 8:24 UTC (permalink / raw) To: Yao, Jiewen, Dong, Eric, devel@edk2.groups.io, Gao, Liming, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 8861 bytes --] Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by adding collections of features to your baseline. Then as a last step optimize out unnecessary things. This is something like a functionality oriented porting approach. Get all the functionality you need by building up, then optimize out. I would characterize Intel's traditional reference platforms as having everything and then adding and removing from a starting point that was very feature rich. The challenge we seemed to face was that it was hard to remove things with the feature rich starting point. As an example of functionality oriented porting, say that I set up my basic server port by starting with the Purley open board package. I port it to my motherboard, then I check out my baseline functionality. Then I add manageability features by including DSC/FDF from the ManageabilityFeaturePkg that add FV to my MinPlatform port. And I repeat for other sets of features until I get all of the features that I need. Then I optimize: for size, speed, to reduce complexity, and so on. It would be best if this optimization were tool assisted to a great degree, e.g a more sophisticated FMMT that lets one cut out extra components. My concern is that if we allow very specific feature packages, like the UserAuthenticationPkg, we are very much like today. Yes, you can select any drivers you need and add to your DSC/FDF. But that is very quickly overwhelming. There are hundreds of drivers and what they require is often complex to determine. Thus we tend to copy something else and customize it. This tends to lead to lots of technical debt and complexity. I am thinking that we should target something like 10-20 advanced feature packages that produce one or two (if features have pre-memory components) FV with a set of features and simpler dependencies. We are just in the early stages of defining what this would look like, and our thinking is evolving. We have identified Manageability and Debug as feature collections. I think that there is one for adding USB, network, Bluetooth and such peripheral support. I think setup browser and UI stuff will go somewhere. We can mine a few reference platforms for data. Let's discuss this in person and make a proposal for organization for feature packages and the rules for what goes where. We can add this proposal to your RFC and I think that will help guide the future development of the Platform\Intel contents. Regards, Isaac From: Yao, Jiewen Sent: Monday, June 3, 2019 9:03 AM To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 23695 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-04 8:24 ` Oram, Isaac W @ 2019-06-12 13:26 ` Liming Gao 2019-06-14 0:55 ` Oram, Isaac W 0 siblings, 1 reply; 15+ messages in thread From: Liming Gao @ 2019-06-12 13:26 UTC (permalink / raw) To: Oram, Isaac W, Yao, Jiewen, Dong, Eric, devel@edk2.groups.io, Kinney, Michael D Cc: Gao, Liming [-- Attachment #1: Type: text/plain, Size: 10035 bytes --] Isaac and Eric: Here is the proposal for new packages in Platform\Intel directory. BoardModulePkg: This package includes the libraries shared between the different board packages. Those libraries are linked by the drivers in the board packages. DebugFeaturePkg: This package provides the debug features, such as debug library, debug method. ManageabilityFeaturePkg: This package provides the system management driver, such as Ipmi, Smbios. DeviceFeaturePkg: This package provides the different device support, such as SIO controller, Network. UserInterfaceFeaturePkg: This package provides UI related modules, such as Logo, Setup page. Thanks Liming From: Oram, Isaac W Sent: Tuesday, June 4, 2019 4:25 PM To: Yao, Jiewen <jiewen.yao@intel.com>; Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by adding collections of features to your baseline. Then as a last step optimize out unnecessary things. This is something like a functionality oriented porting approach. Get all the functionality you need by building up, then optimize out. I would characterize Intel's traditional reference platforms as having everything and then adding and removing from a starting point that was very feature rich. The challenge we seemed to face was that it was hard to remove things with the feature rich starting point. As an example of functionality oriented porting, say that I set up my basic server port by starting with the Purley open board package. I port it to my motherboard, then I check out my baseline functionality. Then I add manageability features by including DSC/FDF from the ManageabilityFeaturePkg that add FV to my MinPlatform port. And I repeat for other sets of features until I get all of the features that I need. Then I optimize: for size, speed, to reduce complexity, and so on. It would be best if this optimization were tool assisted to a great degree, e.g a more sophisticated FMMT that lets one cut out extra components. My concern is that if we allow very specific feature packages, like the UserAuthenticationPkg, we are very much like today. Yes, you can select any drivers you need and add to your DSC/FDF. But that is very quickly overwhelming. There are hundreds of drivers and what they require is often complex to determine. Thus we tend to copy something else and customize it. This tends to lead to lots of technical debt and complexity. I am thinking that we should target something like 10-20 advanced feature packages that produce one or two (if features have pre-memory components) FV with a set of features and simpler dependencies. We are just in the early stages of defining what this would look like, and our thinking is evolving. We have identified Manageability and Debug as feature collections. I think that there is one for adding USB, network, Bluetooth and such peripheral support. I think setup browser and UI stuff will go somewhere. We can mine a few reference platforms for data. Let's discuss this in person and make a proposal for organization for feature packages and the rules for what goes where. We can add this proposal to your RFC and I think that will help guide the future development of the Platform\Intel contents. Regards, Isaac From: Yao, Jiewen Sent: Monday, June 3, 2019 9:03 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 25875 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-12 13:26 ` Liming Gao @ 2019-06-14 0:55 ` Oram, Isaac W 2019-06-14 0:57 ` Yao, Jiewen 0 siblings, 1 reply; 15+ messages in thread From: Oram, Isaac W @ 2019-06-14 0:55 UTC (permalink / raw) To: Gao, Liming, Yao, Jiewen, Dong, Eric, devel@edk2.groups.io, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 10771 bytes --] This looks good to me. I would suggest that we also capture an overview of the organization and the targeted contents of the different packages in the Platform/Intel/Readme.md or maybe a wiki page. Thanks, Isaac From: Gao, Liming Sent: Wednesday, June 12, 2019 6:27 AM To: Oram, Isaac W <isaac.w.oram@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> Cc: Gao, Liming <liming.gao@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac and Eric: Here is the proposal for new packages in Platform\Intel directory. BoardModulePkg: This package includes the libraries shared between the different board packages. Those libraries are linked by the drivers in the board packages. DebugFeaturePkg: This package provides the debug features, such as debug library, debug method. ManageabilityFeaturePkg: This package provides the system management driver, such as Ipmi, Smbios. DeviceFeaturePkg: This package provides the different device support, such as SIO controller, Network. UserInterfaceFeaturePkg: This package provides UI related modules, such as Logo, Setup page. Thanks Liming From: Oram, Isaac W Sent: Tuesday, June 4, 2019 4:25 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by adding collections of features to your baseline. Then as a last step optimize out unnecessary things. This is something like a functionality oriented porting approach. Get all the functionality you need by building up, then optimize out. I would characterize Intel's traditional reference platforms as having everything and then adding and removing from a starting point that was very feature rich. The challenge we seemed to face was that it was hard to remove things with the feature rich starting point. As an example of functionality oriented porting, say that I set up my basic server port by starting with the Purley open board package. I port it to my motherboard, then I check out my baseline functionality. Then I add manageability features by including DSC/FDF from the ManageabilityFeaturePkg that add FV to my MinPlatform port. And I repeat for other sets of features until I get all of the features that I need. Then I optimize: for size, speed, to reduce complexity, and so on. It would be best if this optimization were tool assisted to a great degree, e.g a more sophisticated FMMT that lets one cut out extra components. My concern is that if we allow very specific feature packages, like the UserAuthenticationPkg, we are very much like today. Yes, you can select any drivers you need and add to your DSC/FDF. But that is very quickly overwhelming. There are hundreds of drivers and what they require is often complex to determine. Thus we tend to copy something else and customize it. This tends to lead to lots of technical debt and complexity. I am thinking that we should target something like 10-20 advanced feature packages that produce one or two (if features have pre-memory components) FV with a set of features and simpler dependencies. We are just in the early stages of defining what this would look like, and our thinking is evolving. We have identified Manageability and Debug as feature collections. I think that there is one for adding USB, network, Bluetooth and such peripheral support. I think setup browser and UI stuff will go somewhere. We can mine a few reference platforms for data. Let's discuss this in person and make a proposal for organization for feature packages and the rules for what goes where. We can add this proposal to your RFC and I think that will help guide the future development of the Platform\Intel contents. Regards, Isaac From: Yao, Jiewen Sent: Monday, June 3, 2019 9:03 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 29079 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-14 0:55 ` Oram, Isaac W @ 2019-06-14 0:57 ` Yao, Jiewen 2019-06-18 14:08 ` Liming Gao 0 siblings, 1 reply; 15+ messages in thread From: Yao, Jiewen @ 2019-06-14 0:57 UTC (permalink / raw) To: Oram, Isaac W, Gao, Liming, Dong, Eric, devel@edk2.groups.io, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 11372 bytes --] Yes, ok for me. Good idea to add the overview of the package content. Thank you Yao Jiewen From: Oram, Isaac W Sent: Friday, June 14, 2019 8:55 AM To: Gao, Liming <liming.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] This looks good to me. I would suggest that we also capture an overview of the organization and the targeted contents of the different packages in the Platform/Intel/Readme.md or maybe a wiki page. Thanks, Isaac From: Gao, Liming Sent: Wednesday, June 12, 2019 6:27 AM To: Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac and Eric: Here is the proposal for new packages in Platform\Intel directory. BoardModulePkg: This package includes the libraries shared between the different board packages. Those libraries are linked by the drivers in the board packages. DebugFeaturePkg: This package provides the debug features, such as debug library, debug method. ManageabilityFeaturePkg: This package provides the system management driver, such as Ipmi, Smbios. DeviceFeaturePkg: This package provides the different device support, such as SIO controller, Network. UserInterfaceFeaturePkg: This package provides UI related modules, such as Logo, Setup page. Thanks Liming From: Oram, Isaac W Sent: Tuesday, June 4, 2019 4:25 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by adding collections of features to your baseline. Then as a last step optimize out unnecessary things. This is something like a functionality oriented porting approach. Get all the functionality you need by building up, then optimize out. I would characterize Intel's traditional reference platforms as having everything and then adding and removing from a starting point that was very feature rich. The challenge we seemed to face was that it was hard to remove things with the feature rich starting point. As an example of functionality oriented porting, say that I set up my basic server port by starting with the Purley open board package. I port it to my motherboard, then I check out my baseline functionality. Then I add manageability features by including DSC/FDF from the ManageabilityFeaturePkg that add FV to my MinPlatform port. And I repeat for other sets of features until I get all of the features that I need. Then I optimize: for size, speed, to reduce complexity, and so on. It would be best if this optimization were tool assisted to a great degree, e.g a more sophisticated FMMT that lets one cut out extra components. My concern is that if we allow very specific feature packages, like the UserAuthenticationPkg, we are very much like today. Yes, you can select any drivers you need and add to your DSC/FDF. But that is very quickly overwhelming. There are hundreds of drivers and what they require is often complex to determine. Thus we tend to copy something else and customize it. This tends to lead to lots of technical debt and complexity. I am thinking that we should target something like 10-20 advanced feature packages that produce one or two (if features have pre-memory components) FV with a set of features and simpler dependencies. We are just in the early stages of defining what this would look like, and our thinking is evolving. We have identified Manageability and Debug as feature collections. I think that there is one for adding USB, network, Bluetooth and such peripheral support. I think setup browser and UI stuff will go somewhere. We can mine a few reference platforms for data. Let's discuss this in person and make a proposal for organization for feature packages and the rules for what goes where. We can add this proposal to your RFC and I think that will help guide the future development of the Platform\Intel contents. Regards, Isaac From: Yao, Jiewen Sent: Monday, June 3, 2019 9:03 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 29220 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-06-14 0:57 ` Yao, Jiewen @ 2019-06-18 14:08 ` Liming Gao 0 siblings, 0 replies; 15+ messages in thread From: Liming Gao @ 2019-06-18 14:08 UTC (permalink / raw) To: Yao, Jiewen, Oram, Isaac W, Dong, Eric, devel@edk2.groups.io, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 12415 bytes --] Hi, all Besides those packages, I would like to introduce Tools directory to include some tools for the platform integration. Now, those tools are used and verified by Intel platform. So, I suggest to add them into Edk2Platforms Platform\Intel and Silicon\Intel first. When other platform uses them, they can be considered to be moved into the common tools directory or Edk2 BaseTools later. Platform\Intel\Tools: FMMT (BZ 1847) FCE (BZ 1848) GenBiosId (BZ 1846) UniTool (BZ 1855) Silicon\Intel\Tools: FitGen (BZ 1849) Thanks Liming From: Yao, Jiewen Sent: Friday, June 14, 2019 8:57 AM To: Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Yes, ok for me. Good idea to add the overview of the package content. Thank you Yao Jiewen From: Oram, Isaac W Sent: Friday, June 14, 2019 8:55 AM To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] This looks good to me. I would suggest that we also capture an overview of the organization and the targeted contents of the different packages in the Platform/Intel/Readme.md or maybe a wiki page. Thanks, Isaac From: Gao, Liming Sent: Wednesday, June 12, 2019 6:27 AM To: Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac and Eric: Here is the proposal for new packages in Platform\Intel directory. BoardModulePkg: This package includes the libraries shared between the different board packages. Those libraries are linked by the drivers in the board packages. DebugFeaturePkg: This package provides the debug features, such as debug library, debug method. ManageabilityFeaturePkg: This package provides the system management driver, such as Ipmi, Smbios. DeviceFeaturePkg: This package provides the different device support, such as SIO controller, Network. UserInterfaceFeaturePkg: This package provides UI related modules, such as Logo, Setup page. Thanks Liming From: Oram, Isaac W Sent: Tuesday, June 4, 2019 4:25 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by adding collections of features to your baseline. Then as a last step optimize out unnecessary things. This is something like a functionality oriented porting approach. Get all the functionality you need by building up, then optimize out. I would characterize Intel's traditional reference platforms as having everything and then adding and removing from a starting point that was very feature rich. The challenge we seemed to face was that it was hard to remove things with the feature rich starting point. As an example of functionality oriented porting, say that I set up my basic server port by starting with the Purley open board package. I port it to my motherboard, then I check out my baseline functionality. Then I add manageability features by including DSC/FDF from the ManageabilityFeaturePkg that add FV to my MinPlatform port. And I repeat for other sets of features until I get all of the features that I need. Then I optimize: for size, speed, to reduce complexity, and so on. It would be best if this optimization were tool assisted to a great degree, e.g a more sophisticated FMMT that lets one cut out extra components. My concern is that if we allow very specific feature packages, like the UserAuthenticationPkg, we are very much like today. Yes, you can select any drivers you need and add to your DSC/FDF. But that is very quickly overwhelming. There are hundreds of drivers and what they require is often complex to determine. Thus we tend to copy something else and customize it. This tends to lead to lots of technical debt and complexity. I am thinking that we should target something like 10-20 advanced feature packages that produce one or two (if features have pre-memory components) FV with a set of features and simpler dependencies. We are just in the early stages of defining what this would look like, and our thinking is evolving. We have identified Manageability and Debug as feature collections. I think that there is one for adding USB, network, Bluetooth and such peripheral support. I think setup browser and UI stuff will go somewhere. We can mine a few reference platforms for data. Let's discuss this in person and make a proposal for organization for feature packages and the rules for what goes where. We can add this proposal to your RFC and I think that will help guide the future development of the Platform\Intel contents. Regards, Isaac From: Yao, Jiewen Sent: Monday, June 3, 2019 9:03 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, So far, I don't have other modules which need to move to this package. I think UserAuthenticationPkg is too specific, but if others also agree with this name, I'm ok too. Hi liming, Isaac & Mike, Any comments about the new package name? Thanks, Eric From: Yao, Jiewen Sent: Monday, June 3, 2019 8:35 AM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] OK. Do you have any other modules what could be potentially in this package? I think another option is to name it UserAuthenticationPkg, just like SignedCapsulePkg. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:28 AM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] I think sample means this is an example about how to enable this feature. Code implemented with production quality. Platform can decide whether to use it or not. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 4:06 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Jiewen, I think SecuritySamplePkg used to save 1) sample implementation for security related features, 2) it's platform scope feature. SecurityPkg used to save 1) common security features, 2) It's not a sample implementation. This is just my proposal, If you have better one, you can raise here. Thanks, Eric From: Yao, Jiewen Sent: Friday, May 31, 2019 3:49 PM To: Dong, Eric <eric.dong@intel.com<mailto:eric.dong@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> Subject: RE: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> Subject: [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac, Jiewen & Mike, I plan to add a new driver named UserAuthentication. This driver shows a sample implementation about how to control user enter setup page. I plan to add a new package in Platform\Intel folder to save this driver. New package name is SecuritySamplePkg. Any comments for this RFC? Thanks, Eric _._,_._,_ [-- Attachment #2: Type: text/html, Size: 32219 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <159EDE4CF381B84A.22232@groups.io>]
* Re: [RFC][edk2-platform][Add new packages in Platform\Intel directory] [not found] <159EDE4CF381B84A.22232@groups.io> @ 2019-05-27 2:50 ` Liming Gao 0 siblings, 0 replies; 15+ messages in thread From: Liming Gao @ 2019-05-27 2:50 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, Chaganty, Rangasai V, Oram, Isaac W, Kinney, Michael D Cc: Kubacki, Michael A [-- Attachment #1: Type: text/plain, Size: 996 bytes --] One update on new DebugAdvancedFeaturePkg. We can drop Advanced and use short name DebugFeaturePkg. Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Wednesday, May 15, 2019 9:29 PM To: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> Cc: devel@edk2.groups.io Subject: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael and Sai: Now, we have AcpiDebug module in Platform\Intel\AdvancedFeaturePkg for debug feature, and I also see new patch to add Cmos related libraries for board feature. To make those features be enabled separately, I propose to create new packages for them. One is DebugAdvancedFeaturePkg for the debug related features, another is GenericBoardPkg for the common board features. If there is new code to be added in Platform\Intel directory in future, new feature package can be created for them. Thanks Liming [-- Attachment #2: Type: text/html, Size: 4076 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [RFC][edk2-platform][Add new packages in Platform\Intel directory] @ 2019-05-15 13:28 Liming Gao 0 siblings, 0 replies; 15+ messages in thread From: Liming Gao @ 2019-05-15 13:28 UTC (permalink / raw) To: Kubacki, Michael A, Chaganty, Rangasai V; +Cc: devel@edk2.groups.io [-- Attachment #1: Type: text/plain, Size: 528 bytes --] Michael and Sai: Now, we have AcpiDebug module in Platform\Intel\AdvancedFeaturePkg for debug feature, and I also see new patch to add Cmos related libraries for board feature. To make those features be enabled separately, I propose to create new packages for them. One is DebugAdvancedFeaturePkg for the debug related features, another is GenericBoardPkg for the common board features. If there is new code to be added in Platform\Intel directory in future, new feature package can be created for them. Thanks Liming [-- Attachment #2: Type: text/html, Size: 2699 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-06-18 14:08 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31 7:46 [RFC][edk2-platform][Add new packages in Platform\Intel directory] Dong, Eric
2019-05-31 7:49 ` Yao, Jiewen
2019-05-31 8:02 ` Dong, Eric
2019-05-31 8:05 ` Yao, Jiewen
2019-06-03 0:28 ` Dong, Eric
2019-06-03 0:34 ` Yao, Jiewen
2019-06-03 0:52 ` Dong, Eric
2019-06-03 1:03 ` Yao, Jiewen
2019-06-04 8:24 ` Oram, Isaac W
2019-06-12 13:26 ` Liming Gao
2019-06-14 0:55 ` Oram, Isaac W
2019-06-14 0:57 ` Yao, Jiewen
2019-06-18 14:08 ` Liming Gao
[not found] <159EDE4CF381B84A.22232@groups.io>
2019-05-27 2:50 ` Liming Gao
-- strict thread matches above, loose matches on Subject: below --
2019-05-15 13:28 Liming Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox