Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Monday, June 17, 2019 1:45 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [patch]
> Platform/Intel/DebugFeaturePkg: Update PCD type
> 
> Add PcdAcpiDebugEnable and PcdAcpiDebugBufferSize into following section
> which platform can customize the type by itself.
> [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> index 7389d36a57..37ebe6da4d 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> @@ -49,10 +49,11 @@ [PcdsFixedAtBuild]
>    ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes space.
> 
> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortDeviceIndex|0x5A|
> UINT8|0x00000007
>    ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes space.
> 
> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortFunctionIndex|0x5B
> |UINT8|0x00000008
> 
> +[PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>    ## This PCD specifies AcpiDebug feature is enable/disable.
> 
> gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugEnable|FALSE|BOOLEAN|
> 0x00000009
>    ## This PCD specifies AcpiDebug buffer size.
> 
> gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize|0x10000|UINT
> 32|0x0000000A
> 
> --
> 2.18.0.windows.1
> 
> 
>