From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: eric.dong@intel.com)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by groups.io with SMTP; Mon, 17 Jun 2019 18:40:08 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 18:40:07 -0700
X-ExtLoop1: 1
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by orsmga007.jf.intel.com with ESMTP; 17 Jun 2019 18:40:07 -0700
Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 18:40:06 -0700
Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by
 fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 18:40:06 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by
 SHSMSX153.ccr.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0439.000;
 Tue, 18 Jun 2019 09:40:04 +0800
From: "Dong, Eric" <eric.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Bi, Dandan"
	<dandan.bi@intel.com>
CC: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type
Thread-Topic: [edk2-devel] [edk2-platforms] [patch]
 Platform/Intel/DebugFeaturePkg: Update PCD type
Thread-Index: AQHVJM/OZDGfuYGWM0ytessnTlECaqago9PA
Date: Tue, 18 Jun 2019 01:40:04 +0000
Message-ID: <ED077930C258884BBCB450DB737E662259E714AF@shsmsx102.ccr.corp.intel.com>
References: <20190617054442.36192-1-dandan.bi@intel.com>
In-Reply-To: <20190617054442.36192-1-dandan.bi@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: eric.dong@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Monday, June 17, 2019 1:45 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [patch]
> Platform/Intel/DebugFeaturePkg: Update PCD type
>=20
> Add PcdAcpiDebugEnable and PcdAcpiDebugBufferSize into following section
> which platform can customize the type by itself.
> [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>=20
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> index 7389d36a57..37ebe6da4d 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
> @@ -49,10 +49,11 @@ [PcdsFixedAtBuild]
>    ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes=
 space.
>=20
> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortDeviceIndex|0x5A|
> UINT8|0x00000007
>    ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes=
 space.
>=20
> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortFunctionIndex|0x5B
> |UINT8|0x00000008
>=20
> +[PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>    ## This PCD specifies AcpiDebug feature is enable/disable.
>=20
> gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugEnable|FALSE|BOOLEAN|
> 0x00000009
>    ## This PCD specifies AcpiDebug buffer size.
>=20
> gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize|0x10000|UINT
> 32|0x0000000A
>=20
> --
> 2.18.0.windows.1
>=20
>=20
>=20