From: "Dong, Eric" <eric.dong@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules
Date: Thu, 20 Jun 2019 01:11:33 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259E7202F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190617084850.41272-1-dandan.bi@intel.com>
Hi Dandan,
Please update the copyright date to 2019 before you check in the code, others are good to me.
Reviewed-by: Eric Dong <eric.dong@intel.com>
Thanks,
Eric
> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, June 17, 2019 4:49 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and
> UserAuthentication modules
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545
>
> Patch 1 add a new package UserInterfaceFeaturePkg where put the
> UserAuthentication modules into.
> Package name follows the discussion in:
> https://edk2.groups.io/g/devel/message/42286
>
> Patch 2 add password based user authentication modules.
>
> V3:
> No change for patch 1.
> Patch 2 add missing [LibraryClasses] section in UserInterfaceFeaturePkg.dec.
>
> V2:
> No change for patch 1.
> patch 2 add PcdPasswordCleared in
> [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
> section.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (2):
> Platform/Intel: Add UserInterfaceFeaturePkg
> Platform/Intel/UserInterfaceFeaturePkg: Add UserAuthentication modules
>
> Maintainers.txt | 4 +
> .../Include/Guid/UserAuthentication.h | 45 +
> .../Include/Library/PlatformPasswordLib.h | 48 ++
> .../Include/Library/UserPasswordLib.h | 70 ++
> .../Include/Library/UserPasswordUiLib.h | 37 +
> .../PlatformPasswordLibNull.c | 78 ++
> .../PlatformPasswordLibNull.inf | 39 +
> .../PlatformPasswordLibNull.uni | 19 +
> .../Library/UserPasswordLib/UserPasswordLib.c | 274 ++++++
> .../UserPasswordLib/UserPasswordLib.inf | 37 +
> .../UserPasswordUiLib/UserPasswordUiLib.c | 522 ++++++++++++
> .../UserPasswordUiLib/UserPasswordUiLib.inf | 41 +
> .../UserAuthentication/KeyService.c | 133 +++
> .../UserAuthentication/KeyService.h | 88 ++
> .../UserAuthentication2Dxe.c | 478 +++++++++++
> .../UserAuthentication2Dxe.h | 55 ++
> .../UserAuthentication2Dxe.inf | 53 ++
> .../UserAuthenticationDxe.c | 780 ++++++++++++++++++
> .../UserAuthenticationDxe.h | 138 ++++
> .../UserAuthenticationDxe.inf | 63 ++
> .../UserAuthenticationDxeFormset.h | 23 +
> .../UserAuthenticationDxePassword.c | 319 +++++++
> .../UserAuthenticationDxeStrings.uni | 30 +
> .../UserAuthenticationDxeVfr.vfr | 39 +
> .../UserAuthenticationSmm.c | 674 +++++++++++++++
> .../UserAuthenticationSmm.h | 52 ++
> .../UserAuthenticationSmm.inf | 53 ++
> .../UserInterfaceFeaturePkg.dec | 34 +
> .../UserInterfaceFeaturePkg.dsc | 78 ++
> 29 files changed, 4304 insertions(+)
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Include/Guid/UserAuthentication.
> h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Include/Library/PlatformPasswordL
> ib.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Include/Library/UserPasswordLib.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Include/Library/UserPasswordUiLib
> .h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P
> latformPasswordLibNull.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P
> latformPasswordLibNull.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P
> latformPasswordLibNull.uni
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPass
> wordLib.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPass
> wordLib.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordUiLib/UserPa
> sswordUiLib.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordUiLib/UserPa
> sswordUiLib.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/KeyService.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/KeyService.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ation2Dxe.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ation2Dxe.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ation2Dxe.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxe.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxe.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxe.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxeFormset.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxePassword.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxeStrings.uni
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationDxeVfr.vfr
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationSmm.c
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationSmm.h
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic
> ationSmm.inf
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
> create mode 100644
> Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
>
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-06-20 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:48 [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules Dandan Bi
2019-06-17 8:48 ` [edk2-platforms] [patch v3 1/2] Platform/Intel: Add UserInterfaceFeaturePkg Dandan Bi
2019-06-17 8:48 ` [edk2-platforms] [patch v3 2/2] Platform/Intel/UserInterfaceFeaturePkg: Add UserAuthentication modules Dandan Bi
2019-06-20 1:11 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259E7202F@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox