From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: eric.dong@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 19 Jun 2019 18:14:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 18:14:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,394,1557212400"; d="scan'208";a="165176430" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 19 Jun 2019 18:14:56 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Jun 2019 18:14:55 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Jun 2019 18:14:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Thu, 20 Jun 2019 09:11:34 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules Thread-Topic: [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules Thread-Index: AQHVJOmGQjxFmaWXZUGDdChAbpQ5b6ajwAtQ Date: Thu, 20 Jun 2019 01:11:33 +0000 Message-ID: References: <20190617084850.41272-1-dandan.bi@intel.com> In-Reply-To: <20190617084850.41272-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Dandan, Please update the copyright date to 2019 before you check in the code, othe= rs are good to me. Reviewed-by: Eric Dong Thanks, Eric > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 17, 2019 4:49 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and > UserAuthentication modules >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1545 >=20 > Patch 1 add a new package UserInterfaceFeaturePkg where put the > UserAuthentication modules into. > Package name follows the discussion in: > https://edk2.groups.io/g/devel/message/42286 >=20 > Patch 2 add password based user authentication modules. >=20 > V3: > No change for patch 1. > Patch 2 add missing [LibraryClasses] section in UserInterfaceFeaturePkg.d= ec. >=20 > V2: > No change for patch 1. > patch 2 add PcdPasswordCleared in > [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] > section. >=20 > Cc: Eric Dong > Cc: Liming Gao > Dandan Bi (2): > Platform/Intel: Add UserInterfaceFeaturePkg > Platform/Intel/UserInterfaceFeaturePkg: Add UserAuthentication modules >=20 > Maintainers.txt | 4 + > .../Include/Guid/UserAuthentication.h | 45 + > .../Include/Library/PlatformPasswordLib.h | 48 ++ > .../Include/Library/UserPasswordLib.h | 70 ++ > .../Include/Library/UserPasswordUiLib.h | 37 + > .../PlatformPasswordLibNull.c | 78 ++ > .../PlatformPasswordLibNull.inf | 39 + > .../PlatformPasswordLibNull.uni | 19 + > .../Library/UserPasswordLib/UserPasswordLib.c | 274 ++++++ > .../UserPasswordLib/UserPasswordLib.inf | 37 + > .../UserPasswordUiLib/UserPasswordUiLib.c | 522 ++++++++++++ > .../UserPasswordUiLib/UserPasswordUiLib.inf | 41 + > .../UserAuthentication/KeyService.c | 133 +++ > .../UserAuthentication/KeyService.h | 88 ++ > .../UserAuthentication2Dxe.c | 478 +++++++++++ > .../UserAuthentication2Dxe.h | 55 ++ > .../UserAuthentication2Dxe.inf | 53 ++ > .../UserAuthenticationDxe.c | 780 ++++++++++++++++++ > .../UserAuthenticationDxe.h | 138 ++++ > .../UserAuthenticationDxe.inf | 63 ++ > .../UserAuthenticationDxeFormset.h | 23 + > .../UserAuthenticationDxePassword.c | 319 +++++++ > .../UserAuthenticationDxeStrings.uni | 30 + > .../UserAuthenticationDxeVfr.vfr | 39 + > .../UserAuthenticationSmm.c | 674 +++++++++++++++ > .../UserAuthenticationSmm.h | 52 ++ > .../UserAuthenticationSmm.inf | 53 ++ > .../UserInterfaceFeaturePkg.dec | 34 + > .../UserInterfaceFeaturePkg.dsc | 78 ++ > 29 files changed, 4304 insertions(+) > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Include/Guid/UserAuthentication. > h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Include/Library/PlatformPasswordL > ib.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Include/Library/UserPasswordLib.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Include/Library/UserPasswordUiLib > .h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P > latformPasswordLibNull.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P > latformPasswordLibNull.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/P > latformPasswordLibNull.uni > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPass > wordLib.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPass > wordLib.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordUiLib/UserPa > sswordUiLib.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/Library/UserPasswordUiLib/UserPa > sswordUiLib.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/KeyService.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/KeyService.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ation2Dxe.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ation2Dxe.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ation2Dxe.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxe.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxe.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxe.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxeFormset.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxePassword.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxeStrings.uni > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationDxeVfr.vfr > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationSmm.c > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationSmm.h > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentic > ationSmm.inf > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec > create mode 100644 > Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc >=20 > -- > 2.18.0.windows.1