From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: eric.dong@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 02 Jul 2019 19:58:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 19:58:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,445,1557212400"; d="scan'208";a="168995422" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 02 Jul 2019 19:58:30 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 19:58:30 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 19:58:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.3]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 10:58:27 +0800 From: "Dong, Eric" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol Thread-Topic: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol Thread-Index: AQHVMUkLR1EOfuuFZUuxAx4gugTlWqa4L8NQgAAAaBA= Date: Wed, 3 Jul 2019 02:58:27 +0000 Message-ID: References: <20190703024242.33572-1-eric.dong@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6F1EB1@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F6F1EB1@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiewen, I did below tests: 1. Use MpGetNumberOfProcessors and MpSetStartupProcedure. 2. Test MpDispatchProcedure 1.sync mode and async mode,=20 2. with and without CpuStatus. 3. In async mode, use long delay get the final result with MpWaitForProce= dure 4. In async mode, use short delay to check the final result with MpCheckF= orProcedure 3. Test MpBroadcastProcedure 1.sync mode and async mode,=20 2. with and without CpuStatus. 3. In async mode, use long delay get the final result with MpWaitForProce= dure. 4. In async mode, use short delay to check the final result with MpCheckF= orProcedure. Detail test code can be found in MmMpUnitTest folder at git@github.com:ydo= ng10/UnitTestPkg.git Thanks, Eric > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, July 3, 2019 10:45 AM > To: devel@edk2.groups.io; Dong, Eric > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol >=20 > HI Eric > Would you please share what unit test you have done for this new feature= ? >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Dong, Eric > > Sent: Wednesday, July 3, 2019 10:43 AM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Laszlo Ersek > > Subject: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol > > > > v3 changes: > > 1. Fix Token clean up too early caused CheckProcedure return error. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1937 > > > > PI spec added a new protocol named MM MP protocol. This protocol > > allows for better remote queuing of execution of procedures on an AP. > > This extends the existing procedures to allow: > > 1. A function to be called in blocking and non-blocking manner > > explicitly 2. Allow broadcasts. > > 3. Allow execution of a procedure when a processor powers up. > > > > This patch serial enable this new protocol. > > > > Cc: Ray Ni > > Cc: Laszlo Ersek > > > > Eric Dong (2): > > MdePkg: Add new MM MP Protocol definition. > > UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol. > > > > MdePkg/Include/Pi/PiMultiPhase.h | 16 + > > MdePkg/Include/Protocol/MmMp.h | 333 +++++++++++ > > MdePkg/MdePkg.dec | 3 + > > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 555 > > ++++++++++++++++++- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 + > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 160 +++++- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 3 + > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c | 372 > > +++++++++++++ > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 286 > > ++++++++++ > > 9 files changed, 1722 insertions(+), 17 deletions(-) create mode > > 100644 MdePkg/Include/Protocol/MmMp.h create mode 100644 > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c create mode 100644 > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > > > > -- > > 2.21.0.windows.1 > > > > > >=20