From: "Dong, Eric" <eric.dong@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>, "Ni, Ray" <ray.ni@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure
Date: Wed, 17 Jul 2019 03:26:11 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259E9738D@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190717032314.25408-1-star.zeng@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, July 17, 2019 11:23 AM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>
> Subject: [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build
> failure
>
> The new VS2012 build failure is caused by 7a0df26.
>
> xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) :
> warning C4701: potentially uninitialized local variable 'MpEvent' used
>
> It is a false positive alarm.
> MpEvent is assigned at line 238 and will be used at line 258, both lines are
> controlled by "if (CpuFeaturesData->NumberOfCpus > 1)".
>
> This patch initializes MpEvent to suppress incorrect compiler/analyzer
> warnings.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> .../RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> index ffd99046a6cd..f87b2892aaae 100644
> ---
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLi
> +++ b.c
> @@ -229,6 +229,12 @@ CpuFeaturesInitialize (
> OldBspNumber = GetProcessorIndex (CpuFeaturesData);
> CpuFeaturesData->BspNumber = OldBspNumber;
>
> + //
> + //
> + // Initialize MpEvent to suppress incorrect compiler/analyzer warnings.
> + //
> + MpEvent = NULL;
> +
> if (CpuFeaturesData->NumberOfCpus > 1) {
> Status = gBS->CreateEvent (
> EVT_NOTIFY_WAIT,
> --
> 2.21.0.windows.1
prev parent reply other threads:[~2019-07-17 3:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 3:23 [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure Zeng, Star
2019-07-17 3:26 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259E9738D@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox