public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h
Date: Wed, 31 Jul 2019 00:16:15 +0000	[thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259EB6926@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <0c21ebab-374f-d53d-e477-f830ea278222@redhat.com>

Agree with Laszlo's comments. This info is more precise for the issue.  Please update the commit message when you push the change.

With the commit message updated, reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks,
Eric
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 30, 2019 10:11 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove trailing white space in SmmMp.h
> 
> On 07/30/19 10:37, Zhang, Shenglei wrote:
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > index e0d823a4b1c6..b95ed8c6f836 100644
> > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >    @retval EFI_SUCCESS             The number of processors was retrieved
> successfully
> >    @retval EFI_INVALID_PARAMETER   NumberOfProcessors is NULL
> >  **/
> > -
> >  EFI_STATUS
> >  EFIAPI
> >  SmmMpGetNumberOfProcessors (
> >
> 
> The patch looks good, but I wonder if we should call this empty line "trailing".
> It is not at the end of the file, and not at the end of a line. Perhaps:
> 
>   UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration
> adjacent
> 
> (73 characters).
> 
> Anyway, I don't feel too strongly about this. Either way:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks
> Laszlo
> 
> 


      reply	other threads:[~2019-07-31  0:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
2019-07-30  8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30  9:15   ` [edk2-devel] " Wang, Jian J
2019-07-30 10:25   ` Philippe Mathieu-Daudé
2019-07-31  1:01   ` Dandan Bi
2019-07-30  8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
2019-07-30  9:12   ` Wang, Jian J
2019-07-30  8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
2019-07-30 14:11   ` [edk2-devel] " Laszlo Ersek
2019-07-31  0:16     ` Dong, Eric [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED077930C258884BBCB450DB737E662259EB6926@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox