From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 30 Jul 2019 19:28:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 19:28:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,328,1559545200"; d="scan'208";a="173989930" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 30 Jul 2019 19:28:38 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 19:28:38 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 19:28:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 10:28:36 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code Thread-Topic: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code Thread-Index: AQHVRqG0MJk4UnE6NUiP1RUfebHkzabkAPYA Date: Wed, 31 Jul 2019 02:28:35 +0000 Message-ID: References: <20190730064007.13212-1-shenglei.zhang@intel.com> In-Reply-To: <20190730064007.13212-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Shenglei, > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, July 30, 2019 2:40 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Zhang, Shenglei > Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments > consistent with code >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index ef16997547..990dfe6826 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1398,7 +1398,7 @@ InternalSmmStartupAllAPs ( >=20 > Wrapper for Procedures. >=20 > - @param[in] Buffer Pointer to PROCEDURE_WRAPPER buffer. > + @param[in,out] Buffer Pointer to PROCEDURE_WRAPPER buffer. 1. Please remove "out" attribute for " Buffer" parameter in function heade= r. >=20 > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index 186809f431..c73f13e3c8 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1295,7 +1295,7 @@ RestoreCr2 ( > @param[in] Procedure The address of the procedure= to run > @param[in] CpuIndex Target CPU Index > @param[in,out] ProcArguments The parameter to pass to the > procedure > - @param[in,out] Token This is an optional paramete= r that allows > the caller to execute the > + @param[in] Token This is an optional paramete= r that allows 2. Please add "out" attribute for " Token" parameter in function header. Thanks, Eric > the caller to execute the > procedure in a blocking or n= on-blocking fashion. If it is > NULL the > call is blocking, and the ca= ll will not return until the AP > has > completed the procedure. If = the token is not NULL, the > call will @@ -1387,7 +1387,7 @@ IsPresentAp ( > @param[in] TimeoutInMicroseconds Indicates the time limit in > microseconds for > APs to return from Procedure, e= ither for > blocking or non-blocking mode. > - @param[in,out] ProcedureArgument The parameter passed into > Procedure for > + @param[in,out] ProcedureArguments The parameter passed into > Procedure for > all APs. > @param[in,out] Token This is an optional parameter t= hat allows > the caller to execute the > procedure in a blocking or non-= blocking fashion. If it is > NULL the > -- > 2.18.0.windows.1