From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: eric.dong@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 01 Aug 2019 02:08:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 02:08:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,333,1559545200"; d="scan'208";a="372541762" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2019 02:08:01 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 02:08:01 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 02:08:01 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Thu, 1 Aug 2019 17:07:59 +0800 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek Subject: Re: [Patch 0/2] UefiCpuPkg: Default avoid print. Thread-Topic: [Patch 0/2] UefiCpuPkg: Default avoid print. Thread-Index: AQHVR3J+/ivTiomJck2TksP0+v3viabl6LGggAAVMmA= Date: Thu, 1 Aug 2019 09:07:58 +0000 Message-ID: References: <20190731073502.24640-1-eric.dong@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C26764D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C26764D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Yes, I will remove debug code in v2 change. I have submitted feature request for new MP safe DebugLib: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2043. Thanks, Eric > -----Original Message----- > From: Ni, Ray > Sent: Thursday, August 1, 2019 3:52 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Laszlo Ersek > Subject: RE: [Patch 0/2] UefiCpuPkg: Default avoid print. >=20 > Eric, > My understanding to your patch is you want to avoid printing from AP > because some platforms may choose wrong DebugLib instance for the > CpuFeaturePei/Dxe driver, which leads to system hang. > To make the platform happy and while the value of printing the debug > message is less, the solution in your patch is to suppress the debug mess= age > unless a minor code change is made to turn on the debugging. >=20 > Given that there are many comments/suggestions on how to implement a > MP safe debugging infra, I don't think implementing such a MP safe > debugging infra can be quickly done. >=20 > How about directly remove the debug message instead of disabling in your > V2 patch? >=20 > The goal of MP safe debugging infra is to provide a mechanism to print de= bug > message in MP environment that doesn't depend on platform DSC library > instance mapping. >=20 > Can you please submit a BZ to capture that and also remember to attach th= e > URL to this mail thread in BZ? >=20 > We could use future TianoCore Design Meeting to discuss about this. >=20 > Thanks, > Ray >=20 >=20 > > -----Original Message----- > > From: Dong, Eric > > Sent: Wednesday, July 31, 2019 3:35 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Laszlo Ersek > > Subject: [Patch 0/2] UefiCpuPkg: Default avoid print. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1984 > > > > Current debug message brings much restriction for the platform which > > use this driver. > > > > For PEI and DXE phase, platform mush link base DebugLib (without using > > any pei/dxe services, even for its dependent libraries). > > > > This patch default disable this debug message, only open it when need > > to debug the related code. > > > > Signed-off-by: Eric Dong > > Cc: Ray Ni > > Cc: Laszlo Ersek > > > > Eric Dong (2): > > UefiCpuPkg/RegisterCpuFeaturesLib: Default avoid print. > > UefiCpuPkg/PiSmmCpuDxeSmm: Default avoid print. > > > > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 +++- > > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 +++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > -- > > 2.21.0.windows.1