From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: eric.dong@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 01 Aug 2019 18:22:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 18:22:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,336,1559545200"; d="scan'208";a="178007022" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 01 Aug 2019 18:22:15 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 18:22:13 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 18:22:13 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 09:22:12 +0800 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Wu, Hao A" , "Wang, Jian J" Subject: Re: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable Thread-Topic: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable Thread-Index: AQHVSE/LK0dth6+8OkajPc5/E3ZzXKbnEMbw Date: Fri, 2 Aug 2019 01:22:10 +0000 Message-ID: References: <20190801095831.274356-1-ray.ni@intel.com> <20190801095831.274356-5-ray.ni@intel.com> In-Reply-To: <20190801095831.274356-5-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Wu, Hao A ; Wang, Jian J > Subject: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD > PcdUse5LevelPageTable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 >=20 > The PCD indicates if 5-Level Paging will be enabled in long mode. > 5-Level Paging will not be enabled when the PCD is TRUE but CPU doesn't > support 5-Level Paging. >=20 > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Hao A Wu > Cc: Jian J Wang > --- > MdeModulePkg/MdeModulePkg.dec | 7 +++++++ > MdeModulePkg/MdeModulePkg.uni | 8 ++++++++ > 2 files changed, 15 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 12e0bbf579..21388595a9 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1991,6 +1991,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, > PcdsDynamic, PcdsDynamicEx] > # @Prompt The address mask when memory encryption is enabled. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrM > ask|0x0|UINT64|0x30001047 >=20 > + ## Indicates if 5-Level Paging will be enabled in long mode. 5-Level > + Paging will not be enabled # when the PCD is TRUE but CPU doesn't > support 5-Level Paging. > + # TRUE - 5-Level Paging will be enabled.
> + # FALSE - 5-Level Paging will not be enabled.
> + # @Prompt Enable 5-Level Paging support in long mode. > + > + > gEfiMdeModulePkgTokenSpaceGuid.PcdUse5LevelPageTable|FALSE|BOOLE > AN|0x0 > + 001105F > + > ## Capsule In Ram is to use memory to deliver the capsules that will b= e > processed after system > # reset.

> # This PCD indicates if the Capsule In Ram is supported.
diff --g= it > a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni index 2bd1ad29f2..3a1c88e4c5 > 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1298,3 +1298,11 @@ > = "It is used to set VPD region base > address. So, it can't be DynamicExVpd PCD. Its value is" > = "required to be accessed in PcdDxe > driver entry point. So, its value must be set in PEI phase." > = "It can't depend on EFI variable > service, and can't be DynamicExHii PCD." > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_PROMP > T #language en-US "Enable 5-Level Paging support in long mode" > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_HELP > #language en-US "Indicates if 5-Level Paging will be enabled in long mode= . 5- > Level Paging will not be enabled" > + = "when the PCD is TRUE but CPU > doesn't support 5-Level Paging." > + = " TRUE - 5-Level Paging will be > enabled." > + = " FALSE - 5-Level Paging will not be > enabled." > + > -- > 2.21.0.windows.1