From: "Dong, Eric" <eric.dong@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments
Date: Fri, 2 Aug 2019 08:00:20 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259EBB711@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190731033812.12188-1-shenglei.zhang@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, July 31, 2019 11:38 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code
> consistent with comments
>
> From: shenglei <shenglei.zhang@intel.com>
>
> 1.Remove "out" attribute for " Buffer" parameter in function header.
> 2.Add "out" attribute for " Token" parameter in function header.
> 3.Update ProcedureArgument to ProcedureArguments.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2:In v1 update comments consistent with code
> In v2 update code consistent with comments
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index ef16997547b8..328d7ae53a49 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1404,7 +1404,7 @@ InternalSmmStartupAllAPs ( EFI_STATUS EFIAPI
> ProcedureWrapper (
> - IN OUT VOID *Buffer
> + IN VOID *Buffer
> )
> {
> PROCEDURE_WRAPPER *Wrapper;
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index 186809f43119..a0e59f20886b 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1329,7 +1329,7 @@ InternalSmmStartupThisAp (
> IN EFI_AP_PROCEDURE2 Procedure,
> IN UINTN CpuIndex,
> IN OUT VOID *ProcArguments OPTIONAL,
> - IN MM_COMPLETION *Token,
> + IN OUT MM_COMPLETION *Token,
> IN UINTN TimeoutInMicroseconds,
> IN OUT EFI_STATUS *CpuStatus
> );
> @@ -1387,7 +1387,7 @@ IsPresentAp (
> @param[in] TimeoutInMicroseconds Indicates the time limit in
> microseconds for
> APs to return from Procedure, either for
> blocking or non-blocking mode.
> - @param[in,out] ProcedureArgument The parameter passed into
> Procedure for
> + @param[in,out] ProcedureArguments The parameter passed into
> Procedure for
> all APs.
> @param[in,out] Token This is an optional parameter that allows
> the caller to execute the
> procedure in a blocking or non-blocking fashion. If it is
> NULL the
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-08-02 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 3:38 [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments Zhang, Shenglei
2019-08-02 8:00 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259EBB711@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox