From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.dong@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Fri, 02 Aug 2019 01:00:30 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 01:00:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,337,1559545200"; d="scan'208";a="175512837" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 02 Aug 2019 01:00:22 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 2 Aug 2019 01:00:22 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 2 Aug 2019 01:00:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 16:00:20 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments Thread-Topic: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments Thread-Index: AQHVR1FlOtVsU/QJ9UOJePslvUDHDKbngeaA Date: Fri, 2 Aug 2019 08:00:20 +0000 Message-ID: References: <20190731033812.12188-1-shenglei.zhang@intel.com> In-Reply-To: <20190731033812.12188-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, July 31, 2019 11:38 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > > Subject: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code > consistent with comments >=20 > From: shenglei >=20 > 1.Remove "out" attribute for " Buffer" parameter in function header. > 2.Add "out" attribute for " Token" parameter in function header. > 3.Update ProcedureArgument to ProcedureArguments. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > v2:In v1 update comments consistent with code > In v2 update code consistent with comments > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index ef16997547b8..328d7ae53a49 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1404,7 +1404,7 @@ InternalSmmStartupAllAPs ( EFI_STATUS EFIAPI > ProcedureWrapper ( > - IN OUT VOID *Buffer > + IN VOID *Buffer > ) > { > PROCEDURE_WRAPPER *Wrapper; > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index 186809f43119..a0e59f20886b 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1329,7 +1329,7 @@ InternalSmmStartupThisAp ( > IN EFI_AP_PROCEDURE2 Procedure, > IN UINTN CpuIndex, > IN OUT VOID *ProcArguments OPTIONAL, > - IN MM_COMPLETION *Token, > + IN OUT MM_COMPLETION *Token, > IN UINTN TimeoutInMicroseconds, > IN OUT EFI_STATUS *CpuStatus > ); > @@ -1387,7 +1387,7 @@ IsPresentAp ( > @param[in] TimeoutInMicroseconds Indicates the time limit in > microseconds for > APs to return from Procedure, e= ither for > blocking or non-blocking mode. > - @param[in,out] ProcedureArgument The parameter passed into > Procedure for > + @param[in,out] ProcedureArguments The parameter passed into > Procedure for > all APs. > @param[in,out] Token This is an optional parameter t= hat allows > the caller to execute the > procedure in a blocking or non-= blocking fashion. If it is > NULL the > -- > 2.18.0.windows.1