Re: [Patch v2 0/2] UefiCpuPkg: Remove debug message.

["Dong, Eric" <eric.dong@intel.com>]

Hi Laszlo,

Good catch, I will follow up to clean it. Thanks.

Thanks,
Eric

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, August 8, 2019 2:14 AM
> To: Dong, Eric <eric.dong@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: Re: [Patch v2 0/2] UefiCpuPkg: Remove debug message.
> 
> On 08/07/19 19:11, Laszlo Ersek wrote:
> > On 08/05/19 08:43, Eric Dong wrote:
> >> This debug message may be called by BSP and APs. It may caused ASSERT
> >> when APs call this debug code.
> >>
> >> In order to avoid system boot assert, Remove this debug message.
> >>
> >> Cc: Ray Ni <ray.ni@intel.com>
> >> Cc: Laszlo Ersek <lersek@redhat.com>
> >>
> >> Eric Dong (2):
> >>   UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.
> >>   UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.
> >>
> >>  .../CpuFeaturesInitialize.c                   | 22 -------------------
> >>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c             | 22 +------------------
> >>  2 files changed, 1 insertion(+), 43 deletions(-)
> >>
> >
> > It seems to me that, after these patches are applied, no uses of
> > "ConsoleLogLock" remain, in either module (RegisterCpuFeaturesLib and
> > PiSmmCpuDxeSmm).
> >
> > Can we eliminate the field from both modules? Otherwise we'll be left
> > with a useless, initialized spinlock, in each of these modules.
> 
> I can see that this series has been pushed already, so I've now filed a
> reminder:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2060
> 
> Thanks
> Laszlo