From: "Dong, Eric" <eric.dong@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style
Date: Fri, 9 Aug 2019 00:41:45 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259EBF2F4@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190808075448.6760-1-shenglei.zhang@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 8, 2019 3:55 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style
>
> 1. Update CPUStatus to CpuStatus in comments to align comments
> with code.
> 2. Add "OUT" attribute for "ProcedureArguments" parameter in function
> header.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: Add "OUT" attribute for "ProcedureArguments" parameter in both
> function
> header and comments,in MpService.c.
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 6 +++---
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 328d7ae53a49..d8d2b6f44461 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1967,7 +1967,7 @@ RegisterSmmEntry (
> EFI_MP_SERVICES_PROTOCOL.StartupAllAPs.
> If caller may pass a value of NULL to deregister any
> existing
> startup procedure.
> - @param[in] ProcedureArguments Allows the caller to pass a list of
> parameters to the code that is
> + @param[in,out] ProcedureArguments Allows the caller to pass a list of
> parameters to the code that is
> run by the AP. It is an optional common mailbox between
> APs and
> the caller to share information
>
> @@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/ EFI_STATUS
> RegisterStartupProcedure (
> - IN EFI_AP_PROCEDURE Procedure,
> - IN VOID *ProcedureArguments OPTIONAL
> + IN EFI_AP_PROCEDURE Procedure,
> + IN OUT VOID *ProcedureArguments OPTIONAL
> )
> {
> if (Procedure == NULL && ProcedureArguments != NULL) { diff --git
> a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index a0e59f20886b..7b3fbc8b55ec 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1311,7 +1311,7 @@ RestoreCr2 (
> Note that timeout support is optional. Whether an
> implementation
> supports this feature can be determined via the
> Attributes data
> member.
> - @param[in,out] CPUStatus This optional pointer may be used to
> get the status code returned
> + @param[in,out] CpuStatus This optional pointer may be used to
> get the status code returned
> by Procedure when it completes execution on the
> target AP, or with
> EFI_TIMEOUT if the Procedure fails to complete within
> the optional
> timeout. The implementation will update this variable
> with @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/ EFI_STATUS
> RegisterStartupProcedure (
> - IN EFI_AP_PROCEDURE Procedure,
> - IN VOID *ProcedureArguments OPTIONAL
> + IN EFI_AP_PROCEDURE Procedure,
> + IN OUT VOID *ProcedureArguments OPTIONAL
> );
>
> /**
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-08-09 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:54 [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style Zhang, Shenglei
2019-08-09 0:41 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259EBF2F4@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox