From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: eric.dong@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 08 Aug 2019 17:41:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 17:41:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,363,1559545200"; d="scan'208";a="199244917" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2019 17:41:49 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 17:41:49 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 17:41:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.112]) with mapi id 14.03.0439.000; Fri, 9 Aug 2019 08:41:46 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style Thread-Topic: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style Thread-Index: AQHVTb6XQY/F1Q0BSk+aaRKFjerz8Kbx+t3A Date: Fri, 9 Aug 2019 00:41:45 +0000 Message-ID: References: <20190808075448.6760-1-shenglei.zhang@intel.com> In-Reply-To: <20190808075448.6760-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, August 8, 2019 3:55 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style >=20 > 1. Update CPUStatus to CpuStatus in comments to align comments > with code. > 2. Add "OUT" attribute for "ProcedureArguments" parameter in function > header. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > v2: Add "OUT" attribute for "ProcedureArguments" parameter in both > function > header and comments,in MpService.c. > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 6 +++--- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 328d7ae53a49..d8d2b6f44461 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1967,7 +1967,7 @@ RegisterSmmEntry ( > EFI_MP_SERVICES_PROTOCOL.StartupA= llAPs. > If caller may pass a value of NUL= L to deregister any > existing > startup procedure. > - @param[in] ProcedureArguments Allows the caller to pass a list = of > parameters to the code that is > + @param[in,out] ProcedureArguments Allows the caller to pass a list = of > parameters to the code that is > run by the AP. It is an optional = common mailbox between > APs and > the caller to share information >=20 > @@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/ EFI_STATUS > RegisterStartupProcedure ( > - IN EFI_AP_PROCEDURE Procedure, > - IN VOID *ProcedureArguments OPTIONAL > + IN EFI_AP_PROCEDURE Procedure, > + IN OUT VOID *ProcedureArguments OPTIONAL > ) > { > if (Procedure =3D=3D NULL && ProcedureArguments !=3D NULL) { diff --gi= t > a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index a0e59f20886b..7b3fbc8b55ec 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1311,7 +1311,7 @@ RestoreCr2 ( > Note that timeout support is= optional. Whether an > implementation > supports this feature can be= determined via the > Attributes data > member. > - @param[in,out] CPUStatus This optional pointer may be= used to > get the status code returned > + @param[in,out] CpuStatus This optional pointer may be= used to > get the status code returned > by Procedure when it complet= es execution on the > target AP, or with > EFI_TIMEOUT if the Procedure= fails to complete within > the optional > timeout. The implementation = will update this variable > with @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/ EFI_STATUS > RegisterStartupProcedure ( > - IN EFI_AP_PROCEDURE Procedure, > - IN VOID *ProcedureArguments OPTIONAL > + IN EFI_AP_PROCEDURE Procedure, > + IN OUT VOID *ProcedureArguments OPTIONAL > ); >=20 > /** > -- > 2.18.0.windows.1