public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for parameter LeafFunction
@ 2019-08-15  8:15 Zhang, Shenglei
  2019-08-16  4:26 ` [edk2-devel] " Dong, Eric
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2019-08-15  8:15 UTC (permalink / raw)
  To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek

LeafFunction needs to be described in comments.
https://bugzilla.tianocore.org/show_bug.cgi?id=2052

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c b/UefiCpuPkg/Application/Cpuid/Cpuid.c
index 7a994eba9ac8..f39a7fb33ae5 100644
--- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
+++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
@@ -708,6 +708,8 @@ CpuidArchitecturalPerformanceMonitoring (
 /**
   Display CPUID_EXTENDED_TOPOLOGY leafs for all supported levels.
 
+  @param[in] LeafFunction  Leaf function index for CPUID_EXTENDED_TOPOLOGY.
+  
 **/
 VOID
 CpuidExtendedTopology (
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for parameter LeafFunction
  2019-08-15  8:15 [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for parameter LeafFunction Zhang, Shenglei
@ 2019-08-16  4:26 ` Dong, Eric
  0 siblings, 0 replies; 2+ messages in thread
From: Dong, Eric @ 2019-08-16  4:26 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Ni, Ray, Laszlo Ersek

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 4:15 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for
> parameter LeafFunction
> 
> LeafFunction needs to be described in comments.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2052
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> index 7a994eba9ac8..f39a7fb33ae5 100644
> --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> @@ -708,6 +708,8 @@ CpuidArchitecturalPerformanceMonitoring (
>  /**
>    Display CPUID_EXTENDED_TOPOLOGY leafs for all supported levels.
> 
> +  @param[in] LeafFunction  Leaf function index for
> CPUID_EXTENDED_TOPOLOGY.
> +
>  **/
>  VOID
>  CpuidExtendedTopology (
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-16  4:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-15  8:15 [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for parameter LeafFunction Zhang, Shenglei
2019-08-16  4:26 ` [edk2-devel] " Dong, Eric

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox