From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: eric.dong@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 04 Sep 2019 23:16:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 23:16:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,469,1559545200"; d="scan'208";a="383744428" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 04 Sep 2019 23:16:21 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Sep 2019 23:16:20 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Sep 2019 23:16:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Thu, 5 Sep 2019 14:16:18 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHVY6X3gl+LJEBjDE6ELravEC51daccm3mg Date: Thu, 5 Sep 2019 06:16:17 +0000 Message-ID: References: <20190905045353.21040-1-dandan.bi@intel.com> In-Reply-To: <20190905045353.21040-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, September 5, 2019 12:54 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid >=20 > gEfiFormBrowserExProtocolGuid is not used in edk2, and it can be replaced= by > gEdkiiFormBrowserExProtocolGuid. > So remove gEfiFormBrowserExProtocolGuid to avoid confusion. >=20 > Cc: Eric Dong > Cc: Liming Gao > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > Signed-off-by: Dandan Bi > --- > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 - > MdeModulePkg/MdeModulePkg.dec | 1 - > 2 files changed, 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > index c36aa6bdf1..e7e7cd18ab 100644 > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > @@ -141,10 +141,9 @@ struct > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL { > REGISTER_HOT_KEY RegisterHotKey; > REGISTER_EXIT_HANDLER RegiserExitHandler; > SAVE_REMINDER SaveReminder; > }; >=20 > -extern EFI_GUID gEfiFormBrowserExProtocolGuid; extern EFI_GUID > gEdkiiFormBrowserExProtocolGuid; >=20 > #endif >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 19935c88fa..ab29a279b1 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -529,11 +529,10 @@ [Protocols] >=20 > ## Include/Protocol/LockBox.h > gEfiLockBoxProtocolGuid =3D { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9= a, 0xd8, > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }} >=20 > ## Include/Protocol/FormBrowserEx.h > - gEfiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1= , > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } > gEdkiiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, { 0x= a1, > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } >=20 > ## Include/Protocol/EbcVmTest.h > gEfiEbcVmTestProtocolGuid =3D { 0xAAEACCFD, 0xF27B, 0x4C17, { 0xB6, 0x= 10, > 0x75, 0xCA, 0x1F, 0x2D, 0xFB, 0x52 } } >=20 > -- > 2.18.0.windows.1