From: "Dong, Eric" <eric.dong@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] UefiCpuPkg: Update the coding styles
Date: Tue, 19 Nov 2019 05:22:30 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662259F42198@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20191114114644.5504-4-shenglei.zhang@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH] UefiCpuPkg: Update the coding styles
>
> From: Shenglei Zhang <shenglei.zhang@intel.com>
>
> In MpLib.c, remove the white space on a new line.
> In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 49be5d5385d9..d32adf0780b7 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -475,7 +475,7 @@ CollectProcessorCount (
> CpuPause ();
> }
>
> -
> +
> //
> // Enable x2APIC mode if
> // 1. Number of CPU is greater than 255; or diff --git
> a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> index f891a811126f..2483f2ea849d 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> @@ -342,7 +342,7 @@ RestoreCr2 (
>
> @retval TRUE Access to non-SMRAM is restricted.
> @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
> BOOLEAN
> IsRestrictedMemoryAccess (
> VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index e5c4788c13d7..810985df20ae 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1275,7 +1275,7 @@ RestoreCr2 (
>
> @retval TRUE Access to non-SMRAM is restricted.
> @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
> BOOLEAN
> IsRestrictedMemoryAccess (
> VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7e7c73f27f76 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
>
> @retval TRUE Access to non-SMRAM is restricted.
> @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
> BOOLEAN
> IsRestrictedMemoryAccess (
> VOID
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-11-19 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 11:46 [PATCH 0/3] Add missing strings for uni files Zhang, Shenglei
2019-11-14 11:46 ` [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD Zhang, Shenglei
2019-11-19 8:00 ` Wang, Jian J
2019-11-14 11:46 ` [PATCH] MdePkg: Update the comments of IsLanguageSupported Zhang, Shenglei
2019-11-14 15:42 ` Liming Gao
2019-11-14 11:46 ` [PATCH] UefiCpuPkg: Update the coding styles Zhang, Shenglei
2019-11-19 5:22 ` Dong, Eric [this message]
2019-11-19 17:30 ` [edk2-devel] " Laszlo Ersek
2019-11-14 11:46 ` [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD Zhang, Shenglei
2019-11-19 7:13 ` Wu, Jiaxin
2019-11-14 11:46 ` [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: " Zhang, Shenglei
2019-11-19 7:22 ` Dong, Eric
2019-11-14 12:02 ` [edk2-devel] [PATCH 0/3] Add missing strings for uni files Laszlo Ersek
2019-11-16 14:34 ` Zhang, Shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662259F42198@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox